Add codecov integration #1749
Merged
Add codecov integration #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import coverdata into codecov.json Use module_info to find source files location
Codecov Report
@@ Coverage Diff @@
## master #1749 +/- ##
=========================================
Coverage ? 74.62%
=========================================
Files ? 283
Lines ? 26564
Branches ? 0
=========================================
Hits ? 19823
Misses ? 6741
Partials ? 0Continue to review full report at Codecov.
|
kzemek
suggested changes
Mar 2, 2018
| try | ||
| AbsPath = proplists:get_value(source, Module:module_info(compile)), | ||
| string:prefix(AbsPath, get_repo_dir()) | ||
| of nomatch -> |
| get_source_path(Module) when is_atom(Module) -> | ||
| try | ||
| AbsPath = proplists:get_value(source, Module:module_info(compile)), | ||
| string:prefix(AbsPath, get_repo_dir()) |
There was a problem hiding this comment.
AFAIK this function was introduced in Erlang 20, so paths would be messed up in other builds.
| string_suffix(String, Suffix) -> | ||
| StringR = lists:reverse(String), | ||
| SuffixR = lists:reverse(Suffix), | ||
| lists:reverse(string:prefix(StringR, SuffixR)). |
kzemek
approved these changes
Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: https://codecov.io/gh/esl/MongooseIM/tree/651a44752aa95cb390c4e277a3119c9463905292/src
Import coverdata into codecov.json.
Use module_info to find source files location.
It increases travis job time by ~ 15 seconds.
Admin stuff
The PR can be merged without "admin stuff" tasks.
Apparently, the only thing is missing without granting access is a check in "All checks have passed" from codecov.
To enable codecov bot, add esl/MongooseIM to https://codecov.io/ (10 minutes for someone who have admin access for esl github account).
first auth codecov using github oauth. It does not give codecov code access, but they can comment to PRs.
than enable codecov for a specific repo on codecov site. Probably somewhere https://codecov.io/gh/esl/MongooseIM
The bot makes comments like this: do not merge, disables some tests arcusfelis/MongooseIM#26 (comment)
Should be free for public repos.