Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fast_tls to 1.0.20 and cache_tab to 1.0.12 #1753

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Conversation

fenek
Copy link
Member

@fenek fenek commented Mar 5, 2018

fast_tls 1.0.20 includes several improvements, including fixes for potential memory leaks.

It fixes "null ssl context" OpenSSL error observed in one of Docker-based environments:

2018-02-28 15:12:06 =CRASH REPORT====
  crasher:
    initial call: mod_global_distrib_receiver:init/1
    pid: <0.1002.0>
    registered_name: []
    exception error: {{badmatch,{error,<<"SSL_new failed: error:140BA0C3:SSL routines:SSL_new:null ssl ctx">>}},[{mod_global_distrib_receiver,init,1,[{file,"/tmp/mongooseim/_build/prod/lib/mongooseim/src/global_distrib/mod_global_distrib_receiver.erl"},{line,76}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,247}]}]}
    ancestors: [<0.628.0>,<0.627.0>,ranch_sup,<0.254.0>]
    message_queue_len: 0
    messages: []
    links: [<0.628.0>,#Port<0.17285>]
    dictionary: []
    trap_exit: true
    status: running
    heap_size: 1598
    stack_size: 27
    reductions: 371
  neighbours:
2018-02-28 15:12:06 =ERROR REPORT====
Ranch listener {{172,21,1,1},5555} had connection process started with mod_global_distrib_receiver:start_link/4 at <0.1002.0> exit with reason: {{badmatch,{error,<<"SSL_new failed: error:140BA0C3:SSL routines:SSL_new:null ssl ctx">>}},[{mod_global_distrib_receiver,init,1,[{file,"/tmp/mongooseim/_build/prod/lib/mongooseim/src/global_distrib/mod_global_distrib_receiver.erl"},{line,76}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,247}]}]}

@fenek fenek added the WIP 🚧 label Mar 5, 2018
@codecov-io
Copy link

Codecov Report

Merging #1753 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1753      +/-   ##
==========================================
+ Coverage   74.55%   74.68%   +0.13%     
==========================================
  Files         283      283              
  Lines       26573    26573              
==========================================
+ Hits        19811    19846      +35     
+ Misses       6762     6727      -35
Impacted Files Coverage Δ
...rc/global_distrib/mod_global_distrib_transport.erl 47.05% <0%> (-5.89%) ⬇️
src/mod_push_service_mongoosepush.erl 88.23% <0%> (-5.89%) ⬇️
src/mod_mam_muc_odbc_async_pool_writer.erl 70.73% <0%> (-3.26%) ⬇️
src/mongoose_client_api_sse.erl 75% <0%> (-3.13%) ⬇️
src/mod_bosh_socket.erl 80.66% <0%> (-1%) ⬇️
src/mod_roster.erl 78.92% <0%> (-0.25%) ⬇️
src/mod_pubsub.erl 66.01% <0%> (+0.06%) ⬆️
src/mod_muc.erl 69.25% <0%> (+0.27%) ⬆️
src/mod_mam.erl 89.43% <0%> (+0.37%) ⬆️
src/mod_muc_room.erl 77.24% <0%> (+0.77%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc9abfe...87a4a55. Read the comment docs.

@fenek fenek merged commit 0c501f7 into master Mar 7, 2018
@fenek fenek deleted the fast-tls-1-0-20 branch March 7, 2018 11:56
Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@fenek fenek added this to the 3.0.0 milestone Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants