Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push notifications refactoring #1796

Merged
merged 5 commits into from
Apr 10, 2018
Merged

Push notifications refactoring #1796

merged 5 commits into from
Apr 10, 2018

Conversation

fenek
Copy link
Member

@fenek fenek commented Apr 10, 2018

Patched version of #1773

@fenek fenek added this to the 2.2.0 milestone Apr 10, 2018
@codecov
Copy link

codecov bot commented Apr 10, 2018

Codecov Report

Merging #1796 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1796      +/-   ##
==========================================
- Coverage   74.48%   74.43%   -0.06%     
==========================================
  Files         290      290              
  Lines       26942    26947       +5     
==========================================
- Hits        20068    20058      -10     
- Misses       6874     6889      +15
Impacted Files Coverage Δ
src/event_pusher/mod_event_pusher_push.erl 88.88% <100%> (-1.7%) ⬇️
src/event_pusher/mod_event_pusher_http.erl 97.14% <100%> (+0.08%) ⬆️
...t_pusher/mod_event_pusher_push_plugin_defaults.erl 100% <100%> (ø) ⬆️
src/event_pusher/mod_event_pusher.erl 90.47% <100%> (ø) ⬆️
src/event_pusher/mod_event_pusher_sns.erl 85.52% <100%> (+0.39%) ⬆️
src/event_pusher/mod_event_pusher_push_plugin.erl 100% <100%> (ø) ⬆️
..._distrib/mod_global_distrib_outgoing_conns_sup.erl 73.91% <0%> (-8.7%) ⬇️
...rc/global_distrib/mod_global_distrib_transport.erl 47.05% <0%> (-5.89%) ⬇️
src/mod_push_service_mongoosepush.erl 82.85% <0%> (-5.72%) ⬇️
src/mod_mam_odbc_async_pool_writer.erl 66.89% <0%> (-2.71%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4382421...7aa01ba. Read the comment docs.

@fenek fenek merged commit a66b39d into master Apr 10, 2018
@fenek fenek deleted the push-notifications-refactoring branch April 10, 2018 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants