Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XEP-0079 specifies the following work-flow for processing AMP-tagged messages:
This PR moves AMP strategy resolution from the
filter_packet
hook to a new hook inejabberd_c2s
.This hook (
amp_check_packet
) is run in the transistion between thesession_established
andsession_established2
states. Checking AMP this early in the pipeline makes sure that no server-side effects (likeuser_send_packet
) are triggered before the AMP strategy is decided.Also, because http://xmpp.org/extensions/xep-0079.html#security is not implemented,
mod_amp
is disabled in the defaultejabberd.cfg
.