-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auth for mongoose_domain_handler #3160
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3160 +/- ##
==========================================
- Coverage 79.89% 79.88% -0.01%
==========================================
Files 396 396
Lines 32335 32356 +21
==========================================
+ Hits 25834 25849 +15
- Misses 6501 6507 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good in general. I have some minor comments.
rel/files/mongooseim.toml
Outdated
username = "admin" | ||
password = "secret" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if it's good to set up such defaults in the config file... they aren't more secure than having no auth. Maybe we could leave out these two options? This way the user would have to consciously set something here. This would be also more in line with the docs, which document these two fields as empty by default. I know that this is not equal to them being empty in the default config file... but in this case I think they can be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have a way to dynamically start cowboy handlers?
One more thing, it would be good to add a test case to |
74cdbd4
to
12513dd
Compare
Use start_listener in the service_domain_db_SUITE
12513dd
to
d87ef26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have two minor remarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
This PR addresses #
Proposed changes include: