Support OTP 24.X #3186
Support OTP 24.X #3186
Conversation
vkatsuba
requested review from
arcusfelis,
chrzaszcz,
DenysGonchar and
NelsonVides
vkatsuba
force-pushed
the
refactoring/otp-24.0.2
branch
from
3eea021 to
a118869
Compare
Codecov Report
@@ Coverage Diff @@
## master #3186 +/- ##
==========================================
- Coverage 80.32% 80.31% -0.01%
==========================================
Files 396 396
Lines 32348 32383 +35
==========================================
+ Hits 25984 26009 +25
- Misses 6364 6374 +10
Continue to review full report at Codecov.
|
vkatsuba
force-pushed
the
refactoring/otp-24.0.2
branch
from
2189338 to
3be5489
Compare
vkatsuba
removed request for
arcusfelis,
chrzaszcz,
DenysGonchar and
NelsonVides
vkatsuba
force-pushed
the
refactoring/otp-24.0.2
branch
3 times, most recently
from
0374f90 to
372629d
Compare
vkatsuba
requested review from
arcusfelis,
chrzaszcz,
NelsonVides and
DenysGonchar
and removed request for
arcusfelis
vkatsuba
force-pushed
the
refactoring/otp-24.0.2
branch
from
372629d to
80b0705
Compare
|
small_tests_23 / small_tests / 80b0705 internal_mnesia / internal_mnesia / 80b0705 dynamic_domains / pgsql_mnesia / 80b0705 small_tests_24 / small_tests / 80b0705 ldap_mnesia_22 / ldap_mnesia / 80b0705 ldap_mnesia_24 / ldap_mnesia / 80b0705 ldap_mnesia_23 / ldap_mnesia / 80b0705 pgsql_mnesia / pgsql_mnesia / 80b0705 mysql_redis / mysql_redis / 80b0705 elasticsearch_and_cassandra / elasticsearch_and_cassandra_mnesia / 80b0705 s2s_SUITE:both_tls_optional:simple_message{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"alice_simple_message_71.594574@fed1/res1">>,
escalus_tcp,<0.20880.1>,
[{event_manager,<0.20876.1>},
{server,<<"fed1">>},
{username,<<"alice_simple_message_71.594574">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.20876.1>},
{server,<<"fed1">>},
{username,<<"alice_simple_message_71.594574">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_simple_message_71.594574">>},
{server,<<"fed1">>},
{host,<<"localhost">>},
{port,5242},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alice_simple_message_71.594574">>},
{server,<<"fed1">>},
{host,<<"localhost">>},
{port,5242},
{password,<<"makota2">>},
{stream_id,<<"3a77a55df35848b9">>}]},
10000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{s2s_SUITE,'-simple_message/1-fun-0-',2,
[{file,"/home/circleci/app/big_tests/tests/s2s_SUITE.erl"},
{line,124}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_serve...mssql_mnesia / odbc_mssql_mnesia / 80b0705 riak_mnesia / riak_mnesia / 80b0705 |
There was a problem hiding this comment.
Few comments. big_tests/rebar3 shouldn't exist there, please remove it and also rebase the removal so that the git history in master doesn't grow almost a MB 😅
Then, usually our CI pipeline is to test everything on the latest OTP, and then a reduce set (small_tests and ldap_mnesia) on the previous two versions: the idea would be to replicate what we see here but incrementing everything one version. And if we can successfully run ldap on OTP24, I'd expect we can already run everything 😄
I'd also try to keep the CI files organised, pay attention to the sections marked with comments explaining which version is being configured and so on.
vkatsuba
force-pushed
the
refactoring/otp-24.0.2
branch
from
80b0705 to
4681a0e
Compare
The rebar was removed, and rebased. About |
vkatsuba
force-pushed
the
refactoring/otp-24.0.2
branch
from
4681a0e to
d441f2b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
vkatsuba
force-pushed
the
refactoring/otp-24.0.2
branch
from
0218f15 to
e53a622
Compare
This comment has been minimized.
This comment has been minimized.
vkatsuba
force-pushed
the
refactoring/otp-24.0.2
branch
from
7ae7133 to
bb30d4d
Compare
This comment has been minimized.
This comment has been minimized.
|
small_tests_23 / small_tests / bb30d4d small_tests_24 / small_tests / bb30d4d internal_mnesia / internal_mnesia / bb30d4d small_tests_22 / small_tests / bb30d4d dynamic_domains / pgsql_mnesia / bb30d4d ldap_mnesia_24 / ldap_mnesia / bb30d4d ldap_mnesia_22 / ldap_mnesia / bb30d4d elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / bb30d4d pgsql_mnesia_22 / pgsql_mnesia / bb30d4d ldap_mnesia_23 / ldap_mnesia / bb30d4d mysql_redis_24 / mysql_redis / bb30d4d elasticsearch_and_cassandra / elasticsearch_and_cassandra_mnesia / bb30d4d jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate{error,
{{assertion_failed,assert,is_iq_result,
{xmlel,<<"iq">>,
[{<<"from">>,<<"error.480@localhost">>},
{<<"to">>,
<<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_66.366262@localhost/res1">>},
{<<"id">>,<<"465ed0eb-f1ed-4db7-9ce8-743f1fe46e85">>},
{<<"type">>,<<"set">>}],
[{xmlel,<<"jingle">>,
[{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
{<<"action">>,<<"session-terminate">>},
{<<"sid">>,<<"8603c2c3-d401-4e75-930b-e8a94d573c1a">>}],
[{xmlel,<<"reason">>,[],
[{xmlel,<<"general-error">>,[],[]},
{xmlel,<<"sip-error">>,
[{<<"code">>,<<"480">>}],
[{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
"<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_66.366262@localhost/res1' id='465ed0eb-f1ed-4db7-9ce8-743f1fe46e85' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='8603c2c3-d401-4e75-930b-e8a94d573c1a'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
[{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
{line,393}]},
{jingle_SUITE,
'-res...pgsql_mnesia_24 / pgsql_mnesia / bb30d4d pgsql_mnesia / pgsql_mnesia / bb30d4d mssql_mnesia / odbc_mssql_mnesia / bb30d4d mssql_mnesia_24 / odbc_mssql_mnesia / bb30d4d mysql_redis / mysql_redis / bb30d4d riak_mnesia_24 / riak_mnesia / bb30d4d riak_mnesia / riak_mnesia / bb30d4d s2s_SUITE:node1_tls_optional_node2_tls_required:simple_message{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"alice_simple_message_34.893377@fed1/res1">>,
escalus_tcp,<0.18114.1>,
[{event_manager,<0.18110.1>},
{server,<<"fed1">>},
{username,<<"alice_simple_message_34.893377">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.18110.1>},
{server,<<"fed1">>},
{username,<<"alice_simple_message_34.893377">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_simple_message_34.893377">>},
{server,<<"fed1">>},
{host,<<"localhost">>},
{port,5242},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alice_simple_message_34.893377">>},
{server,<<"fed1">>},
{host,<<"localhost">>},
{port,5242},
{password,<<"makota2">>},
{stream_id,<<"c074b4f9a3025285">>}]},
10000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{s2s_SUITE,'-simple_message/1-fun-0-',2,
[{file,"/home/circleci/app/big_tests/tests/s2s_SUITE.erl"},
{line,124}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_serve... |
Expand compile warnings: ./rebar3 compile
Expand dialyzer warnings: ./rebar3 dialyzer