Fix run hook(xmpp_send_element) with undefined host_type for c2s #3239
Conversation
vkatsuba
requested review from
arcusfelis,
chrzaszcz,
DenysGonchar and
NelsonVides
Codecov Report
@@ Coverage Diff @@
## master #3239 +/- ##
==========================================
+ Coverage 78.59% 80.37% +1.77%
==========================================
Files 398 398
Lines 32534 32536 +2
==========================================
+ Hits 25571 26150 +579
+ Misses 6963 6386 -577
Continue to review full report at Codecov.
|
|
small_tests_24 / small_tests / c97219b internal_mnesia_24 / internal_mnesia / c97219b amp_big_SUITE:offline:offline_success:notify_deliver_to_malformed_jid_test{error,
{{assertion_failed,assert,is_presence,
{xmlel,<<"stream:error">>,[],
[{xmlel,<<"conflict">>,
[{<<"xmlns">>,<<"urn:ietf:params:xml:ns:xmpp-streams">>}],
[]},
{xmlel,<<"text">>,
[{<<"xml:lang">>,<<"en">>},
{<<"xmlns">>,<<"urn:ietf:params:xml:ns:xmpp-streams">>}],
[{xmlcdata,<<"Replaced by new connection">>}]}]},
"<stream:error><conflict xmlns='urn:ietf:params:xml:ns:xmpp-streams'/><text xml:lang='en' xmlns='urn:ietf:params:xml:ns:xmpp-streams'>Replaced by new connection</text></stream:error>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_story,'-drop_presences/2-lc$^0/1-0-',1,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,190}]},
{escalus_story,drop_presences,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,190}]},
{escalus_story,'-start_ready_clients/2-fun-0-',3,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,135}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_story,start_ready_clients,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,128}]},
...small_tests_22 / small_tests / c97219b dynamic_domains_23 / pgsql_mnesia / c97219b dynamic_domains_24 / pgsql_mnesia / c97219b small_tests_23 / small_tests / c97219b ldap_mnesia_24 / ldap_mnesia / c97219b ldap_mnesia_22 / ldap_mnesia / c97219b ldap_mnesia_23 / ldap_mnesia / c97219b pgsql_mnesia_24 / pgsql_mnesia / c97219b pgsql_mnesia_22 / pgsql_mnesia / c97219b elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / c97219b mysql_redis_24 / mysql_redis / c97219b mssql_mnesia_24 / odbc_mssql_mnesia / c97219b inbox_SUITE:muclight:groupchat_markers_one_reset_room_created{error,{badarg,[{erlang,binary_to_integer,
[undefined],
[{error_info,#{module => erl_erts_errors}}]},
{inbox_helper,get_result_el,2,
[{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
{line,236}]},
{inbox_helper,'-check_result/2-fun-0-',3,
[{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
{line,241}]},
{maps,filter_1,2,[{file,"maps.erl"},{line,318}]},
{maps,filter,2,[{file,"maps.erl"},{line,309}]},
{inbox_helper,get_inbox,3,
[{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
{line,222}]},
{inbox_helper,check_inbox,4,
[{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
{line,167}]},
{inbox_helper,'-foreach_check_inbox/4-lc$^0/1-0-',4,
[{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
{line,151}]}]}}riak_mnesia_24 / riak_mnesia / c97219b mssql_mnesia_24 / odbc_mssql_mnesia / c97219b |
vkatsuba
changed the title
vkatsuba
changed the title
vkatsuba
force-pushed
the
fix/run_undefined_host_type
branch
from
c97219b to
89d9565
Compare
vkatsuba
force-pushed
the
fix/run_undefined_host_type
branch
from
89d9565 to
5705f6f
Compare
|
small_tests_24 / small_tests / 89d9565 internal_mnesia_24 / internal_mnesia / 89d9565 amp_big_SUITE:basic:notify_deliver_to_offline_user_recipient_privacy_test{error,
{{assertion_failed,assert,is_presence,
{xmlel,<<"stream:error">>,[],
[{xmlel,<<"conflict">>,
[{<<"xmlns">>,<<"urn:ietf:params:xml:ns:xmpp-streams">>}],
[]},
{xmlel,<<"text">>,
[{<<"xml:lang">>,<<"en">>},
{<<"xmlns">>,<<"urn:ietf:params:xml:ns:xmpp-streams">>}],
[{xmlcdata,<<"Replaced by new connection">>}]}]},
"<stream:error><conflict xmlns='urn:ietf:params:xml:ns:xmpp-streams'/><text xml:lang='en' xmlns='urn:ietf:params:xml:ns:xmpp-streams'>Replaced by new connection</text></stream:error>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_story,'-drop_presences/2-lc$^0/1-0-',1,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,190}]},
{escalus_story,drop_presences,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,190}]},
{escalus_story,'-start_ready_clients/2-fun-0-',3,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,135}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_story,start_ready_clients,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,128}]},
...amp_big_SUITE:offline:offline_failure:notify_deliver_to_offline_user_recipient_privacy_test{error,
{{assertion_failed,assert,is_presence,
{xmlel,<<"stream:error">>,[],
[{xmlel,<<"conflict">>,
[{<<"xmlns">>,<<"urn:ietf:params:xml:ns:xmpp-streams">>}],
[]},
{xmlel,<<"text">>,
[{<<"xml:lang">>,<<"en">>},
{<<"xmlns">>,<<"urn:ietf:params:xml:ns:xmpp-streams">>}],
[{xmlcdata,<<"Replaced by new connection">>}]}]},
"<stream:error><conflict xmlns='urn:ietf:params:xml:ns:xmpp-streams'/><text xml:lang='en' xmlns='urn:ietf:params:xml:ns:xmpp-streams'>Replaced by new connection</text></stream:error>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_story,'-drop_presences/2-lc$^0/1-0-',1,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,190}]},
{escalus_story,drop_presences,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,190}]},
{escalus_story,'-start_ready_clients/2-fun-0-',3,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,135}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_story,start_ready_clients,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,128}]},
... |
|
small_tests_24 / small_tests / 5705f6f internal_mnesia_24 / internal_mnesia / 5705f6f small_tests_22 / small_tests / 5705f6f small_tests_23 / small_tests / 5705f6f dynamic_domains_23 / pgsql_mnesia / 5705f6f dynamic_domains_24 / pgsql_mnesia / 5705f6f ldap_mnesia_24 / ldap_mnesia / 5705f6f ldap_mnesia_23 / ldap_mnesia / 5705f6f ldap_mnesia_22 / ldap_mnesia / 5705f6f pgsql_mnesia_24 / pgsql_mnesia / 5705f6f pgsql_mnesia_23 / pgsql_mnesia / 5705f6f elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 5705f6f mysql_redis_24 / mysql_redis / 5705f6f mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted{error,
{{assertMatch,
[{module,mod_event_pusher_rabbit_SUITE},
{line,435},
{expression,
"get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
{pattern,
"# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
{value,
#{<<"from_user_id">> =>
<<"[email protected]/bOb_unnamed_96.621207">>,
<<"message">> => <<"Hi there!">>,
<<"to_user_id">> =>
<<"alice_unnamed_96.782732@localhost/res1">>}}]},
[{mod_event_pusher_rabbit_SUITE,
'-group_chat_message_received_event_properly_formatted/1-fun-1-',3,
[{file,
"/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
{line,435}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted{error,
{{assertMatch,
[{module,mod_event_pusher_rabbit_SUITE},
{line,435},
{expression,
"get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
{pattern,
"# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
{value,
#{<<"from_user_id">> =>
<<"[email protected]/bOb_unnamed_97.236432">>,
<<"message">> => <<"Hi there!">>,
<<"to_user_id">> =>
<<"alice_unnamed_97.547628@localhost/res1">>}}]},
[{mod_event_pusher_rabbit_SUITE,
'-group_chat_message_received_event_properly_formatted/1-fun-1-',3,
[{file,
"/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
{line,435}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted{error,
{{assertMatch,
[{module,mod_event_pusher_rabbit_SUITE},
{line,435},
{expression,
"get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
{pattern,
"# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
{value,
#{<<"from_user_id">> =>
<<"[email protected]/bOb_unnamed_97.370445">>,
<<"message">> => <<"Hi there!">>,
<<"to_user_id">> =>
<<"alice_unnamed_98.294001@localhost/res1">>}}]},
[{mod_event_pusher_rabbit_SUITE,
'-group_chat_message_received_event_properly_formatted/1-fun-1-',3,
[{file,
"/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
{line,435}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}pgsql_mnesia_22 / pgsql_mnesia / 5705f6f mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted{error,
{{assertMatch,
[{module,mod_event_pusher_rabbit_SUITE},
{line,435},
{expression,
"get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
{pattern,
"# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
{value,
#{<<"from_user_id">> => <<"[email protected]">>,
<<"message">> => <<>>,
<<"to_user_id">> =>
<<"alice_unnamed_3.467316@localhost/res1">>}}]},
[{mod_event_pusher_rabbit_SUITE,
'-group_chat_message_received_event_properly_formatted/1-fun-0-',3,
[{file,
"/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
{line,435}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1195}]}]}}mssql_mnesia_24 / odbc_mssql_mnesia / 5705f6f carboncopy_SUITE:all:prop_forward_sent_chat_messages{error,
{{assertEqual,
[{module,carboncopy_SUITE},
{line,277},
{expression,
"proper : quickcheck ( proper : conjunction ( [ { PropName , Property } ] ) , [ verbose , long_result , { numtests , 3 } ] )"},
{expected,true},
{value,
[[{forward_sent,
[{4,<<"Long withering out a young man revenue.">>}]}]]}]},
[{carboncopy_SUITE,run_prop,2,
[{file,"/home/circleci/app/big_tests/tests/carboncopy_SUITE.erl"},
{line,277}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}riak_mnesia_24 / riak_mnesia / 5705f6f sm_SUITE:parallel_manual_ack_freq_1:resume_session_state_stop_c2s{error,{thrown,{timeout,msg}}}mysql_redis_24 / mysql_redis / 5705f6f |
|
please, add some description. |
Done. |
|
what are the conditions that lead to this problem? |
When user has bad domain as result has undefined host type. |
The error appears when user tries to connect with unknown (unconfigured) domain and the default domain name provided in MIM config file is not associated with any host type.
When hook runs for an undefined host type, which causes the following error:
when=2021-08-10T08:10:43.253721+00:00 level=error what=undefined_host_type pid=<0.18221.0> at=mongoose_hooks:run_hook_for_host_type/4:1465 text="Running hook for an undefined host type" hook_name=xmpp_send_element hook_args="[{xmlel,<<\"stream:error\">>,[],[{xmlel,<<\"host-unknown\">>,[{<<\"xmlns\">>,<<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],[]}]}]" hook_acc_timestamp=1628583043253572 hook_acc_stanza_type=undefined hook_acc_stanza_to_jid=undefined hook_acc_stanza_ref=#Ref<0.2319972469.246677507.66886> hook_acc_stanza_name=stream:error hook_acc_stanza_from_jid="{jid,<<>>,<<\"test-domain-50005\">>,<<>>,<<>>,<<\"test-domain-50005\">>,<<>>}" hook_acc_stanza_element="{xmlel,<<\"stream:error\">>,[],[{xmlel,<<\"host-unknown\">>,[{<<\"xmlns\">>,<<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],[]}]}" hook_acc_ref=#Ref<0.2319972469.246677507.66887> hook_acc_origin_stanza="<stream:error><host-unknown xmlns='urn:ietf:params:xml:ns:xmpp-streams'/></stream:error>" hook_acc_origin_pid=<0.18221.0> hook_acc_origin_location_mfa={ejabberd_c2s,send_element_from_server_jid,3} hook_acc_origin_location_line=1643 hook_acc_origin_location_file=/home/circleci/app/src/ejabberd_c2s.erl hook_acc_non_strippable= hook_acc_mongoose_acc=true hook_acc_lserver=test-domain-50005 hook_acc_host_type=undefined