Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement domain removal in mod_offline #3299

Merged
merged 4 commits into from
Sep 24, 2021
Merged

Conversation

Premwoik
Copy link
Contributor

This PR implements domain removal in mod_roster (only RDBMS). It adds domain removal hook, domain removal callback in the RDBMS module, and test case.

Also: Beautify tests for domain removal from mod_roster.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 24, 2021

small_tests_24 / small_tests / 366854d
Reports root / small


internal_mnesia_24 / internal_mnesia / 366854d
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 293 / Auto-skipped: 0


small_tests_23 / small_tests / 366854d
Reports root / small


dynamic_domains_24 / pgsql_mnesia / 366854d
Reports root/ big
OK: 2698 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 366854d
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 396 / Auto-skipped: 0


dynamic_domains_23 / pgsql_mnesia / 366854d
Reports root/ big
OK: 2698 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 366854d
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 396 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 366854d
Reports root/ big
OK: 3050 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 366854d
Reports root/ big
OK: 3067 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 366854d
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 319 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 366854d
Reports root/ big
OK: 3067 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 366854d
Reports root/ big
OK: 3067 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 366854d
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 322 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #3299 (366854d) into master (def9c13) will increase coverage by 0.09%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3299      +/-   ##
==========================================
+ Coverage   80.17%   80.26%   +0.09%     
==========================================
  Files         398      398              
  Lines       32577    32584       +7     
==========================================
+ Hits        26120    26155      +35     
+ Misses       6457     6429      -28     
Impacted Files Coverage Δ
src/offline/mod_offline.erl 77.83% <75.00%> (-0.07%) ⬇️
src/offline/mod_offline_rdbms.erl 94.20% <100.00%> (+0.26%) ⬆️
src/ejabberd.erl 45.00% <0.00%> (-10.00%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 74.57% <0.00%> (-2.26%) ⬇️
src/global_distrib/mod_global_distrib_receiver.erl 78.88% <0.00%> (-1.12%) ⬇️
src/mod_roster.erl 78.85% <0.00%> (-0.48%) ⬇️
src/mod_muc.erl 73.76% <0.00%> (-0.23%) ⬇️
src/mod_muc_room.erl 77.12% <0.00%> (-0.06%) ⬇️
src/mod_muc_log.erl 77.88% <0.00%> (ø)
src/ejabberd_c2s.erl 89.29% <0.00%> (+0.07%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update def9c13...366854d. Read the comment docs.

@Premwoik Premwoik marked this pull request as ready for review September 24, 2021 08:29
@vkatsuba vkatsuba merged commit 9a1b241 into master Sep 24, 2021
@vkatsuba vkatsuba deleted the domain-removal-mod-offline branch September 24, 2021 08:38
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants