-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate mod_muc_light_db to mongoose_backend #3351
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## without-dynamic-backend-modules #3351 +/- ##
===================================================================
+ Coverage 80.75% 80.76% +0.01%
===================================================================
Files 404 405 +1
Lines 32550 32598 +48
===================================================================
+ Hits 26286 26329 +43
- Misses 6264 6269 +5
Continue to review full report at Codecov.
|
Note also the many dialyzer error that were hiding behind a dynamic callstack. They were all wrong specs and not wrong code, but still, nice not to hide them any longer.
small_tests_24 / small_tests / d7ebf1d internal_mnesia_24 / internal_mnesia / d7ebf1d small_tests_23 / small_tests / d7ebf1d dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d7ebf1d ldap_mnesia_24 / ldap_mnesia / d7ebf1d dynamic_domains_mysql_redis_24 / mysql_redis / d7ebf1d mam_SUITE:rdbms_async_pool_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}} mam_SUITE:rdbms_async_cache_prefs_cases:messages_filtered_when_prefs_default_policy_is_never{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}} dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / d7ebf1d ldap_mnesia_23 / ldap_mnesia / d7ebf1d mod_ping_SUITE:server_ping_kill:server_ping_pong{error,{{badmatch,[{[<<"localhost">>,mod_ping,ping_response],
{expected_diff,5},
{before_story,5},
{after_story,9}}]},
[{escalus_mongooseim,post_story_check_metrics,1,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
{line,74}]},
{escalus_mongooseim,maybe_check_metrics_post_story,1,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
{line,51}]},
{escalus_story,story,4,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,75}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1784}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1293}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1225}]}]}} dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / d7ebf1d inbox_SUITE:one_to_one:check_total_unread_count_and_active_conv_count{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"mike_check_total_unread_count_and_active_conv_count_28.601381@domain.example.com/res1">>,
escalus_tcp,<0.16366.0>,
[{event_manager,<0.16279.0>},
{server,<<"domain.example.com">>},
{username,
<<"mike_check_total_unread_count_and_active_conv_count_28.601381">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.16279.0>},
{server,<<"domain.example.com">>},
{username,
<<"mike_check_total_unread_count_and_active_conv_count_28.601381">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"mike_check_total_unread_count_and_active_conv_count_28.601381">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"mike_check_total_unread_count_and_active_conv_count_28.601381">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"nicniema">>},
{stream_id,<<"450d76bb256b535a">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,send_msg,3,
[... pgsql_mnesia_24 / pgsql_mnesia / d7ebf1d mysql_redis_24 / mysql_redis / d7ebf1d mam_SUITE:rdbms_async_cache_prefs_cases:messages_filtered_when_prefs_default_policy_is_never{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}} pgsql_mnesia_23 / pgsql_mnesia / d7ebf1d mssql_mnesia_24 / odbc_mssql_mnesia / d7ebf1d riak_mnesia_24 / riak_mnesia / d7ebf1d dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / d7ebf1d |
@@ -256,9 +256,9 @@ stanza_aff_set(Room, AffUsers) -> | |||
|| {UserBin, AffBin} <- bin_aff_users(AffUsers)], | |||
escalus_stanza:to(escalus_stanza:iq_set(?NS_MUC_LIGHT_AFFILIATIONS, Items), room_bin_jid(Room)). | |||
|
|||
clear_db() -> | |||
clear_db(HostType) -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note, this could run over all host types and keep the function specification the same - but if this works like it is with HostType
, maybe it's better to have it run for one only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing here is that it needs a host_type in order for mongoose_backend
to know what backend to give. The test callback is a testing hack and I didn't really find any solution that wouldn't be a hack, so any suggestions are welcome 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but it could just call domain_helper:host_type()
down here, or even domain_helper:host_types()
if it makes sense to run for all HTs (not sure if it does). Because the HT value is put here from the helper anyway by all the calls to this function, right? But this is not an issue, the way it is now may be more flexible for the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... I had no idea there was a host_types()
in plural! 😃 That would solve what this code wanted to do, but I still find it a bit of a code smell, why would you want to clear the DB with fire, sounds like being lazy to reason about the data a test has generated that would be required cleaned next time 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove mod_muc_light_codec_backend
from https://github.com/esl/MongooseIM/blob/without-dynamic-backend-modules/rebar.config#L29.
small_tests_24 / small_tests / 36e607a internal_mnesia_24 / internal_mnesia / 36e607a small_tests_23 / small_tests / 36e607a ldap_mnesia_24 / ldap_mnesia / 36e607a dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 36e607a rest_client_SUITE:muc:messages_can_be_paginated_in_room{error,
{{assertion_failed,assert,is_chat_message,
[<<"bed1172f">>],
{xmlel,<<"message">>,
[{<<"to">>,<<"[email protected]">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"body">>,[],[{xmlcdata,<<"acf486aa">>}]}]},
"<message to='[email protected]' type='chat'><body>acf486aa</body></message>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{rest_client_SUITE,assert_room_messages,2,
[{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
{line,772}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} dynamic_domains_mysql_redis_24 / mysql_redis / 36e607a mam_SUITE:rdbms_prefs_cases:prefs_set_request{error,{test_case_failed,"ASSERT EQUAL\n\tExpected {prefs_result_iq,<<\"roster\">>,\n [<<\"[email protected]\">>],\n [<<\"[email protected]\">>]}\n\tValue {prefs_result_iq,<<\"always\">>,\n [<<\"[email protected]\">>],\n [<<\"[email protected]\">>]}\n"}} dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 36e607a ldap_mnesia_23 / ldap_mnesia / 36e607a pgsql_mnesia_24 / pgsql_mnesia / 36e607a mongooseimctl_SUITE:stats:stats_global{error,{{badmatch,{"5\n",0}},
[{mongooseimctl_SUITE,'-stats_global/1-fun-0-',3,
[{file,"/home/circleci/app/big_tests/tests/mongooseimctl_SUITE.erl"},
{line,1056}]},
{escalus_story,story,4,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 36e607a elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 36e607a mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted{error,
{{assertMatch,
[{module,mod_event_pusher_rabbit_SUITE},
{line,435},
{expression,
"get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
{pattern,
"# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
{value,
#{<<"from_user_id">> =>
<<"[email protected]/bOb_unnamed_96.878890">>,
<<"message">> => <<"Hi there!">>,
<<"to_user_id">> =>
<<"alice_unnamed_97.77927@localhost/res1">>}}]},
[{mod_event_pusher_rabbit_SUITE,
'-group_chat_message_received_event_properly_formatted/1-fun-1-',3,
[{file,
"/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
{line,435}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} mysql_redis_24 / mysql_redis / 36e607a mssql_mnesia_24 / odbc_mssql_mnesia / 36e607a pgsql_mnesia_23 / pgsql_mnesia / 36e607a riak_mnesia_24 / riak_mnesia / 36e607a pgsql_mnesia_24 / pgsql_mnesia / 36e607a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine 👍
small_tests_24 / small_tests / bb7f726 internal_mnesia_24 / internal_mnesia / bb7f726 small_tests_23 / small_tests / bb7f726 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / bb7f726 mod_ping_SUITE:server_ping_kill:server_ping_pong{error,{{badmatch,[{[<<"test_type">>,mod_ping,ping_response],
{expected_diff,5},
{before_story,5},
{after_story,9}}]},
[{escalus_mongooseim,post_story_check_metrics,1,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
{line,74}]},
{escalus_mongooseim,maybe_check_metrics_post_story,1,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
{line,51}]},
{escalus_story,story,4,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,75}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} dynamic_domains_mysql_redis_24 / mysql_redis / bb7f726 service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join{error,{test_case_failed,{[<<"example1.com">>,<<"example2.com">>,
<<"example3.com">>],
[<<"example1.com">>,<<"example2.com">>,
<<"example3.com">>,<<"example4.com">>]}}} ldap_mnesia_24 / ldap_mnesia / bb7f726 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / bb7f726 inbox_SUITE:one_to_one:reset_unread_counter_and_show_only_unread{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"mike_reset_unread_counter_and_show_only_unread_52.43372@domain.example.com/res1">>,
escalus_tcp,<0.16383.0>,
[{event_manager,<0.16318.0>},
{server,<<"domain.example.com">>},
{username,
<<"mike_reset_unread_counter_and_show_only_unread_52.43372">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.16318.0>},
{server,<<"domain.example.com">>},
{username,
<<"mike_reset_unread_counter_and_show_only_unread_52.43372">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"mike_reset_unread_counter_and_show_only_unread_52.43372">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"mike_reset_unread_counter_and_show_only_unread_52.43372">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"nicniema">>},
{stream_id,<<"31bd082581ebb501">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,send_msg,3,
[{file,"/home/circleci/app/big_... inbox_SUITE:muclight:leave_and_remove_conversation{error,{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"alicE_leave_and_remove_conversation_58.96962">>,
<<"domain.example.com">>,<<"matygrysa">>],
3000,ejabberd],
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{escalus_ejabberd,create_users,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{escalus_fresh,story,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,27}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} inbox_SUITE:muclight:advanced_groupchat_stored_in_all_inbox{error,{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"alicE_advanced_groupchat_stored_in_all_inbox_58.98685">>,
<<"domain.example.com">>,<<"matygrysa">>],
3000,ejabberd],
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{escalus_ejabberd,create_users,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{escalus_fresh,story,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,27}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} inbox_SUITE:muclight:groupchat_markers_all_reset_room_created{error,{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"alicE_groupchat_markers_all_reset_room_created_58.103655">>,
<<"domain.example.com">>,<<"matygrysa">>],
3000,ejabberd],
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{escalus_ejabberd,create_users,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{escalus_fresh,story,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,27}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} inbox_SUITE:muclight:non_reset_marker_should_not_affect_muclight_inbox{error,{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"alicE_non_reset_marker_should_not_affect_muclight_inbox_58.104333">>,
<<"domain.example.com">>,<<"matygrysa">>],
3000,ejabberd],
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{escalus_ejabberd,create_users,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{escalus_fresh,story,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,27}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} inbox_SUITE:muclight:groupchat_markers_one_reset_room_created{error,{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"alicE_groupchat_markers_one_reset_room_created_58.101001">>,
<<"domain.example.com">>,<<"matygrysa">>],
3000,ejabberd],
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{escalus_ejabberd,create_users,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{escalus_fresh,story,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,27}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} inbox_SUITE:muclight:simple_groupchat_stored_in_all_inbox{error,{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"bOb_simple_groupchat_stored_in_all_inbox_58.94617">>,
<<"domain.example.com">>,<<"makrolika">>],
3000,ejabberd],
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{escalus_ejabberd,create_users,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{escalus_fresh,story,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,27}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / bb7f726 ldap_mnesia_23 / ldap_mnesia / bb7f726 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / bb7f726 mssql_mnesia_24 / odbc_mssql_mnesia / bb7f726 inbox_SUITE:muclight:groupchat_markers_one_reset{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alicE_groupchat_markers_one_reset_72.977888@localhost/res1">>,
escalus_tcp,<0.17424.0>,
[{event_manager,<0.17402.0>},
{server,<<"localhost">>},
{username,
<<"alicE_groupchat_markers_one_reset_72.977888">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.17402.0>},
{server,<<"localhost">>},
{username,
<<"alicE_groupchat_markers_one_reset_72.977888">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alicE_groupchat_markers_one_reset_72.977888">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_groupchat_markers_one_reset_72.977888">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"496f1330af95f00c">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,mark_last_muclight_system_message,3,
[{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
{line,579}]},
{inbox_helper,'-create_room/3-lc$^1/1-1-',2,
[{f... pgsql_mnesia_24 / pgsql_mnesia / bb7f726 mysql_redis_24 / mysql_redis / bb7f726 amp_big_SUITE:offline:offline_failure:notify_deliver_to_stranger_test{error,
{{assertion_failed,assert,is_presence,
{xmlel,<<"stream:error">>,[],
[{xmlel,<<"conflict">>,
[{<<"xmlns">>,<<"urn:ietf:params:xml:ns:xmpp-streams">>}],
[]},
{xmlel,<<"text">>,
[{<<"xml:lang">>,<<"en">>},
{<<"xmlns">>,<<"urn:ietf:params:xml:ns:xmpp-streams">>}],
[{xmlcdata,<<"Replaced by new connection">>}]}]},
"<stream:error><conflict xmlns='urn:ietf:params:xml:ns:xmpp-streams'/><text xml:lang='en' xmlns='urn:ietf:params:xml:ns:xmpp-streams'>Replaced by new connection</text></stream:error>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_story,'-drop_presences/2-lc$^0/1-0-',1,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,190}]},
{escalus_story,drop_presences,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,190}]},
{escalus_story,'-start_ready_clients/2-fun-0-',3,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,135}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_story,start_ready_clients,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,128}]},
... pgsql_mnesia_23 / pgsql_mnesia / bb7f726 riak_mnesia_24 / riak_mnesia / bb7f726 rest_client_SUITE:muc:messages_can_be_paginated_in_room{error,
{{assertion_failed,assert,is_chat_message,
[<<"a10a0141">>],
{xmlel,<<"message">>,
[{<<"to">>,<<"[email protected]">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"body">>,[],[{xmlcdata,<<"731efd79">>}]}]},
"<message to='[email protected]' type='chat'><body>731efd79</body></message>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{rest_client_SUITE,assert_room_messages,2,
[{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
{line,772}]},
{rest_client_SUITE,'-messages_can_be_paginated_in_room/1-fun-0-',3,
[{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
{line,538}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} dynamic_domains_mysql_redis_24 / mysql_redis / bb7f726 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / bb7f726 mysql_redis_24 / mysql_redis / bb7f726 mssql_mnesia_24 / odbc_mssql_mnesia / bb7f726 |
This one is going to be huge, as there were many places were muclight was calculating the host_type again and again, and here instead I pass it down the callstack.