Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate mod_muc_light_db to mongoose_backend #3351

Merged
merged 5 commits into from
Oct 21, 2021

Conversation

NelsonVides
Copy link
Collaborator

This one is going to be huge, as there were many places were muclight was calculating the host_type again and again, and here instead I pass it down the callstack.

@mongoose-im

This comment has been minimized.

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #3351 (bb7f726) into without-dynamic-backend-modules (bf3ef60) will increase coverage by 0.01%.
The diff coverage is 96.03%.

Impacted file tree graph

@@                         Coverage Diff                         @@
##           without-dynamic-backend-modules    #3351      +/-   ##
===================================================================
+ Coverage                            80.75%   80.76%   +0.01%     
===================================================================
  Files                                  404      405       +1     
  Lines                                32550    32598      +48     
===================================================================
+ Hits                                 26286    26329      +43     
- Misses                                6264     6269       +5     
Impacted Files Coverage Δ
src/muc_light/mod_muc_light_codec_backend.erl 84.61% <84.61%> (ø)
src/muc_light/mod_muc_light.erl 85.19% <96.55%> (+0.27%) ⬆️
.../mongoose_client_api/mongoose_client_api_rooms.erl 90.14% <100.00%> (+0.43%) ⬆️
src/muc_light/mod_muc_light_codec_legacy.erl 91.37% <100.00%> (ø)
src/muc_light/mod_muc_light_codec_modern.erl 90.05% <100.00%> (ø)
src/muc_light/mod_muc_light_commands.erl 91.76% <100.00%> (+0.19%) ⬆️
src/muc_light/mod_muc_light_db_backend.erl 100.00% <100.00%> (ø)
src/muc_light/mod_muc_light_db_mnesia.erl 89.47% <100.00%> (+0.93%) ⬆️
src/muc_light/mod_muc_light_db_rdbms.erl 92.11% <100.00%> (-0.08%) ⬇️
src/muc_light/mod_muc_light_room.erl 93.82% <100.00%> (+0.40%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eae95e...bb7f726. Read the comment docs.

Note also the many dialyzer error that were hiding behind a dynamic
callstack. They were all wrong specs and not wrong code, but still,
nice not to hide them any longer.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 21, 2021

small_tests_24 / small_tests / d7ebf1d
Reports root / small


internal_mnesia_24 / internal_mnesia / d7ebf1d
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0


small_tests_23 / small_tests / d7ebf1d
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d7ebf1d
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / d7ebf1d
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / d7ebf1d
Reports root/ big
OK: 2697 / Failed: 2 / User-skipped: 201 / Auto-skipped: 0

mam_SUITE:rdbms_async_pool_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}

Report log

mam_SUITE:rdbms_async_cache_prefs_cases:messages_filtered_when_prefs_default_policy_is_never
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}

Report log


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / d7ebf1d
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / d7ebf1d
Reports root/ big
OK: 1492 / Failed: 1 / User-skipped: 400 / Auto-skipped: 0

mod_ping_SUITE:server_ping_kill:server_ping_pong
{error,{{badmatch,[{[<<"localhost">>,mod_ping,ping_response],
          {expected_diff,5},
          {before_story,5},
          {after_story,9}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1784}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1293}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1225}]}]}}

Report log


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / d7ebf1d
Reports root/ big
OK: 2701 / Failed: 1 / User-skipped: 184 / Auto-skipped: 0

inbox_SUITE:one_to_one:check_total_unread_count_and_active_conv_count
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"mike_check_total_unread_count_and_active_conv_count_28.601381@domain.example.com/res1">>,
          escalus_tcp,<0.16366.0>,
          [{event_manager,<0.16279.0>},
           {server,<<"domain.example.com">>},
           {username,
             <<"mike_check_total_unread_count_and_active_conv_count_28.601381">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.16279.0>},
            {server,<<"domain.example.com">>},
            {username,
              <<"mike_check_total_unread_count_and_active_conv_count_28.601381">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"mike_check_total_unread_count_and_active_conv_count_28.601381">>},
           {server,<<"domain.example.com">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"mike_check_total_unread_count_and_active_conv_count_28.601381">>},
           {server,<<"domain.example.com">>},
           {host,<<"localhost">>},
           {password,<<"nicniema">>},
           {stream_id,<<"450d76bb256b535a">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,send_msg,3,
       [...

Report log


pgsql_mnesia_24 / pgsql_mnesia / d7ebf1d
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / d7ebf1d
Reports root/ big
OK: 3060 / Failed: 1 / User-skipped: 228 / Auto-skipped: 0

mam_SUITE:rdbms_async_cache_prefs_cases:messages_filtered_when_prefs_default_policy_is_never
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}

Report log


pgsql_mnesia_23 / pgsql_mnesia / d7ebf1d
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / d7ebf1d
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / d7ebf1d
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / d7ebf1d
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

@NelsonVides NelsonVides marked this pull request as ready for review October 21, 2021 13:51
@@ -256,9 +256,9 @@ stanza_aff_set(Room, AffUsers) ->
|| {UserBin, AffBin} <- bin_aff_users(AffUsers)],
escalus_stanza:to(escalus_stanza:iq_set(?NS_MUC_LIGHT_AFFILIATIONS, Items), room_bin_jid(Room)).

clear_db() ->
clear_db(HostType) ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, this could run over all host types and keep the function specification the same - but if this works like it is with HostType, maybe it's better to have it run for one only.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing here is that it needs a host_type in order for mongoose_backend to know what backend to give. The test callback is a testing hack and I didn't really find any solution that wouldn't be a hack, so any suggestions are welcome 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but it could just call domain_helper:host_type() down here, or even domain_helper:host_types() if it makes sense to run for all HTs (not sure if it does). Because the HT value is put here from the helper anyway by all the calls to this function, right? But this is not an issue, the way it is now may be more flexible for the future.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... I had no idea there was a host_types() in plural! 😃 That would solve what this code wanted to do, but I still find it a bit of a code smell, why would you want to clear the DB with fire, sounds like being lazy to reason about the data a test has generated that would be required cleaned next time 😕

Copy link
Contributor

@vkatsuba vkatsuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 21, 2021

small_tests_24 / small_tests / 36e607a
Reports root / small


internal_mnesia_24 / internal_mnesia / 36e607a
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0


small_tests_23 / small_tests / 36e607a
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 36e607a
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 36e607a
Reports root/ big
OK: 2727 / Failed: 1 / User-skipped: 184 / Auto-skipped: 0

rest_client_SUITE:muc:messages_can_be_paginated_in_room
{error,
  {{assertion_failed,assert,is_chat_message,
     [<<"bed1172f">>],
     {xmlel,<<"message">>,
       [{<<"to">>,<<"[email protected]">>},
        {<<"type">>,<<"chat">>}],
       [{xmlel,<<"body">>,[],[{xmlcdata,<<"acf486aa">>}]}]},
     "<message to='[email protected]' type='chat'><body>acf486aa</body></message>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {rest_client_SUITE,assert_room_messages,2,
      [{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
       {line,772}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


dynamic_domains_mysql_redis_24 / mysql_redis / 36e607a
Reports root/ big
OK: 2691 / Failed: 1 / User-skipped: 201 / Auto-skipped: 0

mam_SUITE:rdbms_prefs_cases:prefs_set_request
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected {prefs_result_iq,<<\"roster\">>,\n                  [<<\"[email protected]\">>],\n                  [<<\"[email protected]\">>]}\n\tValue {prefs_result_iq,<<\"always\">>,\n                 [<<\"[email protected]\">>],\n                 [<<\"[email protected]\">>]}\n"}}

Report log


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 36e607a
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 36e607a
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 36e607a
Reports root/ big
OK: 3069 / Failed: 1 / User-skipped: 211 / Auto-skipped: 1

mongooseimctl_SUITE:stats:stats_global
{error,{{badmatch,{"5\n",0}},
    [{mongooseimctl_SUITE,'-stats_global/1-fun-0-',3,
                [{file,"/home/circleci/app/big_tests/tests/mongooseimctl_SUITE.erl"},
                 {line,1056}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 36e607a
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 36e607a
Reports root/ big
OK: 1865 / Failed: 1 / User-skipped: 323 / Auto-skipped: 0

mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted
{error,
  {{assertMatch,
     [{module,mod_event_pusher_rabbit_SUITE},
      {line,435},
      {expression,
        "get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
      {pattern,
        "# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
      {value,
        #{<<"from_user_id">> =>
          <<"[email protected]/bOb_unnamed_96.878890">>,
        <<"message">> => <<"Hi there!">>,
        <<"to_user_id">> =>
          <<"alice_unnamed_97.77927@localhost/res1">>}}]},
   [{mod_event_pusher_rabbit_SUITE,
      '-group_chat_message_received_event_properly_formatted/1-fun-1-',3,
      [{file,
         "/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
       {line,435}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


mysql_redis_24 / mysql_redis / 36e607a
Reports root/ big
OK: 3054 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 36e607a
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 36e607a
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 36e607a
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 36e607a
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

Copy link
Contributor

@gustawlippa gustawlippa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 👍

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 21, 2021

small_tests_24 / small_tests / bb7f726
Reports root / small


internal_mnesia_24 / internal_mnesia / bb7f726
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0


small_tests_23 / small_tests / bb7f726
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / bb7f726
Reports root/ big
OK: 2708 / Failed: 1 / User-skipped: 184 / Auto-skipped: 0

mod_ping_SUITE:server_ping_kill:server_ping_pong
{error,{{badmatch,[{[<<"test_type">>,mod_ping,ping_response],
          {expected_diff,5},
          {before_story,5},
          {after_story,9}}]},
    [{escalus_mongooseim,post_story_check_metrics,1,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,74}]},
     {escalus_mongooseim,maybe_check_metrics_post_story,1,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
                {line,51}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,75}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log


dynamic_domains_mysql_redis_24 / mysql_redis / bb7f726
Reports root/ big
OK: 2684 / Failed: 1 / User-skipped: 201 / Auto-skipped: 0

service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join
{error,{test_case_failed,{[<<"example1.com">>,<<"example2.com">>,
               <<"example3.com">>],
              [<<"example1.com">>,<<"example2.com">>,
               <<"example3.com">>,<<"example4.com">>]}}}

Report log


ldap_mnesia_24 / ldap_mnesia / bb7f726
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / bb7f726
Reports root/ big
OK: 2695 / Failed: 7 / User-skipped: 184 / Auto-skipped: 0

inbox_SUITE:one_to_one:reset_unread_counter_and_show_only_unread
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"mike_reset_unread_counter_and_show_only_unread_52.43372@domain.example.com/res1">>,
          escalus_tcp,<0.16383.0>,
          [{event_manager,<0.16318.0>},
           {server,<<"domain.example.com">>},
           {username,
             <<"mike_reset_unread_counter_and_show_only_unread_52.43372">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.16318.0>},
            {server,<<"domain.example.com">>},
            {username,
              <<"mike_reset_unread_counter_and_show_only_unread_52.43372">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"mike_reset_unread_counter_and_show_only_unread_52.43372">>},
           {server,<<"domain.example.com">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"mike_reset_unread_counter_and_show_only_unread_52.43372">>},
           {server,<<"domain.example.com">>},
           {host,<<"localhost">>},
           {password,<<"nicniema">>},
           {stream_id,<<"31bd082581ebb501">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,send_msg,3,
       [{file,"/home/circleci/app/big_...

Report log

inbox_SUITE:muclight:leave_and_remove_conversation
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"alicE_leave_and_remove_conversation_58.96962">>,
            <<"domain.example.com">>,<<"matygrysa">>],
             3000,ejabberd],
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {escalus_fresh,story,3,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,27}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

inbox_SUITE:muclight:advanced_groupchat_stored_in_all_inbox
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"alicE_advanced_groupchat_stored_in_all_inbox_58.98685">>,
            <<"domain.example.com">>,<<"matygrysa">>],
             3000,ejabberd],
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {escalus_fresh,story,3,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,27}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

inbox_SUITE:muclight:groupchat_markers_all_reset_room_created
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"alicE_groupchat_markers_all_reset_room_created_58.103655">>,
            <<"domain.example.com">>,<<"matygrysa">>],
             3000,ejabberd],
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {escalus_fresh,story,3,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,27}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

inbox_SUITE:muclight:non_reset_marker_should_not_affect_muclight_inbox
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"alicE_non_reset_marker_should_not_affect_muclight_inbox_58.104333">>,
            <<"domain.example.com">>,<<"matygrysa">>],
             3000,ejabberd],
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {escalus_fresh,story,3,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,27}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

inbox_SUITE:muclight:groupchat_markers_one_reset_room_created
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"alicE_groupchat_markers_one_reset_room_created_58.101001">>,
            <<"domain.example.com">>,<<"matygrysa">>],
             3000,ejabberd],
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {escalus_fresh,story,3,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,27}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

inbox_SUITE:muclight:simple_groupchat_stored_in_all_inbox
{error,{{badrpc,timeout},
    [{escalus_rpc,call_with_cookie_match,
            [mongooseim@localhost,ejabberd_admin,register,
             [<<"bOb_simple_groupchat_stored_in_all_inbox_58.94617">>,
            <<"domain.example.com">>,<<"makrolika">>],
             3000,ejabberd],
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
             {line,34}]},
     {lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
     {escalus_ejabberd,create_users,2,
               [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
              {line,211}]},
     {escalus_fresh,create_users,2,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,62}]},
     {escalus_fresh,story,3,
            [{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
             {line,27}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / bb7f726
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / bb7f726
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / bb7f726
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / bb7f726
Reports root/ big
OK: 3070 / Failed: 1 / User-skipped: 211 / Auto-skipped: 0

inbox_SUITE:muclight:groupchat_markers_one_reset
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alicE_groupchat_markers_one_reset_72.977888@localhost/res1">>,
          escalus_tcp,<0.17424.0>,
          [{event_manager,<0.17402.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_groupchat_markers_one_reset_72.977888">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17402.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_groupchat_markers_one_reset_72.977888">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alicE_groupchat_markers_one_reset_72.977888">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_groupchat_markers_one_reset_72.977888">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"496f1330af95f00c">>}]},
        5000],
       [{file,
          "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {inbox_helper,mark_last_muclight_system_message,3,
       [{file,"/home/circleci/app/big_tests/tests/inbox_helper.erl"},
        {line,579}]},
     {inbox_helper,'-create_room/3-lc$^1/1-1-',2,
       [{f...

Report log


pgsql_mnesia_24 / pgsql_mnesia / bb7f726
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / bb7f726
Reports root/ big
OK: 3053 / Failed: 1 / User-skipped: 228 / Auto-skipped: 0

amp_big_SUITE:offline:offline_failure:notify_deliver_to_stranger_test
{error,
  {{assertion_failed,assert,is_presence,
     {xmlel,<<"stream:error">>,[],
       [{xmlel,<<"conflict">>,
          [{<<"xmlns">>,<<"urn:ietf:params:xml:ns:xmpp-streams">>}],
          []},
        {xmlel,<<"text">>,
          [{<<"xml:lang">>,<<"en">>},
           {<<"xmlns">>,<<"urn:ietf:params:xml:ns:xmpp-streams">>}],
          [{xmlcdata,<<"Replaced by new connection">>}]}]},
     "<stream:error><conflict xmlns='urn:ietf:params:xml:ns:xmpp-streams'/><text xml:lang='en' xmlns='urn:ietf:params:xml:ns:xmpp-streams'>Replaced by new connection</text></stream:error>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {escalus_story,'-drop_presences/2-lc$^0/1-0-',1,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,190}]},
    {escalus_story,drop_presences,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,190}]},
    {escalus_story,'-start_ready_clients/2-fun-0-',3,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,135}]},
    {lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
    {escalus_story,start_ready_clients,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,128}]},
   ...

Report log


pgsql_mnesia_23 / pgsql_mnesia / bb7f726
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / bb7f726
Reports root/ big
OK: 1734 / Failed: 1 / User-skipped: 326 / Auto-skipped: 0

rest_client_SUITE:muc:messages_can_be_paginated_in_room
{error,
  {{assertion_failed,assert,is_chat_message,
     [<<"a10a0141">>],
     {xmlel,<<"message">>,
       [{<<"to">>,<<"[email protected]">>},
        {<<"type">>,<<"chat">>}],
       [{xmlel,<<"body">>,[],[{xmlcdata,<<"731efd79">>}]}]},
     "<message to='[email protected]' type='chat'><body>731efd79</body></message>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {rest_client_SUITE,assert_room_messages,2,
      [{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
       {line,772}]},
    {rest_client_SUITE,'-messages_can_be_paginated_in_room/1-fun-0-',3,
      [{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
       {line,538}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


dynamic_domains_mysql_redis_24 / mysql_redis / bb7f726
Reports root/ big
OK: 2685 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / bb7f726
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / bb7f726
Reports root/ big
OK: 3054 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / bb7f726
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

@vkatsuba vkatsuba merged commit 37fd6cc into without-dynamic-backend-modules Oct 21, 2021
@vkatsuba vkatsuba deleted the wdbm/muclight branch October 21, 2021 19:21
@Premwoik Premwoik modified the milestone: 5.1.0 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants