Wdbm/vcard #3358

NelsonVides · 2021-10-25T07:13:29Z

Also removed unused hook about config change.

codecov · 2021-10-25T07:24:54Z

Codecov Report

Merging #3358 (09b14aa) into without-dynamic-backend-modules (bb7f726) will increase coverage by 0.04%.
The diff coverage is 96.00%.

@@                         Coverage Diff                         @@
##           without-dynamic-backend-modules    #3358      +/-   ##
===================================================================
+ Coverage                            80.76%   80.81%   +0.04%     
===================================================================
  Files                                  405      406       +1     
  Lines                                32598    32608      +10     
===================================================================
+ Hits                                 26329    26353      +24     
+ Misses                                6269     6255      -14

Impacted Files	Coverage Δ
src/vcard/mod_vcard_ldap.erl	`91.55% <ø> (ø)`
src/vcard/mod_vcard_mnesia.erl	`80.45% <ø> (ø)`
src/vcard/mod_vcard_rdbms.erl	`75.79% <ø> (ø)`
src/vcard/mod_vcard_riak.erl	`88.70% <ø> (ø)`
src/vcard/mod_vcard_backend.erl	`95.65% <95.65%> (ø)`
src/vcard/mod_vcard.erl	`80.22% <100.00%> (ø)`
src/mod_last_rdbms.erl	`96.15% <0.00%> (-3.85%)`	⬇️
src/domain/mongoose_domain_loader.erl	`77.35% <0.00%> (-1.89%)`	⬇️
src/mod_last.erl	`86.56% <0.00%> (-1.50%)`	⬇️
src/mod_bosh_socket.erl	`77.63% <0.00%> (-1.25%)`	⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37fd6cc...09b14aa. Read the comment docs.

mongoose-im · 2021-10-25T08:13:31Z

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 33b5163
Reports root

small_tests_24 / small_tests / 33b5163
Reports root / small

internal_mnesia_24 / internal_mnesia / 33b5163
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0

small_tests_23 / small_tests / 33b5163
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 33b5163
Reports root/ big
OK: 2701 / Failed: 1 / User-skipped: 184 / Auto-skipped: 0

domain_removal_SUITE:vcard_removal:vcard_removal

{error,
  {{assertion_failed,assert,is_iq_error,
     {xmlel,<<"iq">>,
       [{<<"from">>,
         <<"[email protected]">>},
        {<<"to">>,
         <<"[email protected]/res1">>},
        {<<"id">>,<<"5d6212164b650c356ed15cfdd666791d">>},
        {<<"type">>,<<"result">>}],
       [{xmlel,<<"vCard">>,
          [{<<"xmlns">>,<<"vcard-temp">>}],
          [{xmlel,<<"FN">>,[],[{xmlcdata,<<"Old name">>}]}]}]},
     "<iq from='[email protected]' to='[email protected]/res1' id='5d6212164b650c356ed15cfdd666791d' type='result'><vCard xmlns='vcard-temp'><FN>Old name</FN></vCard></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {domain_removal_SUITE,'-vcard_removal/1-fun-7-',1,
      [{file,
         "/home/circleci/app/big_tests/tests/domain_removal_SUITE.erl"},
       {line,348}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

ldap_mnesia_24 / ldap_mnesia / 33b5163
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 33b5163
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 33b5163
Reports root/ big
OK: 2701 / Failed: 1 / User-skipped: 184 / Auto-skipped: 0

domain_removal_SUITE:vcard_removal:vcard_removal

{error,
  {{assertion_failed,assert,is_iq_error,
     {xmlel,<<"iq">>,
       [{<<"from">>,
         <<"[email protected]">>},
        {<<"to">>,
         <<"[email protected]/res1">>},
        {<<"id">>,<<"94e015051b6ab0bbe29c1d87ebf64df3">>},
        {<<"type">>,<<"result">>}],
       [{xmlel,<<"vCard">>,
          [{<<"xmlns">>,<<"vcard-temp">>}],
          [{xmlel,<<"FN">>,[],[{xmlcdata,<<"Old name">>}]}]}]},
     "<iq from='[email protected]' to='[email protected]/res1' id='94e015051b6ab0bbe29c1d87ebf64df3' type='result'><vCard xmlns='vcard-temp'><FN>Old name</FN></vCard></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {domain_removal_SUITE,'-vcard_removal/1-fun-7-',1,
      [{file,
         "/home/circleci/app/big_tests/tests/domain_removal_SUITE.erl"},
       {line,348}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

dynamic_domains_mysql_redis_24 / mysql_redis / 33b5163
Reports root/ big
OK: 2684 / Failed: 1 / User-skipped: 201 / Auto-skipped: 0

domain_removal_SUITE:vcard_removal:vcard_removal

{error,
  {{assertion_failed,assert,is_iq_error,
     {xmlel,<<"iq">>,
       [{<<"from">>,
         <<"[email protected]">>},
        {<<"to">>,
         <<"[email protected]/res1">>},
        {<<"id">>,<<"088d3e9db8d2d0d612d2fada44bc8f53">>},
        {<<"type">>,<<"result">>}],
       [{xmlel,<<"vCard">>,
          [{<<"xmlns">>,<<"vcard-temp">>}],
          [{xmlel,<<"FN">>,[],[{xmlcdata,<<"Old name">>}]}]}]},
     "<iq from='[email protected]' to='[email protected]/res1' id='088d3e9db8d2d0d612d2fada44bc8f53' type='result'><vCard xmlns='vcard-temp'><FN>Old name</FN></vCard></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {domain_removal_SUITE,'-vcard_removal/1-fun-7-',1,
      [{file,
         "/home/circleci/app/big_tests/tests/domain_removal_SUITE.erl"},
       {line,348}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

pgsql_mnesia_24 / pgsql_mnesia / 33b5163
Reports root/ big
OK: 3070 / Failed: 1 / User-skipped: 211 / Auto-skipped: 0

domain_removal_SUITE:vcard_removal:vcard_removal

{error,
  {{assertion_failed,assert,is_iq_error,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"alicE_vcard_removal_9.499367@localhost">>},
        {<<"to">>,<<"alicE_vcard_removal_9.499367@localhost/res1">>},
        {<<"id">>,<<"0b872c4f17650d0f069858ee801e0d2c">>},
        {<<"type">>,<<"result">>}],
       [{xmlel,<<"vCard">>,
          [{<<"xmlns">>,<<"vcard-temp">>}],
          [{xmlel,<<"FN">>,[],[{xmlcdata,<<"Old name">>}]}]}]},
     "<iq from='alicE_vcard_removal_9.499367@localhost' to='alicE_vcard_removal_9.499367@localhost/res1' id='0b872c4f17650d0f069858ee801e0d2c' type='result'><vCard xmlns='vcard-temp'><FN>Old name</FN></vCard></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {domain_removal_SUITE,'-vcard_removal/1-fun-7-',1,
      [{file,
         "/home/circleci/app/big_tests/tests/domain_removal_SUITE.erl"},
       {line,348}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

pgsql_mnesia_23 / pgsql_mnesia / 33b5163
Reports root/ big
OK: 3070 / Failed: 1 / User-skipped: 211 / Auto-skipped: 0

domain_removal_SUITE:vcard_removal:vcard_removal

{error,
  {{assertion_failed,assert,is_iq_error,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"alicE_vcard_removal_40.382230@localhost">>},
        {<<"to">>,<<"alicE_vcard_removal_40.382230@localhost/res1">>},
        {<<"id">>,<<"1a89cf63744b6bb9e60fd7b4d30afd58">>},
        {<<"type">>,<<"result">>}],
       [{xmlel,<<"vCard">>,
          [{<<"xmlns">>,<<"vcard-temp">>}],
          [{xmlel,<<"FN">>,[],[{xmlcdata,<<"Old name">>}]}]}]},
     "<iq from='alicE_vcard_removal_40.382230@localhost' to='alicE_vcard_removal_40.382230@localhost/res1' id='1a89cf63744b6bb9e60fd7b4d30afd58' type='result'><vCard xmlns='vcard-temp'><FN>Old name</FN></vCard></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {domain_removal_SUITE,'-vcard_removal/1-fun-7-',1,
      [{file,
         "/home/circleci/app/big_tests/tests/domain_removal_SUITE.erl"},
       {line,348}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1784}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1293}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1225}]}]}}

Report log

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 33b5163
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 33b5163
Reports root/ big
OK: 3059 / Failed: 2 / User-skipped: 228 / Auto-skipped: 0

mam_SUITE:rdbms_async_cache_prefs_cases:messages_filtered_when_prefs_default_policy_is_never

{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}

Report log

domain_removal_SUITE:vcard_removal:vcard_removal

{error,
  {{assertion_failed,assert,is_iq_error,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"alicE_vcard_removal_50.480563@localhost">>},
        {<<"to">>,<<"alicE_vcard_removal_50.480563@localhost/res1">>},
        {<<"id">>,<<"c3b6e5827b406422847d941eb6c49a75">>},
        {<<"type">>,<<"result">>}],
       [{xmlel,<<"vCard">>,
          [{<<"xmlns">>,<<"vcard-temp">>}],
          [{xmlel,<<"FN">>,[],[{xmlcdata,<<"Old name">>}]}]}]},
     "<iq from='alicE_vcard_removal_50.480563@localhost' to='alicE_vcard_removal_50.480563@localhost/res1' id='c3b6e5827b406422847d941eb6c49a75' type='result'><vCard xmlns='vcard-temp'><FN>Old name</FN></vCard></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {domain_removal_SUITE,'-vcard_removal/1-fun-7-',1,
      [{file,
         "/home/circleci/app/big_tests/tests/domain_removal_SUITE.erl"},
       {line,348}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

mssql_mnesia_24 / odbc_mssql_mnesia / 33b5163
Reports root/ big
OK: 3070 / Failed: 1 / User-skipped: 211 / Auto-skipped: 0

domain_removal_SUITE:vcard_removal:vcard_removal

{error,
  {{assertion_failed,assert,is_iq_error,
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"alicE_vcard_removal_88.141222@localhost">>},
        {<<"to">>,<<"alicE_vcard_removal_88.141222@localhost/res1">>},
        {<<"id">>,<<"8549ecdbad1f23a6d4fcdda6ee57a7e6">>},
        {<<"type">>,<<"result">>}],
       [{xmlel,<<"vCard">>,
          [{<<"xmlns">>,<<"vcard-temp">>}],
          [{xmlel,<<"FN">>,[],[{xmlcdata,<<"Old name">>}]}]}]},
     "<iq from='alicE_vcard_removal_88.141222@localhost' to='alicE_vcard_removal_88.141222@localhost/res1' id='8549ecdbad1f23a6d4fcdda6ee57a7e6' type='result'><vCard xmlns='vcard-temp'><FN>Old name</FN></vCard></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {domain_removal_SUITE,'-vcard_removal/1-fun-7-',1,
      [{file,
         "/home/circleci/app/big_tests/tests/domain_removal_SUITE.erl"},
       {line,348}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

riak_mnesia_24 / riak_mnesia / 33b5163
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0

mongoose-im · 2021-10-25T08:57:49Z

small_tests_24 / small_tests / 09b14aa
Reports root / small

internal_mnesia_24 / internal_mnesia / 09b14aa
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0

small_tests_23 / small_tests / 09b14aa
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 09b14aa
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / 09b14aa
Reports root/ big
OK: 2685 / Failed: 0 / User-skipped: 201 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 09b14aa
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 09b14aa
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 09b14aa
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 09b14aa
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 09b14aa
Reports root/ big
OK: 3095 / Failed: 2 / User-skipped: 211 / Auto-skipped: 0

rest_client_SUITE:muc:messages_can_be_paginated_in_room

{error,
  {{assertion_failed,assert,is_chat_message,
     [<<"8cbff012">>],
     {xmlel,<<"message">>,
       [{<<"to">>,<<"[email protected]">>},
        {<<"type">>,<<"chat">>}],
       [{xmlel,<<"body">>,[],[{xmlcdata,<<"e9938900">>}]}]},
     "<message to='[email protected]' type='chat'><body>e9938900</body></message>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {rest_client_SUITE,assert_room_messages,2,
      [{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
       {line,772}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join

{error,{test_case_failed,{[<<"example1.com">>,<<"example2.com">>,
               <<"example3.com">>],
              [<<"example1.com">>,<<"example2.com">>,
               <<"example3.com">>,<<"example4.com">>]}}}

Report log

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 09b14aa
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 09b14aa
Reports root/ big
OK: 3054 / Failed: 0 / User-skipped: 228 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / 09b14aa
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 09b14aa
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 09b14aa
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 09b14aa
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

Move into a directory

8df58a3

This comment has been minimized.

Sign in to view

Migrate mod_vcard to mongoose_backend

33b5163

NelsonVides force-pushed the wdbm/vcard branch from 17b789c to 33b5163 Compare October 25, 2021 08:02

NelsonVides added the ready label Oct 25, 2021

Fix wrong module name

09b14aa

vkatsuba approved these changes Oct 25, 2021

View reviewed changes

vkatsuba merged commit 8a7b507 into without-dynamic-backend-modules Oct 25, 2021

vkatsuba deleted the wdbm/vcard branch October 25, 2021 10:51

gustawlippa mentioned this pull request Oct 26, 2021

Mod roster remove dynamic modules #3364

Merged

Premwoik modified the milestone: 5.1.0 May 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wdbm/vcard #3358

Wdbm/vcard #3358

NelsonVides commented Oct 25, 2021

This comment has been minimized.

codecov bot commented Oct 25, 2021 •

edited

Loading

mongoose-im commented Oct 25, 2021 •

edited

Loading

mongoose-im commented Oct 25, 2021 •

edited

Loading

Wdbm/vcard #3358

Wdbm/vcard #3358

Conversation

NelsonVides commented Oct 25, 2021

This comment has been minimized.

codecov bot commented Oct 25, 2021 • edited Loading

Codecov Report

mongoose-im commented Oct 25, 2021 • edited Loading

mongoose-im commented Oct 25, 2021 • edited Loading

codecov bot commented Oct 25, 2021 •

edited

Loading

mongoose-im commented Oct 25, 2021 •

edited

Loading

mongoose-im commented Oct 25, 2021 •

edited

Loading