Use dynamic_modules in big tests #3481

chrzaszcz · 2021-12-28T09:00:16Z

Do not use gen_mod directly to start and stop modules in tests.
Use the dynamic_modules API instead.

These changes make it possible to modify the module management logic without any changes in the test suites - only the dynamic_domains helper will be modified.

codecov · 2021-12-28T09:08:09Z

Codecov Report

Merging #3481 (8c490cd) into master (65c8565) will increase coverage by 1.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3481      +/-   ##
==========================================
+ Coverage   79.25%   80.86%   +1.61%     
==========================================
  Files         415      415              
  Lines       32326    32326              
==========================================
+ Hits        25619    26141     +522     
+ Misses       6707     6185     -522

Impacted Files	Coverage Δ
src/mod_roster_mnesia.erl	`72.72% <0.00%> (-21.22%)`	⬇️
src/rdbms/mongoose_rdbms.erl	`61.75% <0.00%> (-1.20%)`	⬇️
src/global_distrib/mod_global_distrib_receiver.erl	`80.00% <0.00%> (-1.12%)`	⬇️
src/mod_muc_log.erl	`78.11% <0.00%> (ø)`
src/mod_muc_room.erl	`77.26% <0.00%> (+0.17%)`	⬆️
src/mod_roster.erl	`78.75% <0.00%> (+0.23%)`	⬆️
src/pubsub/mod_pubsub_db_mnesia.erl	`92.85% <0.00%> (+0.42%)`	⬆️
src/domain/mongoose_domain_loader.erl	`90.17% <0.00%> (+0.89%)`	⬆️
src/mam/mod_mam_utils.erl	`86.49% <0.00%> (+0.96%)`	⬆️
src/logger/mongoose_log_filter.erl	`79.45% <0.00%> (+1.36%)`	⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65c8565...8c490cd. Read the comment docs.

mod_mam_rdbms_arch_async and mod_mam_rdbms_user had different initialization

Also: modernise RPC calls to allow setting timeout. Note: the timeout used in save_modules will be applied again in restore_modules.

This argument neither needed nor supported anymore.

Reason: simplicity and consistency. The other version wasn't called 'save_modules_for_host_type'.

mongoose-im · 2021-12-29T10:39:29Z

small_tests_24 / small_tests / 8c490cd
Reports root / small

small_tests_23 / small_tests / 8c490cd
Reports root / small

dynamic_domains_mysql_redis_24 / mysql_redis / 8c490cd
Reports root/ big
OK: 2667 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 8c490cd
Reports root/ big
OK: 2684 / Failed: 0 / User-skipped: 230 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 8c490cd
Reports root/ big
OK: 2684 / Failed: 0 / User-skipped: 230 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / 8c490cd
Reports root/ big
OK: 1501 / Failed: 0 / User-skipped: 388 / Auto-skipped: 0

internal_mnesia_24 / internal_mnesia / 8c490cd
Reports root/ big
OK: 1542 / Failed: 0 / User-skipped: 347 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 8c490cd
Reports root/ big
OK: 1501 / Failed: 0 / User-skipped: 388 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 8c490cd
Reports root/ big
OK: 1835 / Failed: 0 / User-skipped: 359 / Auto-skipped: 0

mssql_mnesia_24 / odbc_mssql_mnesia / 8c490cd
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 8c490cd
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / 8c490cd
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / 8c490cd
Reports root/ big
OK: 3066 / Failed: 0 / User-skipped: 244 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 8c490cd
Reports root/ big
OK: 1681 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0

This comment has been minimized.

Sign in to view

Base automatically changed from print-dots to master December 28, 2021 09:39

This comment has been minimized.

Sign in to view

mongoose-im mentioned this pull request Dec 28, 2021

CI build failures summary #3360

Closed

This comment has been minimized.

Sign in to view

chrzaszcz added 4 commits December 29, 2021 08:04

Initialize muc+pm modules for muc_light in a unified way

c4bbaed

mod_mam_rdbms_arch_async and mod_mam_rdbms_user had different initialization

Remove test repeat for MAM

d0a3503

Use dynamic_modules in mam_SUITE

b99c125

Use dynamic_modules to ensure modules in big tests

4607640

chrzaszcz force-pushed the use-dynamic-modules branch from f84c4b3 to 2c18e07 Compare December 29, 2021 07:05

This comment has been minimized.

Sign in to view

chrzaszcz force-pushed the use-dynamic-modules branch from 6b56bec to 6ddf958 Compare December 29, 2021 07:48

This comment has been minimized.

Sign in to view

chrzaszcz force-pushed the use-dynamic-modules branch from 6ddf958 to e6f4934 Compare December 29, 2021 08:50

This comment has been minimized.

Sign in to view

chrzaszcz force-pushed the use-dynamic-modules branch from 08d60ab to 41085f1 Compare December 29, 2021 09:21

This comment has been minimized.

Sign in to view

chrzaszcz added 5 commits December 29, 2021 11:30

Support nodes other than mim1 in dynamic_modules

b723e09

Also: modernise RPC calls to allow setting timeout. Note: the timeout used in save_modules will be applied again in restore_modules.

Update restore_modules - remove host_type

ddd3f65

This argument neither needed nor supported anymore.

Use dynamic_modules in mod_global_distrib_SUITE

c644370

Replace start/stop_running with save/ensure/restore

ab4e0ab

Rename 'save_modules_for_host_types' to 'save_modules'

8c490cd

Reason: simplicity and consistency. The other version wasn't called 'save_modules_for_host_type'.

chrzaszcz force-pushed the use-dynamic-modules branch from 41085f1 to 8c490cd Compare December 29, 2021 10:31

chrzaszcz marked this pull request as ready for review December 29, 2021 12:39

arcusfelis approved these changes Dec 29, 2021

View reviewed changes

arcusfelis merged commit a7af9d8 into master Dec 29, 2021

arcusfelis deleted the use-dynamic-modules branch December 29, 2021 13:23

Premwoik added this to the 5.1.0 milestone May 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use dynamic_modules in big tests #3481

Use dynamic_modules in big tests #3481

chrzaszcz commented Dec 28, 2021 •

edited

Loading

codecov bot commented Dec 28, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mongoose-im commented Dec 29, 2021 •

edited

Loading

Use dynamic_modules in big tests #3481

Use dynamic_modules in big tests #3481

Conversation

chrzaszcz commented Dec 28, 2021 • edited Loading

codecov bot commented Dec 28, 2021 • edited Loading

Codecov Report

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mongoose-im commented Dec 29, 2021 • edited Loading

chrzaszcz commented Dec 28, 2021 •

edited

Loading

codecov bot commented Dec 28, 2021 •

edited

Loading

mongoose-im commented Dec 29, 2021 •

edited

Loading