-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to customize auth module list per listener #3539
Conversation
small_tests_24 / small_tests / 826adac small_tests_23 / small_tests / 826adac dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 826adac dynamic_domains_mysql_redis_24 / mysql_redis / 826adac dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 826adac dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 826adac ldap_mnesia_23 / ldap_mnesia / 826adac ldap_mnesia_24 / ldap_mnesia / 826adac internal_mnesia_24 / internal_mnesia / 826adac pgsql_mnesia_24 / pgsql_mnesia / 826adac pgsql_mnesia_23 / pgsql_mnesia / 826adac elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 826adac push_SUITE:toggling:disable_all_nodes_removes_it_from_all_user_session_infos{error,{{badmatch,{{jid,<<"pub-sub">>,
<<"disable_all_nodes_removes_it_from_all_user_session_infos_99.475733">>,
<<>>,<<"pub-sub">>,
<<"disable_all_nodes_removes_it_from_all_user_session_infos_99.475733">>,
<<>>},
<<"princely_musings_JTq8bvX.2kQ=">>,[]}},
[{push_SUITE,'-disable_all_nodes_removes_it_from_all_user_session_infos/1-fun-0-',
3,
[{file,"/home/circleci/project/big_tests/tests/push_SUITE.erl"},
{line,417}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} mssql_mnesia_24 / odbc_mssql_mnesia / 826adac mysql_redis_24 / mysql_redis / 826adac riak_mnesia_24 / riak_mnesia / 826adac |
Codecov Report
@@ Coverage Diff @@
## master #3539 +/- ##
==========================================
- Coverage 81.07% 81.06% -0.01%
==========================================
Files 419 419
Lines 32298 32309 +11
==========================================
+ Hits 26184 26190 +6
- Misses 6114 6119 +5
Continue to review full report at Codecov.
|
small_tests_24 / small_tests / 45a488b small_tests_23 / small_tests / 45a488b dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 45a488b dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 45a488b dynamic_domains_mysql_redis_24 / mysql_redis / 45a488b dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 45a488b ldap_mnesia_24 / ldap_mnesia / 45a488b ldap_mnesia_23 / ldap_mnesia / 45a488b internal_mnesia_24 / internal_mnesia / 45a488b pgsql_mnesia_23 / pgsql_mnesia / 45a488b mysql_redis_24 / mysql_redis / 45a488b pgsql_mnesia_24 / pgsql_mnesia / 45a488b elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 45a488b mssql_mnesia_24 / odbc_mssql_mnesia / 45a488b riak_mnesia_24 / riak_mnesia / 45a488b |
45a488b
to
48e9f2f
Compare
small_tests_24 / small_tests / 48e9f2f small_tests_23 / small_tests / 48e9f2f dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 48e9f2f dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 48e9f2f dynamic_domains_mysql_redis_24 / mysql_redis / 48e9f2f ldap_mnesia_23 / ldap_mnesia / 48e9f2f dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 48e9f2f internal_mnesia_24 / internal_mnesia / 48e9f2f ldap_mnesia_24 / ldap_mnesia / 48e9f2f pgsql_mnesia_24 / pgsql_mnesia / 48e9f2f pgsql_mnesia_23 / pgsql_mnesia / 48e9f2f mysql_redis_24 / mysql_redis / 48e9f2f mssql_mnesia_24 / odbc_mssql_mnesia / 48e9f2f elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 48e9f2f riak_mnesia_24 / riak_mnesia / 48e9f2f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌🏽
init_per_testcase(TC, Config) -> | ||
Spec = escalus_fresh:freshen_spec(Config, alice), | ||
Clean = register_internal_user(Spec), | ||
[{clean_fn, Clean}, {spec, Spec}|escalus:init_per_testcase(TC, Config)]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spaces
This PR addresses "Allow to specify auth modules per a listener".
Proposed changes include:
allowed_auth_methods