-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL - Implement roster category #3586
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/graphql #3586 +/- ##
===================================================
+ Coverage 81.39% 81.43% +0.03%
===================================================
Files 463 469 +6
Lines 33141 33265 +124
===================================================
+ Hits 26976 27090 +114
- Misses 6165 6175 +10
Continue to review full report at Codecov.
|
This comment was marked as outdated.
This comment was marked as outdated.
6ab1611
to
a4475ee
Compare
This comment was marked as outdated.
This comment was marked as outdated.
a4475ee
to
7cb2c76
Compare
This comment was marked as outdated.
This comment was marked as outdated.
7cb2c76
to
bb0ab57
Compare
This comment was marked as outdated.
This comment was marked as outdated.
bb0ab57
to
7a6aa7d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
7a6aa7d
to
ab8ad93
Compare
This comment was marked as outdated.
This comment was marked as outdated.
The logic was extracted from mod_commands module.
ab8ad93
to
2c6ec68
Compare
This comment was marked as outdated.
This comment was marked as outdated.
2c6ec68
to
f4e7d4e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
f4e7d4e
to
120d43a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a huge amount of good code 👍
290a1ec
to
1c8e586
Compare
This comment was marked as outdated.
This comment was marked as outdated.
small_tests_24 / small_tests / 364b321 small_tests_23 / small_tests / 364b321 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 364b321 dynamic_domains_mysql_redis_24 / mysql_redis / 364b321 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 364b321 ldap_mnesia_23 / ldap_mnesia / 364b321 ldap_mnesia_24 / ldap_mnesia / 364b321 internal_mnesia_24 / internal_mnesia / 364b321 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 364b321 mysql_redis_24 / mysql_redis / 364b321 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 364b321 pgsql_mnesia_23 / pgsql_mnesia / 364b321 mssql_mnesia_24 / odbc_mssql_mnesia / 364b321 riak_mnesia_24 / riak_mnesia / 364b321 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looking good!
This PR addresses MIM-1605 and implements roster category for both user and admin.
This implementation reuse roster commands from
mod_commands
(used by admin and user Rest API) and extracts those functions to the newmod_roster_api
module.There is also a
service_admin_extra_roster
module that delivers commands for CTL, and I tried to implement the most useful functionality in GraphQL with the use of functions proposed by Rest API. The roster functions used by extra roster commands are undocumented and seem to be older. Also, the extra roster API is a little bit different from the Rest API, so I left it unchanged.