-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI_CERT_KEY_VERSION environment variable #3640
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3640 +/- ##
=======================================
Coverage 81.01% 81.02%
=======================================
Files 428 428
Lines 31942 31942
=======================================
+ Hits 25879 25882 +3
+ Misses 6063 6060 -3
Continue to review full report at Codecov.
|
small_tests_24 / small_tests / 2ba29d7 small_tests_23 / small_tests / 2ba29d7 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 2ba29d7 dynamic_domains_mysql_redis_24 / mysql_redis / 2ba29d7 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 2ba29d7 ldap_mnesia_23 / ldap_mnesia / 2ba29d7 pubsub_SUITE:dag+basic:create_delete_node_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,491}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,481}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,471}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1195}]}]}} ldap_mnesia_24 / ldap_mnesia / 2ba29d7 internal_mnesia_24 / internal_mnesia / 2ba29d7 pgsql_mnesia_23 / pgsql_mnesia / 2ba29d7 pgsql_mnesia_24 / pgsql_mnesia / 2ba29d7 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 2ba29d7 mysql_redis_24 / mysql_redis / 2ba29d7 mssql_mnesia_24 / odbc_mssql_mnesia / 2ba29d7 riak_mnesia_24 / riak_mnesia / 2ba29d7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have one comment
.circleci/config.yml
Outdated
@@ -41,6 +41,9 @@ commands: | |||
- run: | |||
name: Print cert hashes for debugging | |||
command: find tools/ssl -type f -exec md5sum {} \; | sort | |||
- run: | |||
name: Continue if certificate data is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name is a bit misleading as we only check if it exists.
name: Continue if certificate data is valid | |
name: Continue if certificate exists |
2ba29d7
to
7417601
Compare
small_tests_24 / small_tests / 7417601 small_tests_23 / small_tests / 7417601 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 7417601 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7417601 dynamic_domains_mysql_redis_24 / mysql_redis / 7417601 ldap_mnesia_23 / ldap_mnesia / 7417601 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 7417601 ldap_mnesia_24 / ldap_mnesia / 7417601 internal_mnesia_24 / internal_mnesia / 7417601 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 7417601 pgsql_mnesia_24 / pgsql_mnesia / 7417601 mysql_redis_24 / mysql_redis / 7417601 pgsql_mnesia_23 / pgsql_mnesia / 7417601 mssql_mnesia_24 / odbc_mssql_mnesia / 7417601 riak_mnesia_24 / riak_mnesia / 7417601 |
This PR addresses "There is no easy way to reset cache without making new changes into the code. And sometimes cache breaks, because a committer did something wrong".
Proposed changes include: