Exometer #365
Merged
Exometer #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis is using test branch |
| @@ -238,3 +240,10 @@ load_drivers([Driver | Rest]) -> | |||
| [erl_ddll:format_error(Reason)]), | |||
| exit({driver_loading_failed, Driver, Reason}) | |||
| end. | |||
|
|
|||
| init_metrics() -> | |||
There was a problem hiding this comment.
I would move this function to the mongoose_metrics module to be consistent with mongoose_metrics:remove_all_metrics()
|
Can you add generic functions for histograms ? |
|
Histograms are planned for next PR where I (or somebody else) will add metrics measuring communication time with databases. |
do not duplicate metrics - some metrics are already defined in mod_metrics
mod_metrics removed
michalwski
force-pushed
the
exometer
branch
2 times, most recently
from
3935e63 to
68372c7
Compare
| | disco_sm_items | spiral | host, hook | | | ||
| | host_config_update | spiral | host, hook | | | ||
| | local_send_to_resource_hook | spiral | host, hook | | | ||
| | mam_lookup_messages | spiral | host, hook | | |
There was a problem hiding this comment.
@arcusfelis, could you please describe MAM related metrics?
* sessionCount * uniqueSessionCount * nodeSessionCount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces folsom with exometer.
Goes on top of #354