Use 'erlexec' directly to avoid overwriting the 'erl' executable #3698
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3698 +/- ##
==========================================
- Coverage 82.15% 82.13% -0.02%
==========================================
Files 510 510
Lines 33596 33596
==========================================
- Hits 27600 27594 -6
- Misses 5996 6002 +6
Continue to review full report at Codecov.
|
|
small_tests_24 / small_tests / 730b3ac small_tests_25 / small_tests / 730b3ac dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 730b3ac ldap_mnesia_24 / ldap_mnesia / 730b3ac dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 730b3ac dynamic_domains_mysql_redis_25 / mysql_redis / 730b3ac dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 730b3ac ldap_mnesia_25 / ldap_mnesia / 730b3ac internal_mnesia_25 / internal_mnesia / 730b3ac pgsql_mnesia_24 / pgsql_mnesia / 730b3ac elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 730b3ac pgsql_mnesia_25 / pgsql_mnesia / 730b3ac mysql_redis_25 / mysql_redis / 730b3ac riak_mnesia_24 / riak_mnesia / 730b3ac mssql_mnesia_25 / odbc_mssql_mnesia / 730b3ac |
chrzaszcz
force-pushed
the
mongooseimctl-fix
branch
from
730b3ac to
7c30b89
Compare
|
small_tests_24 / small_tests / 7c30b89 small_tests_25 / small_tests / 7c30b89 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7c30b89 dynamic_domains_mysql_redis_25 / mysql_redis / 7c30b89 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 7c30b89 ldap_mnesia_24 / ldap_mnesia / 7c30b89 ldap_mnesia_25 / ldap_mnesia / 7c30b89 internal_mnesia_25 / internal_mnesia / 7c30b89 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 7c30b89 pgsql_mnesia_24 / pgsql_mnesia / 7c30b89 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 7c30b89 pgsql_mnesia_25 / pgsql_mnesia / 7c30b89 mysql_redis_25 / mysql_redis / 7c30b89 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,{{badmatch,[{xmlel,<<"presence">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2106@localhost/res1">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2106@localhost/res1">>},
{<<"type">>,<<"unavailable">>}],
[]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}riak_mnesia_24 / riak_mnesia / 7c30b89 mssql_mnesia_25 / odbc_mssql_mnesia / 7c30b89 |
The main motivation is that on some installations the Erlang executables are not writable, and the overwriting would fail. The 'erl' script was initially created to fix escript, but escript is no longer using it, so the entire script can be removed.
chrzaszcz
force-pushed
the
mongooseimctl-fix
branch
from
7c30b89 to
f96cb77
Compare
|
small_tests_24 / small_tests / f96cb77 small_tests_25 / small_tests / f96cb77 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / f96cb77 ldap_mnesia_24 / ldap_mnesia / f96cb77 dynamic_domains_mysql_redis_25 / mysql_redis / f96cb77 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / f96cb77 ldap_mnesia_25 / ldap_mnesia / f96cb77 internal_mnesia_25 / internal_mnesia / f96cb77 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / f96cb77 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / f96cb77 pgsql_mnesia_25 / pgsql_mnesia / f96cb77 mysql_redis_25 / mysql_redis / f96cb77 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2083@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2083@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"ib5Y5gZO6JXq5fds+5K/lw==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}pgsql_mnesia_24 / pgsql_mnesia / f96cb77 bosh_SUITE:essential_https:accept_higher_hold_value{error,
{{assertEqual,
[{module,bosh_SUITE},
{line,251},
{expression,"get_bosh_sessions ( )"},
{expected,[]},
{value,
[{bosh_session,<<"f6de659fb8de3dbf3f30defff6b5801755dadd9f">>,
<8837.6157.0>}]}]},
[{bosh_SUITE,accept_higher_hold_value,1,
[{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
{line,251}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}mssql_mnesia_25 / odbc_mssql_mnesia / f96cb77 mod_blocking_SUITE:manage:add_another_user_to_blocklist{error,{{assertion_failed,assert_many,false,
[is_iq_result,#Fun<mod_blocking_SUITE.32.29136960>],
[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{mod_blocking_SUITE,'-add_another_user_to_blocklist/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/mod_blocking_SUITE.erl"},
{line,182}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}mod_blocking_SUITE:manage:remove_user_from_blocklist{error,{{assertion_failed,assert_many,false,
[is_iq_result,#Fun<mod_blocking_SUITE.36.29136960>],
[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{mod_blocking_SUITE,'-remove_user_from_blocklist/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/mod_blocking_SUITE.erl"},
{line,203}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}mod_blocking_SUITE:manage:add_many_users_to_blocklist{error,{{assertion_failed,assert_many,false,
[is_iq_result,#Fun<mod_blocking_SUITE.32.29136960>],
[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{mod_blocking_SUITE,'-add_many_users_to_blocklist/1-fun-0-',4,
[{file,"/home/circleci/project/big_tests/tests/mod_blocking_SUITE.erl"},
{line,191}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}mod_blocking_SUITE:manage:add_user_to_blocklist{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alice_unnamed_1805_add_user_to_blocklist_1809@localhost/res1">>,
escalus_tcp,<0.19287.1>,
[{event_manager,<0.19241.1>},
{server,<<"localhost">>},
{username,
<<"alicE_unnamed_1805_add_user_to_blocklist_1809">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.19241.1>},
{server,<<"localhost">>},
{username,
<<"alicE_unnamed_1805_add_user_to_blocklist_1809">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alice_unnamed_1805_add_user_to_blocklist_1809">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_unnamed_1805_add_user_to_blocklist_1809">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"ea90b698847f63ab">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{mod_blocking_SUITE,'-add_user_to_blocklist/1-fun-0-',2,
[{file,
"/home/circleci/project/big_tests/tests/mod_blocking_SUITE.erl"},
{line,163}]},
{escalus_story...mod_blocking_SUITE:manage:clear_blocklist{error,{{assertion_failed,assert_many,false,
[is_iq_result,#Fun<mod_blocking_SUITE.36.29136960>],
[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{mod_blocking_SUITE,'-clear_blocklist/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/mod_blocking_SUITE.erl"},
{line,224}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}mod_blocking_SUITE:manage:remove_many_user_from_blocklist{error,{{assertion_failed,assert_many,false,
[is_iq_result,#Fun<mod_blocking_SUITE.32.29136960>],
[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{mod_blocking_SUITE,'-remove_many_user_from_blocklist/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/mod_blocking_SUITE.erl"},
{line,212}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}riak_mnesia_24 / riak_mnesia / f96cb77 sm_SUITE:parallel_unacknowledged_message_hook:unacknowledged_message_hook_bounce{error,
{{assertion_failed,assert,is_chat_message,
[<<"msg-1">>],
{xmlel,<<"message">>,
[{<<"from">>,
<<"bob_unacknowledged_message_hook_bounce_2259@localhost/escalus-default-resource">>},
{<<"to">>,
<<"alice_unacknowledged_message_hook_bounce_2263@localhost">>},
{<<"xml:lang">>,<<"en">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"body">>,[],[{xmlcdata,<<"msg-2">>}]},
{xmlel,<<"delay">>,
[{<<"xmlns">>,<<"urn:xmpp:delay">>},
{<<"stamp">>,<<"2022-06-29T06:52:51.478698Z">>},
{<<"from">>,<<"localhost">>}],
[{xmlcdata,<<"SM Storage">>}]}]},
"<message from='bob_unacknowledged_message_hook_bounce_2259@localhost/escalus-default-resource' to='alice_unacknowledged_message_hook_bounce_2263@localhost' xml:lang='en' type='chat'><body>msg-2</body><delay xmlns='urn:xmpp:delay' stamp='2022-06-29T06:52:51.478698Z' from='localhost'>SM Storage</delay></message>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{sm_SUITE,unacknowledged_message_hook_common,2,
[{file,"/home/circleci/project/big_tests/tests/sm_SUITE.erl"},
{line,857}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"tes...pgsql_mnesia_24 / pgsql_mnesia / f96cb77 riak_mnesia_24 / riak_mnesia / f96cb77 |
The main motivation is that on some installations the Erlang executables are not writable, and the overwriting would fail.
The 'erl' script was initially created to fix escript, but escript is no longer using it, so the entire script can be removed.