-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stat and domain categories #3715
Update stat and domain categories #3715
Conversation
Motivation: - Conflict of 'stats' with the old 'stats' command. - Consistency - there is 'metric', 'vcard', 'stanza' etc.
Also: rename 'stats' to 'stat'
small_tests_24 / small_tests / ae96db7 small_tests_25 / small_tests / ae96db7 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ae96db7 ldap_mnesia_24 / ldap_mnesia / ae96db7 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ae96db7 dynamic_domains_mysql_redis_25 / mysql_redis / ae96db7 ldap_mnesia_25 / ldap_mnesia / ae96db7 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / ae96db7 pgsql_mnesia_24 / pgsql_mnesia / ae96db7 internal_mnesia_25 / internal_mnesia / ae96db7 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ae96db7 pgsql_mnesia_25 / pgsql_mnesia / ae96db7 mysql_redis_25 / mysql_redis / ae96db7 mssql_mnesia_25 / odbc_mssql_mnesia / ae96db7 riak_mnesia_24 / riak_mnesia / ae96db7 |
Codecov Report
@@ Coverage Diff @@
## feature/graphql-cli #3715 +/- ##
========================================================
+ Coverage 61.43% 82.22% +20.79%
========================================================
Files 520 520
Lines 33769 33769
========================================================
+ Hits 20745 27767 +7022
+ Misses 13024 6002 -7022
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Use singular nouns for all category names
Motivation:
Tests CLI for statistics as well.
Note: I found that there are no tests for error handling in the
stat
category. It's not urgent, so I am not fixing it here.