Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stat and domain categories #3715

Merged
merged 3 commits into from
Jul 25, 2022

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Jul 25, 2022

Use singular nouns for all category names

Motivation:

  • Conflict of the new 'stats' category with the old 'stats' command in CLI.
  • Consistency - there is 'metric', 'vcard', 'stanza' etc.

Tests CLI for statistics as well.

Note: I found that there are no tests for error handling in the stat category. It's not urgent, so I am not fixing it here.

Motivation:
  - Conflict of 'stats' with the old 'stats' command.
  - Consistency - there is 'metric', 'vcard', 'stanza' etc.
Also: rename 'stats' to 'stat'
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 25, 2022

small_tests_24 / small_tests / ae96db7
Reports root / small


small_tests_25 / small_tests / ae96db7
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ae96db7
Reports root/ big
OK: 3325 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / ae96db7
Reports root/ big
OK: 1895 / Failed: 0 / User-skipped: 500 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ae96db7
Reports root/ big
OK: 3325 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / ae96db7
Reports root/ big
OK: 3308 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / ae96db7
Reports root/ big
OK: 1895 / Failed: 0 / User-skipped: 500 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / ae96db7
Reports root/ big
OK: 3325 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / ae96db7
Reports root/ big
OK: 3699 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / ae96db7
Reports root/ big
OK: 2016 / Failed: 0 / User-skipped: 379 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ae96db7
Reports root/ big
OK: 2312 / Failed: 0 / User-skipped: 374 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / ae96db7
Reports root/ big
OK: 3699 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / ae96db7
Reports root/ big
OK: 3694 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / ae96db7
Reports root/ big
OK: 3699 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / ae96db7
Reports root/ big
OK: 2173 / Failed: 0 / User-skipped: 367 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #3715 (ae96db7) into feature/graphql-cli (c8d1e9d) will increase coverage by 20.79%.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##           feature/graphql-cli    #3715       +/-   ##
========================================================
+ Coverage                61.43%   82.22%   +20.79%     
========================================================
  Files                      520      520               
  Lines                    33769    33769               
========================================================
+ Hits                     20745    27767     +7022     
+ Misses                   13024     6002     -7022     
Impacted Files Coverage Δ
.../graphql/admin/mongoose_graphql_admin_mutation.erl 100.00% <ø> (+23.07%) ⬆️
src/graphql/admin/mongoose_graphql_admin_query.erl 100.00% <ø> (+21.42%) ⬆️
src/mod_muc_log.erl 62.82% <0.00%> (+0.26%) ⬆️
src/ejabberd_ctl.erl 24.18% <0.00%> (+0.29%) ⬆️
src/pubsub/node_flat.erl 74.70% <0.00%> (+0.39%) ⬆️
src/privacy/mod_privacy.erl 85.77% <0.00%> (+0.41%) ⬆️
src/mod_caps.erl 75.34% <0.00%> (+0.46%) ⬆️
src/muc_light/mod_muc_light_codec_modern.erl 89.94% <0.00%> (+0.52%) ⬆️
src/pubsub/mod_pubsub.erl 73.42% <0.00%> (+0.67%) ⬆️
src/muc_light/mod_muc_light_utils.erl 92.00% <0.00%> (+1.00%) ⬆️
... and 224 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8d1e9d...ae96db7. Read the comment docs.

@chrzaszcz chrzaszcz marked this pull request as ready for review July 25, 2022 12:38
Copy link
Contributor

@JanuszJakubiec JanuszJakubiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@JanuszJakubiec JanuszJakubiec merged commit 49d3984 into feature/graphql-cli Jul 25, 2022
@JanuszJakubiec JanuszJakubiec deleted the update-stat-and-domain-categories branch July 25, 2022 12:55
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants