-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make enforcing simple queries configurable #3733
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## master #3733 +/- ##
==========================================
+ Coverage 81.95% 82.31% +0.36%
==========================================
Files 526 526
Lines 33839 33844 +5
==========================================
+ Hits 27732 27859 +127
+ Misses 6107 5985 -122
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This comment was marked as outdated.
This comment was marked as outdated.
607a325
to
28cb7a1
Compare
small_tests_24 / small_tests / 28cb7a1 small_tests_25 / small_tests / 28cb7a1 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 28cb7a1 ldap_mnesia_24 / ldap_mnesia / 28cb7a1 dynamic_domains_mysql_redis_25 / mysql_redis / 28cb7a1 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 28cb7a1 ldap_mnesia_25 / ldap_mnesia / 28cb7a1 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 28cb7a1 pgsql_mnesia_24 / pgsql_mnesia / 28cb7a1 internal_mnesia_25 / internal_mnesia / 28cb7a1 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 28cb7a1 pgsql_mnesia_25 / pgsql_mnesia / 28cb7a1 mysql_redis_25 / mysql_redis / 28cb7a1 riak_mnesia_24 / riak_mnesia / 28cb7a1 mssql_mnesia_25 / odbc_mssql_mnesia / 28cb7a1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
This might be useful when we just don't want to offer clients the possibility of making very expensive queries. A conversation with over 10k messages is not uncommon, and when there are many of them and that many are fetched, it can put the DB at DDoS risk.
So if the operator desires so, all counting operations can be removed to begin with.