Simplify having an extra module for a very simple function #3764
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 82.47% // Head: 82.80% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3764 +/- ##
==========================================
+ Coverage 82.47% 82.80% +0.33%
==========================================
Files 532 531 -1
Lines 34068 34069 +1
==========================================
+ Hits 28096 28212 +116
+ Misses 5972 5857 -115
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
NelsonVides
force-pushed
the
kill_redundant_module
branch
from
5f974dc to
d4264b2
Compare
|
small_tests_24 / small_tests / d4264b2 small_tests_25 / small_tests / d4264b2 ldap_mnesia_24 / ldap_mnesia / d4264b2 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d4264b2 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d4264b2 dynamic_domains_mysql_redis_25 / mysql_redis / d4264b2 ldap_mnesia_25 / ldap_mnesia / d4264b2 pgsql_mnesia_24 / pgsql_mnesia / d4264b2 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / d4264b2 internal_mnesia_25 / internal_mnesia / d4264b2 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / d4264b2 mysql_redis_25 / mysql_redis / d4264b2 pgsql_mnesia_25 / pgsql_mnesia / d4264b2 mssql_mnesia_25 / odbc_mssql_mnesia / d4264b2 pep_SUITE:pep_tests:delayed_receive{error,{{badmatch,[]},
[{pep_SUITE,'-delayed_receive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,276}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,{{assertion_failed,assert_many,false,
[is_roster_set,is_presence,is_presence],
[{xmlel,<<"presence">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2477@localhost/res1">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2477@localhost/res1">>},
{<<"xml:lang">>,<<"en">>}],
[]}],
" <presence from='alice_unsubscribe_after_presence_unsubscription_2477@localhost/res1' to='bob_unsubscribe_after_presence_unsubscription_2477@localhost/res1' xml:lang='en'/>"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{escalus_utils,distinct_pairs,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,60}]},
{escalus_story,mak...pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2488@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2488@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"ejF4hZWIdbXAtowxbFJBDA==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}riak_mnesia_24 / riak_mnesia / d4264b2 mssql_mnesia_25 / odbc_mssql_mnesia / d4264b2 |
Having a module only for such a super simple module feels quite redundant, we already have a
mongoose_binhelper module for doing things to binaries.