Unified REST API: metrics #3771

chrzaszcz · 2022-09-23T07:21:39Z

Remove the obsolete mongoose_api. It had two handlers:

mongoose_api_users is removed, because had functions that are fully covered by the new REST and GraphQL API's.
mongoose_api_metrics had an incomplete API for metrics. For example, it did not fully handle metrics with compound names (more than one atom after the host type). I decided to move that functionality to mongoose_admin_api_metrics without functional changes (except error handling). The main reason is that this obsolete API was most likely unused. We can always extend it to use mongoose_metrics_api just like the GraphQL API does, should anyone need it. However, most likely we will eventually remove it with the whole REST API.

codecov · 2022-09-23T07:33:34Z

Codecov Report

Base: 82.85% // Head: 82.88% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (2679933) compared to base (df6df9c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@                     Coverage Diff                      @@
##           feature/unified-rest-api    #3771      +/-   ##
============================================================
+ Coverage                     82.85%   82.88%   +0.03%     
============================================================
  Files                           533      529       -4     
  Lines                         33872    33712     -160     
============================================================
- Hits                          28063    27943     -120     
+ Misses                         5809     5769      -40

Impacted Files	Coverage Δ
src/metrics/mongoose_metrics.erl	`92.47% <ø> (ø)`
src/mongoose_admin_api/mongoose_admin_api.erl	`94.73% <ø> (ø)`
src/mongoose_http_handler.erl	`100.00% <ø> (ø)`
src/mam/mod_mam_pm.erl	`89.64% <100.00%> (ø)`
.../mongoose_admin_api/mongoose_admin_api_metrics.erl	`100.00% <100.00%> (ø)`
...stem_metrics/mongoose_system_metrics_collector.erl	`94.62% <100.00%> (ø)`
src/pubsub/mod_pubsub_db.erl	`57.14% <0.00%> (-28.58%)`	⬇️
src/mod_roster_riak.erl	`96.92% <0.00%> (-1.54%)`	⬇️
src/pubsub/mod_pubsub_db_mnesia.erl	`92.82% <0.00%> (-0.85%)`	⬇️
src/mod_roster.erl	`78.70% <0.00%> (-0.72%)`	⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Although the functionality is not complete (e.g. some requests support only atoms as metic names), this is not changed here. The goal is to only replicate the existing functionality in the new unified handlers.

mongoose-im · 2022-09-23T13:01:16Z

small_tests_24 / small_tests / 0401ec7
Reports root / small

small_tests_25 / small_tests / 0401ec7
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 0401ec7
Reports root/ big
OK: 3829 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

metrics_api_SUITE:metrics:non_existent_metrics

{error,{{assertEqual,[{module,rest_helper},
            {line,513},
            {expression,"S"},
            {expected,<<"404">>},
            {value,<<"505">>}]},
    [{rest_helper,assert_status,2,
            [{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
             {line,513}]},
     {metrics_api_SUITE,non_existent_metrics,1,
              [{file,"/home/circleci/project/big_tests/tests/metrics_api_SUITE.erl"},
               {line,98}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1292}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1224}]}]}}

Report log

ldap_mnesia_24 / ldap_mnesia / 0401ec7
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 745 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 0401ec7
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 745 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 0401ec7
Reports root/ big
OK: 3829 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

metrics_api_SUITE:metrics:non_existent_metrics

{error,{{assertEqual,[{module,rest_helper},
            {line,513},
            {expression,"S"},
            {expected,<<"404">>},
            {value,<<"505">>}]},
    [{rest_helper,assert_status,2,
            [{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
             {line,513}]},
     {metrics_api_SUITE,non_existent_metrics,1,
              [{file,"/home/circleci/project/big_tests/tests/metrics_api_SUITE.erl"},
               {line,98}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_mysql_redis_25 / mysql_redis / 0401ec7
Reports root/ big
OK: 3803 / Failed: 1 / User-skipped: 114 / Auto-skipped: 0

metrics_api_SUITE:metrics:non_existent_metrics

{error,{{assertEqual,[{module,rest_helper},
            {line,513},
            {expression,"S"},
            {expected,<<"404">>},
            {value,<<"505">>}]},
    [{rest_helper,assert_status,2,
            [{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
             {line,513}]},
     {metrics_api_SUITE,non_existent_metrics,1,
              [{file,"/home/circleci/project/big_tests/tests/metrics_api_SUITE.erl"},
               {line,98}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

internal_mnesia_25 / internal_mnesia / 0401ec7
Reports root/ big
OK: 2112 / Failed: 0 / User-skipped: 624 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 0401ec7
Reports root/ big
OK: 4204 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 0401ec7
Reports root/ big
OK: 2452 / Failed: 0 / User-skipped: 619 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 0401ec7
Reports root/ big
OK: 3827 / Failed: 3 / User-skipped: 88 / Auto-skipped: 0

bosh_SUITE:essential_https:accept_higher_hold_value

{error,
  {{assertEqual,
     [{module,bosh_SUITE},
      {line,251},
      {expression,"get_bosh_sessions ( )"},
      {expected,[]},
      {value,
        [{bosh_session,<<"d1b0489d67f583145610e73efaaaed15ae5c4aa2">>,
           <9146.5621.0>}]}]},
   [{bosh_SUITE,accept_higher_hold_value,1,
      [{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
       {line,251}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

graphql_last_SUITE:user:user_get_last

{error,{{badmatch,null},
    [{graphql_last_SUITE,user_get_last_story,2,
               [{file,"/home/circleci/project/big_tests/tests/graphql_last_SUITE.erl"},
                {line,433}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

metrics_api_SUITE:metrics:non_existent_metrics

{error,{{assertEqual,[{module,rest_helper},
            {line,513},
            {expression,"S"},
            {expected,<<"404">>},
            {value,<<"505">>}]},
    [{rest_helper,assert_status,2,
            [{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
             {line,513}]},
     {metrics_api_SUITE,non_existent_metrics,1,
              [{file,"/home/circleci/project/big_tests/tests/metrics_api_SUITE.erl"},
               {line,98}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pgsql_mnesia_25 / pgsql_mnesia / 0401ec7
Reports root/ big
OK: 4215 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2516@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2516@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"BLZLdhlMVXWoHK4znDsGbw==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

riak_mnesia_24 / riak_mnesia / 0401ec7
Reports root/ big
OK: 2292 / Failed: 0 / User-skipped: 611 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 0401ec7
Reports root/ big
OK: 4225 / Failed: 3 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2482@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2482@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"ZqkN7UhIQeORGcCJ8l0xfw==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2492@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2492@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"h6Rnmk+roYtVN2iIH/18pw==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2506@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2506@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"ZAdHBqeFr5V4DrIQ4wQGaA==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mysql_redis_25 / mysql_redis / 0401ec7
Reports root/ big
OK: 4205 / Failed: 4 / User-skipped: 111 / Auto-skipped: 0

jingle_SUITE:all:mongoose_sends_reINVITE_on_source_remove_action

{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,
         <<"bob_mongoose_sends_reinvite_on_source_remove_action_1423@localhost">>},
        {<<"to">>,
         <<"alice_mongoose_sends_reinvite_on_source_remove_action_1423@localhost/res1">>},
        {<<"id">>,<<"76ca5b43-107d-4046-a60b-7a4c3ead810a">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-info">>},
           {<<"sid">>,<<"fa1535e9-c6b6-4efd-b478-32da91d100e0">>}],
          [{xmlel,<<"ringing">>,
             [{<<"xmlns">>,<<"urn:xmpp:jingle:apps:rtp:info:1">>}],
             []}]}]},
     "<iq from='bob_mongoose_sends_reinvite_on_source_remove_action_1423@localhost' to='alice_mongoose_sends_reinvite_on_source_remove_action_1423@localhost/res1' id='76ca5b43-107d-4046-a60b-7a4c3ead810a' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-info' sid='fa1535e9-c6b6-4efd-b478-32da91d100e0'><ringing xmlns='urn:xmpp:jingle:apps:rtp:info:1'/></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/project/big_tests/tests/jingle_SUITE.erl"},
       {line,389}]},
    {jingle_SUITE,initiate_jingle_session,2,
      [{file,"/home/circleci/project/big_test...

Report log

jingle_SUITE:all:mongoose_returns_404_when_not_authorized_user_tires_to_accept_a_session

{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,
         <<"bob_mongoose_returns_404_when_not_authorized_user_tires_to_accept_a_session_1422@localhost">>},
        {<<"to">>,
         <<"alice_mongoose_returns_404_when_not_authorized_user_tires_to_accept_a_session_1422@localhost/res1">>},
        {<<"id">>,<<"2ee250f7-45a8-4e9f-9101-d660781e6caf">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-info">>},
           {<<"sid">>,<<"0ef7d90d-c01b-4923-a4b1-1e4fb9dd8ce6">>}],
          [{xmlel,<<"ringing">>,
             [{<<"xmlns">>,<<"urn:xmpp:jingle:apps:rtp:info:1">>}],
             []}]}]},
     "<iq from='bob_mongoose_returns_404_when_not_authorized_user_tires_to_accept_a_session_1422@localhost' to='alice_mongoose_returns_404_when_not_authorized_user_tires_to_accept_a_session_1422@localhost/res1' id='2ee250f7-45a8-4e9f-9101-d660781e6caf' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-info' sid='0ef7d90d-c01b-4923-a4b1-1e4fb9dd8ce6'><ringing xmlns='urn:xmpp:jingle:apps:rtp:info:1'/></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/project/big_tests/tests/jingle_SUITE.erl"},
       {line,38...

Report log

jingle_SUITE:all:mongoose_sends_reINVITE_on_source_add_action

{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,
         <<"bob_mongoose_sends_reinvite_on_source_add_action_1425@localhost">>},
        {<<"to">>,
         <<"alice_mongoose_sends_reinvite_on_source_add_action_1425@localhost/res1">>},
        {<<"id">>,<<"8ae24af9-97c3-4ce0-a608-393bc0577f92">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-info">>},
           {<<"sid">>,<<"1a36a6bd-8114-4a6f-a4d1-d4c4e80592a7">>}],
          [{xmlel,<<"ringing">>,
             [{<<"xmlns">>,<<"urn:xmpp:jingle:apps:rtp:info:1">>}],
             []}]}]},
     "<iq from='bob_mongoose_sends_reinvite_on_source_add_action_1425@localhost' to='alice_mongoose_sends_reinvite_on_source_add_action_1425@localhost/res1' id='8ae24af9-97c3-4ce0-a608-393bc0577f92' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-info' sid='1a36a6bd-8114-4a6f-a4d1-d4c4e80592a7'><ringing xmlns='urn:xmpp:jingle:apps:rtp:info:1'/></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/project/big_tests/tests/jingle_SUITE.erl"},
       {line,389}]},
    {jingle_SUITE,initiate_jingle_session,2,
      [{file,"/home/circleci/project/big_tests/tests/jing...

Report log

jingle_SUITE:all:mongoose_returns_404_when_nto_authorized_user_tries_to_cancel_a_session

{error,
  {{assertion_failed,assert,is_iq_result,
     {xmlel,<<"iq">>,
       [{<<"from">>,
         <<"bob_mongoose_returns_404_when_nto_authorized_user_tries_to_cancel_a_session_1424@localhost">>},
        {<<"to">>,
         <<"alice_mongoose_returns_404_when_nto_authorized_user_tries_to_cancel_a_session_1424@localhost/res1">>},
        {<<"id">>,<<"befbe6dc-89ae-49d8-b65e-c90f1ad006ba">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"jingle">>,
          [{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
           {<<"action">>,<<"session-info">>},
           {<<"sid">>,<<"5938f2fd-aebe-4654-934d-d8a7e6717c8e">>}],
          [{xmlel,<<"ringing">>,
             [{<<"xmlns">>,<<"urn:xmpp:jingle:apps:rtp:info:1">>}],
             []}]}]},
     "<iq from='bob_mongoose_returns_404_when_nto_authorized_user_tries_to_cancel_a_session_1424@localhost' to='alice_mongoose_returns_404_when_nto_authorized_user_tries_to_cancel_a_session_1424@localhost/res1' id='befbe6dc-89ae-49d8-b65e-c90f1ad006ba' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-info' sid='5938f2fd-aebe-4654-934d-d8a7e6717c8e'><ringing xmlns='urn:xmpp:jingle:apps:rtp:info:1'/></jingle></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
      [{file,"/home/circleci/project/big_tests/tests/jingle_SUITE.erl"},
       {line,38...

Report log

It was revealed by the metric API tests.

mongoose-im · 2022-09-23T13:53:42Z

small_tests_24 / small_tests / 2679933
Reports root / small

small_tests_25 / small_tests / 2679933
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 2679933
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 745 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 2679933
Reports root/ big
OK: 3830 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 2679933
Reports root/ big
OK: 1991 / Failed: 0 / User-skipped: 745 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 2679933
Reports root/ big
OK: 3830 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 2679933
Reports root/ big
OK: 3804 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 2679933
Reports root/ big
OK: 3830 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 2679933
Reports root/ big
OK: 2112 / Failed: 0 / User-skipped: 624 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 2679933
Reports root/ big
OK: 2452 / Failed: 0 / User-skipped: 619 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 2679933
Reports root/ big
OK: 4215 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2546@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2546@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"sdIe+t4K245GRtLeCKtDeA==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

pgsql_mnesia_25 / pgsql_mnesia / 2679933
Reports root/ big
OK: 4204 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 2679933
Reports root/ big
OK: 4190 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 2679933
Reports root/ big
OK: 2292 / Failed: 0 / User-skipped: 611 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 2679933
Reports root/ big
OK: 4203 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive

{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / 2679933
Reports root/ big
OK: 4202 / Failed: 2 / User-skipped: 97 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive

{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

push_integration_SUITE:pubsub_ful:pm_notifications_with_inbox:inbox_msg_reset_unread_count_apns

{error,
  {{assertMatch,
     [{module,push_integration_SUITE},
      {line,662},
      {expression,"Data"},
      {pattern,"# { << \"message-count\" >> := ExpectedCount }"},
      {value,
        #{<<"last-message-body">> => <<"SECOND MESSAGE">>,
        <<"last-message-sender">> =>
          <<"alice_inbox_msg_reset_unread_count_apns_2725@localhost">>,
        <<"message-count">> => 1}}]},
   [{push_integration_SUITE,check_notification,2,
      [{file,
         "/home/circleci/project/big_tests/tests/push_integration_SUITE.erl"},
       {line,662}]},
    {push_integration_SUITE,'-inbox_msg_reset_unread_count/3-fun-0-',5,
      [{file,
         "/home/circleci/project/big_tests/tests/push_integration_SUITE.erl"},
       {line,598}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / 2679933
Reports root/ big
OK: 4204 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

JanuszJakubiec

Looks good

arcusfelis

looks good

arcusfelis

looks good

This comment was marked as outdated.

Sign in to view

chrzaszcz changed the base branch from master to feature/unified-rest-api September 23, 2022 07:32

chrzaszcz force-pushed the unified-rest-api-metrics branch from f4b5e9a to 5a8090c Compare September 23, 2022 07:38

mongoose-im mentioned this pull request Sep 23, 2022

CI build failures summary - part 2 #3685

Closed

This comment was marked as outdated.

Sign in to view

chrzaszcz force-pushed the unified-rest-api-metrics branch from 5a8090c to 2f4b9fb Compare September 23, 2022 07:47

This comment was marked as outdated.

Sign in to view

chrzaszcz force-pushed the unified-rest-api-metrics branch from ef54dc1 to c51f8ce Compare September 23, 2022 09:40

This comment was marked as outdated.

Sign in to view

Paweł Chrząszcz added 7 commits September 23, 2022 13:54

Add metrics API handler with the logic from mongoose_api_metrics

085b29b

Although the functionality is not complete (e.g. some requests support only atoms as metic names), this is not changed here. The goal is to only replicate the existing functionality in the new unified handlers.

Add the metric handlers to mongoose_admin_api

e36eaac

Disable the old mongoose_api in the config file

84ea45e

Update metrics tests for the unified API

856b66b

Remove the obsolete mongoose_api

0879c5e

Remove remaining references to the obsolete API

2f17af3

Remove tests for non-existing old user API

6e56f0d

chrzaszcz force-pushed the unified-rest-api-metrics branch from c51f8ce to 9aa09f2 Compare September 23, 2022 11:55

This comment was marked as outdated.

Sign in to view

chrzaszcz force-pushed the unified-rest-api-metrics branch from 23b0446 to 0401ec7 Compare September 23, 2022 12:52

This comment was marked as outdated.

Sign in to view

Paweł Chrząszcz added 2 commits September 23, 2022 15:45

Add missing error tests and reorganize them

4440aab

Fix an invalid metric name

2679933

It was revealed by the metric API tests.

chrzaszcz force-pushed the unified-rest-api-metrics branch from 0401ec7 to 2679933 Compare September 23, 2022 13:45

chrzaszcz marked this pull request as ready for review September 26, 2022 06:38

JanuszJakubiec approved these changes Sep 26, 2022

View reviewed changes

JanuszJakubiec merged commit 0b4cd4e into feature/unified-rest-api Sep 26, 2022

JanuszJakubiec deleted the unified-rest-api-metrics branch September 26, 2022 13:42

arcusfelis reviewed Sep 26, 2022

View reviewed changes

chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unified REST API: metrics #3771

Unified REST API: metrics #3771

chrzaszcz commented Sep 23, 2022 •

edited

Loading

This comment was marked as outdated.

codecov bot commented Sep 23, 2022 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

mongoose-im commented Sep 23, 2022 •

edited

Loading

mongoose-im commented Sep 23, 2022 •

edited

Loading

JanuszJakubiec left a comment

arcusfelis left a comment

arcusfelis left a comment

Unified REST API: metrics #3771

Unified REST API: metrics #3771

Conversation

chrzaszcz commented Sep 23, 2022 • edited Loading

This comment was marked as outdated.

codecov bot commented Sep 23, 2022 • edited Loading

Codecov Report

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

mongoose-im commented Sep 23, 2022 • edited Loading

mongoose-im commented Sep 23, 2022 • edited Loading

JanuszJakubiec left a comment

Choose a reason for hiding this comment

arcusfelis left a comment

Choose a reason for hiding this comment

arcusfelis left a comment

Choose a reason for hiding this comment

chrzaszcz commented Sep 23, 2022 •

edited

Loading

codecov bot commented Sep 23, 2022 •

edited

Loading

mongoose-im commented Sep 23, 2022 •

edited

Loading

mongoose-im commented Sep 23, 2022 •

edited

Loading