-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove domain/async #3813
Remove domain/async #3813
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 82.99% // Head: 83.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3813 +/- ##
=======================================
Coverage 82.99% 83.00%
=======================================
Files 529 529
Lines 33834 33856 +22
=======================================
+ Hits 28081 28102 +21
- Misses 5753 5754 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
6454fe6
to
ec47878
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ec47878
to
6e3fc6d
Compare
small_tests_24 / small_tests / 6e3fc6d small_tests_25 / small_tests / 6e3fc6d ldap_mnesia_24 / ldap_mnesia / 6e3fc6d dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6e3fc6d ldap_mnesia_25 / ldap_mnesia / 6e3fc6d dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6e3fc6d dynamic_domains_mysql_redis_25 / mysql_redis / 6e3fc6d internal_mnesia_25 / internal_mnesia / 6e3fc6d pgsql_mnesia_24 / pgsql_mnesia / 6e3fc6d elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 6e3fc6d dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6e3fc6d pgsql_mnesia_25 / pgsql_mnesia / 6e3fc6d mysql_redis_25 / mysql_redis / 6e3fc6d riak_mnesia_24 / riak_mnesia / 6e3fc6d mssql_mnesia_25 / odbc_mssql_mnesia / 6e3fc6d pep_SUITE:pep_tests:delayed_receive_with_sm{error,{{badmatch,[]},
[{pep_SUITE,'-delayed_receive_with_sm/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,295}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,{{assertion_failed,assert_many,false,
[is_roster_set,is_presence,is_presence],
[{xmlel,<<"presence">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2582@localhost/res1">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2582@localhost/res1">>},
{<<"xml:lang">>,<<"en">>}],
[]}],
" <presence from='alice_unsubscribe_after_presence_unsubscription_2582@localhost/res1' to='bob_unsubscribe_after_presence_unsubscription_2582@localhost/res1' xml:lang='en'/>"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{escalus_utils,distinct_pairs,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,60}]},
{escalus_story,mak... |
6e3fc6d
to
aa6e24d
Compare
small_tests_24 / small_tests / aa6e24d small_tests_25 / small_tests / aa6e24d ldap_mnesia_24 / ldap_mnesia / aa6e24d dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / aa6e24d muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} dynamic_domains_mysql_redis_25 / mysql_redis / aa6e24d ldap_mnesia_25 / ldap_mnesia / aa6e24d dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / aa6e24d internal_mnesia_25 / internal_mnesia / aa6e24d pgsql_mnesia_24 / pgsql_mnesia / aa6e24d dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / aa6e24d elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / aa6e24d pgsql_mnesia_25 / pgsql_mnesia / aa6e24d mysql_redis_25 / mysql_redis / aa6e24d riak_mnesia_24 / riak_mnesia / aa6e24d mssql_mnesia_25 / odbc_mssql_mnesia / aa6e24d dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / aa6e24d |
Most often, tenant deletion can incur in many many DB operations, which can introduce very long delays and timeout any HTTP connection. And when the HTTP connection times out, the cowboy process running the tenant deletion hook will timeout, and could potentially leave the DB in an inconsistent state.