Remove obsolete XEP-0091 timestamp #383
Conversation
|
I suggest removing the function ( |
|
Thanks @michalwski |
| @@ -54,7 +54,6 @@ | |||
| parse_xdata_submit/1, | |||
| timestamp_to_iso/1, % TODO: Remove once XEP-0091 is Obsolete | |||
There was a problem hiding this comment.
Just noticed that there is another obsolete function. I'd remove it also and see if our tests run by travis passes.
There was a problem hiding this comment.
@michalwski I removed this one too.
|
Regarding tests there is offline_SUITE so you can modify the only test case there to ensure that the legacy timestamp is not present. |
|
And what's most important thanks for your contribution @gmodarelli 👍 |
|
Ok @michalwski I'll try to write the tests and I'll remove the other obsolete method. I'm glad to contribute 👍 |
| @@ -2955,10 +2953,8 @@ add_timestamp({_,_,Micro} = TimeStamp, Server, Packet) -> | |||
| Time = {D,{H,M,S, Micro}}, | |||
| case xml:get_subtag(Packet, <<"delay">>) of | |||
| false -> | |||
| %% TODO: Delete the next element once XEP-0091 is Obsolete | |||
| TimeStampLegacyXML = timestamp_legacy_xml(Server, Time), | |||
There was a problem hiding this comment.
I think that somebody confused the binding/function name and named the modern format as legacy. It's a good opportunity to fix it :)
There was a problem hiding this comment.
@studzien I hope the new name is ok. Thanks for the feedback
|
@michalwski I'm still not able to write tests for the project, sorry. I need to study Erlang more :) But I will! |
|
Looks like some of the obsolete functions where used in other place(s). Take a look at tests output: This happened for all jobs except one which doesn't run this test. |
|
I didn't meant to restore the obsolete function :) The best approach would be to fix the place where the function is used. |
|
@michalwski ok :) I'll try to replace it. |
|
@michalwski sorry if this is taking me so long. I had doubts on how to proceed. The obsolete function (timestamp_to_iso/1) is only used by the build_random_password/1 function in the mod_admin_extra_accounts module. So I replaced the call to the function and generated the date in the build_random_password itself. Please let me know if this is the right way to proceed. Thank you! |
|
I think you can put there date in other format not necessary the obsolete one. This function is generating random password for banned user so in fact we can put any password there, even without date. |
|
Ok cool, so we could remove the date. I'm just wondering if we have restriction on the format of the random password. Can we just remove the date part or we need to replace it with something else? Thank you. |
|
I don't know about any restriction. This format was inherited from ejabberd. The only reason to setup such password is to prevent banned user from authentication. The format just brings the server administrator info that user with such password was banned, when and from what reason. |
|
Ok, I'll add the date back (with this format 1997-07-16T19:20:30.45+01:00) so we won't break code depending on it, even if it is just for logging or debugging purpose. |
|
I was not able to add the timezone offset, so I opted for the universal time. |
|
Ok, UTC is enough for that. |
Remove obsolete XEP-0091 timestamp
|
Thanks for the fix! |
|
Thank you for helping me with it! |
Hi guys, at my company we are developing a mobile chat based on MongooseIM. For our android client we are using the ASmack library and we get an date parsing error when the client receives an offline message.
The offending date is the one passed inside the x tag of the XEP-0091 extension. Since I noticed it has obsoleted, I thought I could have removed it from MongooseIM.
But I'm a Ruby developer and know just the very basics of Erlang. I've managed to remove the tag from the message stanza, recompiled the repo and the server works. No date parsing error on the client anymore.
But I don't know if I need to add some tests around my changes or if the changes are correct (ie. do I need to remove/add something else?). I'd love to contribute to the project and I'd like to hear your feedback.
Bye