-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable global_distrib, muc, and fix stream_mgmt timeouts #3909
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 74.52% // Head: 79.34% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feature/mongoose_c2s #3909 +/- ##
========================================================
+ Coverage 74.52% 79.34% +4.82%
========================================================
Files 540 540
Lines 34196 34198 +2
========================================================
+ Hits 25483 27135 +1652
+ Misses 8713 7063 -1650
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
4639182
to
c8699e6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
97635da
to
09a4672
Compare
This comment was marked as outdated.
This comment was marked as outdated.
6b380a7
to
0031b71
Compare
09a4672
to
6c6e202
Compare
This comment was marked as outdated.
This comment was marked as outdated.
6c6e202
to
270412a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Note that for `gen_statem`, timeouts of the type `{timeout, Time, Msg}` are considered event timeouts, and are canceled upon any event delivered before them, so they can get lost for example upon the process receiving any other routed message. So we need to name them, `{{timeout, ?MODULE}, Time, Msg}`.
270412a
to
99649b5
Compare
small_tests_24 / small_tests / 99649b5 small_tests_25 / small_tests / 99649b5 ldap_mnesia_24 / ldap_mnesia / 99649b5 pubsub_SUITE:dag+node_config:notify_only_available_users_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,491}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,481}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,471}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 99649b5 ldap_mnesia_25 / ldap_mnesia / 99649b5 pgsql_mnesia_24 / pgsql_mnesia / 99649b5 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 99649b5 riak_mnesia_24 / riak_mnesia / 99649b5 internal_mnesia_25 / internal_mnesia / 99649b5 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 99649b5 dynamic_domains_mysql_redis_25 / mysql_redis / 99649b5 pgsql_mnesia_25 / pgsql_mnesia / 99649b5 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 99649b5 mysql_redis_25 / mysql_redis / 99649b5 muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mssql_mnesia_25 / odbc_mssql_mnesia / 99649b5 mysql_redis_25 / mysql_redis / 99649b5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice to see the suites enabled 🙂 I added one minor comment.
small_tests_24 / small_tests / 4351e4a small_tests_25 / small_tests / 4351e4a ldap_mnesia_24 / ldap_mnesia / 4351e4a dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 4351e4a ldap_mnesia_25 / ldap_mnesia / 4351e4a dynamic_domains_mysql_redis_25 / mysql_redis / 4351e4a pgsql_mnesia_24 / pgsql_mnesia / 4351e4a elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 4351e4a dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 4351e4a mod_ping_SUITE:server_ping:server_ping_pong{error,{{badmatch,[{[<<"test_type">>,mod_ping,ping_response],
{expected_diff,5},
{before_story,0},
{after_story,4}}]},
[{escalus_mongooseim,post_story_check_metrics,1,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
{line,74}]},
{escalus_mongooseim,maybe_check_metrics_post_story,1,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_mongooseim.erl"},
{line,51}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,75}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} internal_mnesia_25 / internal_mnesia / 4351e4a dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 4351e4a pgsql_mnesia_25 / pgsql_mnesia / 4351e4a riak_mnesia_24 / riak_mnesia / 4351e4a mysql_redis_25 / mysql_redis / 4351e4a mssql_mnesia_25 / odbc_mssql_mnesia / 4351e4a inbox_SUITE:async_pools:muclight_config:system_message_is_correctly_avoided{error,
{{inbox_size,1,
[{times,50,
{error,
#{check_params => #{},error => function_clause,
expected_items =>
[#{content => <<"How are you?">>,
from =>
<<"[email protected]/bob@localhost">>,
to => <<"[email protected]">>,unread => 2,
verify => #Fun<inbox_SUITE.86.98501125>}],
inbox_items => [],query_params => #{},
reason => inbox_mismatch,
stacktrace =>
[{lists,zip,
[[],
[{conv,2,
<<"[email protected]/bob@localhost">>,
<<"[email protected]">>,
<<"How are you?">>,
#Fun<inbox_SUITE.86.98501125>,undefined}]],
[{file,"lists.erl"},{line,419}]},
{inbox_helper,check_inbox_result,5,
[{file,
"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,221}]},
{inbox_helper,do_check_inbox,5,
[{file,
"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,208}]},
{inbox_helper,'-check_inbox/4-fun-0-',5,
[{file,
"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,201}]},
{mongoose_helper,do_wait_until,2,
... inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_forwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"kate_can_paginate_forwards_1516@localhost/res1">>,
escalus_tcp,<0.13256.1>,
[{event_manager,<0.13204.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_forwards_1516">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.13204.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_forwards_1516">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_can_paginate_forwards_1516">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_can_paginate_forwards_1516">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"d7b4ada7b90999a5">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-can_paginate_forwards/1-fun-0-',4,
[{file,
"/home/circleci/project/bi... inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_be_limited{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"kate_max_queries_can_be_limited_1517@localhost/res1">>,
escalus_tcp,<0.13257.1>,
[{event_manager,<0.13211.1>},
{server,<<"localhost">>},
{username,<<"kate_max_queries_can_be_limited_1517">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.13211.1>},
{server,<<"localhost">>},
{username,<<"kate_max_queries_can_be_limited_1517">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_max_queries_can_be_limited_1517">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_max_queries_can_be_limited_1517">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"8ad15252e63b76a4">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-max_queries_can_be_limited/1-fun-0-',4,
[{f... inbox_extensions_SUITE:regular:one_to_one:pagination:pagination_overrides_form{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"kate_pagination_overrides_form_1521@localhost/res1">>,
escalus_tcp,<0.13258.1>,
[{event_manager,<0.13239.1>},
{server,<<"localhost">>},
{username,<<"kate_pagination_overrides_form_1521">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.13239.1>},
{server,<<"localhost">>},
{username,<<"kate_pagination_overrides_form_1521">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_pagination_overrides_form_1521">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_pagination_overrides_form_1521">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"2449e82c5a16dd60">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-pagination_overrides_form/1-fun-0-',4,
[{file,
... inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_backwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"kate_can_paginate_backwards_1519@localhost/res1">>,
escalus_tcp,<0.13259.1>,
[{event_manager,<0.13225.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_backwards_1519">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.13225.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_backwards_1519">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_can_paginate_backwards_1519">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_can_paginate_backwards_1519">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"58a404d295eec10e">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-can_paginate_backwards/1-fun-0-',4,
[{file,
"/home/circleci/proj... inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_fetch_ahead{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"kate_max_queries_can_fetch_ahead_1520@localhost/res1">>,
escalus_tcp,<0.13260.1>,
[{event_manager,<0.13232.1>},
{server,<<"localhost">>},
{username,<<"kate_max_queries_can_fetch_ahead_1520">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.13232.1>},
{server,<<"localhost">>},
{username,<<"kate_max_queries_can_fetch_ahead_1520">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_max_queries_can_fetch_ahead_1520">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_max_queries_can_fetch_ahead_1520">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"0c7508f57a687803">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-max_queries_can_fetch_ahead/1-fun-0-',4,
... muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 4351e4a mssql_mnesia_25 / odbc_mssql_mnesia / 4351e4a |
Fixing global distribution, muc presence error, and stream management.
Also enable other unrelated suites that can now pass successfully.
Note that for
gen_statem
, timeouts of the type{timeout, Time, Msg}
are considered event timeouts, and are canceled upon any event delivered before them, so they can get lost for example upon the process receiving any other routed message. So we need to name them,{{timeout, ?MODULE}, Time, Msg}
.