Refactored handlers to follow stop convention #3912
Conversation
|
small_tests_24 / small_tests / 56b0fb8 small_tests_25 / small_tests / 56b0fb8 ldap_mnesia_24 / ldap_mnesia / 56b0fb8 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 56b0fb8 ldap_mnesia_25 / ldap_mnesia / 56b0fb8 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 56b0fb8 dynamic_domains_mysql_redis_25 / mysql_redis / 56b0fb8 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 56b0fb8 smart_markers_SUITE:regular:one2one:marker_for_thread_can_be_fetched{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.29075.2>,
[{event_manager,<0.29039.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_marker_for_thread_can_be_fetched_2696">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.29039.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_marker_for_thread_can_be_fetched_2696">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alice_marker_for_thread_can_be_fetched_2696">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_marker_for_thread_can_be_fetched_2696">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"3a27869da2f896e1">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{smart_markers_SUITE,'-marker_for_thread_can_be_fetched/1-fun-0-',2,
[{file,
"/home/circleci/project/b...smart_markers_SUITE:regular:one2one:remove_markers_when_removed_user{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.29081.2>,
[{event_manager,<0.29060.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_remove_markers_when_removed_user_2699">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.29060.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_remove_markers_when_removed_user_2699">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alice_remove_markers_when_removed_user_2699">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_remove_markers_when_removed_user_2699">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"a90e89cd7c5f7f05">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{smart_markers_SUITE,'-remove_markers_when_removed_user/1-fun-2-',2,
[{file,
"/home/circleci/project/b...smart_markers_SUITE:regular:one2one:marker_after_timestamp_can_be_fetched{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alice_marker_after_timestamp_can_be_fetched_2695@domain.example.com/res1">>,
escalus_tcp,<0.29073.2>,
[{event_manager,<0.29031.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_marker_after_timestamp_can_be_fetched_2695">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.29031.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_marker_after_timestamp_can_be_fetched_2695">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alice_marker_after_timestamp_can_be_fetched_2695">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_marker_after_timestamp_can_be_fetched_2695">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"2c375adbd45ed872">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{smart_markers_SUITE,
'-marker_after_timestamp_can_be_fetched/1-fun-0-',2,
[{fil...smart_markers_SUITE:regular:one2one:marker_after_timestamp_for_threadid_can_be_fetched{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alice_marker_after_timestamp_for_threadid_can_be_fetched_2698@domain.example.com/res1">>,
escalus_tcp,<0.29077.2>,
[{event_manager,<0.29053.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_marker_after_timestamp_for_threadid_can_be_fetched_2698">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.29053.2>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_marker_after_timestamp_for_threadid_can_be_fetched_2698">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alice_marker_after_timestamp_for_threadid_can_be_fetched_2698">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_marker_after_timestamp_for_threadid_can_be_fetched_2698">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"bfa7802ab6c35d4d">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{smart_markers_SUITE,
...internal_mnesia_25 / internal_mnesia / 56b0fb8 pgsql_mnesia_24 / pgsql_mnesia / 56b0fb8 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 56b0fb8 riak_mnesia_24 / riak_mnesia / 56b0fb8 pgsql_mnesia_25 / pgsql_mnesia / 56b0fb8 mysql_redis_25 / mysql_redis / 56b0fb8 mssql_mnesia_25 / odbc_mssql_mnesia / 56b0fb8 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3912 +/- ##
=========================================
Coverage ? 83.13%
=========================================
Files ? 535
Lines ? 34109
Branches ? 0
=========================================
Hits ? 28358
Misses ? 5751
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pawlooss1
force-pushed
the
hooks/stop-refactor
branch
from
56b0fb8 to
30b1cdf
Compare
|
small_tests_24 / small_tests / 30b1cdf small_tests_25 / small_tests / 30b1cdf dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 30b1cdf ldap_mnesia_24 / ldap_mnesia / 30b1cdf ldap_mnesia_25 / ldap_mnesia / 30b1cdf dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 30b1cdf dynamic_domains_mysql_redis_25 / mysql_redis / 30b1cdf dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 30b1cdf pgsql_mnesia_24 / pgsql_mnesia / 30b1cdf pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2667@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2667@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"p7LBg+5A1smKGWqWpqcROA==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}internal_mnesia_25 / internal_mnesia / 30b1cdf elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 30b1cdf riak_mnesia_24 / riak_mnesia / 30b1cdf pgsql_mnesia_25 / pgsql_mnesia / 30b1cdf mssql_mnesia_25 / odbc_mssql_mnesia / 30b1cdf mysql_redis_25 / mysql_redis / 30b1cdf |
pawlooss1
force-pushed
the
hooks/stop-refactor
branch
from
30b1cdf to
1e9d46a
Compare
|
small_tests_24 / small_tests / 1e9d46a small_tests_25 / small_tests / 1e9d46a dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 1e9d46a ldap_mnesia_24 / ldap_mnesia / 1e9d46a dynamic_domains_mysql_redis_25 / mysql_redis / 1e9d46a ldap_mnesia_25 / ldap_mnesia / 1e9d46a dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 1e9d46a internal_mnesia_25 / internal_mnesia / 1e9d46a dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 1e9d46a pgsql_mnesia_24 / pgsql_mnesia / 1e9d46a elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 1e9d46a riak_mnesia_24 / riak_mnesia / 1e9d46a mysql_redis_25 / mysql_redis / 1e9d46a pgsql_mnesia_25 / pgsql_mnesia / 1e9d46a mssql_mnesia_25 / odbc_mssql_mnesia / 1e9d46a |
pawlooss1
force-pushed
the
hooks/stop-refactor
branch
from
1e9d46a to
5e61de8
Compare
|
small_tests_24 / small_tests / 5e61de8 small_tests_25 / small_tests / 5e61de8 ldap_mnesia_24 / ldap_mnesia / 5e61de8 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 5e61de8 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 5e61de8 ldap_mnesia_25 / ldap_mnesia / 5e61de8 dynamic_domains_mysql_redis_25 / mysql_redis / 5e61de8 pgsql_mnesia_24 / pgsql_mnesia / 5e61de8 internal_mnesia_25 / internal_mnesia / 5e61de8 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 5e61de8 inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_be_limited{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.10863.1>,
[{event_manager,<0.10846.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_max_queries_can_be_limited_1619">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.10846.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_max_queries_can_be_limited_1619">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_max_queries_can_be_limited_1619">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_max_queries_can_be_limited_1619">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"9b33b7cc20ccd4d7">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{in...inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_backwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.10862.1>,
[{event_manager,<0.10839.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_can_paginate_backwards_1618">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.10839.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_can_paginate_backwards_1618">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_can_paginate_backwards_1618">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_can_paginate_backwards_1618">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"58f3ac22d664eb01">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{inbox_extensions_SUITE...inbox_extensions_SUITE:regular:one_to_one:pagination:pagination_overrides_form{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.10864.1>,
[{event_manager,<0.10832.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_pagination_overrides_form_1617">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.10832.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_pagination_overrides_form_1617">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_pagination_overrides_form_1617">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_pagination_overrides_form_1617">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"d1d9e9a8aa66de10">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{inbox_e...inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_fetch_ahead{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.10860.1>,
[{event_manager,<0.10853.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_max_queries_can_fetch_ahead_1620">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.10853.1>},
{server,<<"domain.example.com">>},
{username,<<"bOb_max_queries_can_fetch_ahead_1620">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_max_queries_can_fetch_ahead_1620">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_max_queries_can_fetch_ahead_1620">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"dda316bfe2a17687">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
...inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_forwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"[email protected]/res1">>,
escalus_tcp,<0.10866.1>,
[{event_manager,<0.10825.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_can_paginate_forwards_1616">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.10825.1>},
{server,<<"domain.example.com">>},
{username,<<"kate_can_paginate_forwards_1616">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_can_paginate_forwards_1616">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_can_paginate_forwards_1616">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"3f95d8998773985d">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUI...elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 5e61de8 riak_mnesia_24 / riak_mnesia / 5e61de8 pgsql_mnesia_25 / pgsql_mnesia / 5e61de8 mssql_mnesia_25 / odbc_mssql_mnesia / 5e61de8 rest_client_SUITE:roster:add_and_remove_some_contacts_properly{error,{{badmatch,{{<<"500">>,<<"Internal Server Error">>},<<>>}},
[{rest_client_SUITE,add_contact_check_roster_push,2,
[{file,"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
{line,1390}]},
{lists,foreach_1,2,[{file,"lists.erl"},{line,1442}]},
{rest_client_SUITE,'-add_and_remove_some_contacts_properly/1-fun-1-',
4,
[{file,"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
{line,1327}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{rest_client_SUITE,add_and_remove_some_contacts_properly,1,
[{file,"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
{line,1322}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}mysql_redis_25 / mysql_redis / 5e61de8 |
pawlooss1
force-pushed
the
hooks/stop-refactor
branch
from
5e61de8 to
6dc1220
Compare
|
small_tests_24 / small_tests / 6dc1220 small_tests_25 / small_tests / 6dc1220 ldap_mnesia_24 / ldap_mnesia / 6dc1220 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6dc1220 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6dc1220 dynamic_domains_mysql_redis_25 / mysql_redis / 6dc1220 pgsql_mnesia_24 / pgsql_mnesia / 6dc1220 ldap_mnesia_25 / ldap_mnesia / 6dc1220 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6dc1220 inbox_extensions_SUITE:async_pools:one_to_one:mute_muted_entry_gets_unmuted{error,
{{assert,
[{module,inbox_extensions_SUITE},
{line,882},
{expression,"escalus_pred : is_message ( Message )"},
{expected,true},
{value,false}]},
[{inbox_extensions_SUITE,check_message_with_properties,4,
[{file,
"/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
{line,882}]},
{inbox_extensions_SUITE,set_inbox_properties,4,
[{file,
"/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
{line,876}]},
{inbox_extensions_SUITE,'-mute_muted_entry_gets_unmuted/1-fun-2-',2,
[{file,
"/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
{line,575}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}internal_mnesia_25 / internal_mnesia / 6dc1220 riak_mnesia_24 / riak_mnesia / 6dc1220 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 6dc1220 pgsql_mnesia_25 / pgsql_mnesia / 6dc1220 mysql_redis_25 / mysql_redis / 6dc1220 mssql_mnesia_25 / odbc_mssql_mnesia / 6dc1220 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6dc1220 |
All handlers use return value
{stop, Acc}to interrupt further processing. Infilter_local_packetI couldn't removedropas a result Acc since code which launch this hook has logic depending on it.