Avoid certificate verification for google analytics #3978
Conversation
|
small_tests_24 / small_tests / f64ff4a small_tests_25 / small_tests / f64ff4a ldap_mnesia_24 / ldap_mnesia / f64ff4a dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / f64ff4a ldap_mnesia_25 / ldap_mnesia / f64ff4a pgsql_mnesia_24 / pgsql_mnesia / f64ff4a push_pubsub_SUITE:rest_integration_v2:init_per_group{'EXIT',
{{badrpc,
{'EXIT',
{{badmatch,
{error,
{{shutdown,
{failed_to_start_child,
'wpool_pool-mongoose_wpool$generic$localhost$mongoosepush_service-process-sup',
{shutdown,
{failed_to_start_child,
'wpool_pool-mongoose_wpool$generic$localhost$mongoosepush_service-22',
{already_started,<8851.18776.3>}}}}},
{child,undefined,
'mongoose_wpool$generic$localhost$mongoosepush_service',
{wpool,start_pool,
['mongoose_wpool$generic$localhost$mongoosepush_service',
[{workers,100}]]},
temporary,false,infinity,supervisor,
[wpool]}}}},
[{mod_push_service_mongoosepush,start_pool,2,
[{file,
"/home/circleci/project/src/mod_push_service_mongoosepush.erl"},
{line,50}]},
{mod_push_service_mongoosepush,start,2,
[{file,
"/home/circleci/project/src/mod_push_service_mongoosepush.erl"},
{line,43}]},
{gen_mod,start_module_for_host_type,3,
[{file,"/home/circleci/project/src/gen_mod.erl"},
{line,104}]},
{mongoose_modules,start_module,4,
[{file,"/home/circleci/project/src/mongoose_modules.erl"},
{line,90}]},
{mongoose_modules,ensure_started,3,
[{file,"/home/circleci/project/src/mongoose_modules.e...dynamic_domains_mysql_redis_25 / mysql_redis / f64ff4a internal_mnesia_25 / internal_mnesia / f64ff4a dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / f64ff4a riak_mnesia_24 / riak_mnesia / f64ff4a pgsql_mnesia_25 / pgsql_mnesia / f64ff4a elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / f64ff4a mssql_mnesia_25 / odbc_mssql_mnesia / f64ff4a mysql_redis_25 / mysql_redis / f64ff4a pgsql_mnesia_24 / pgsql_mnesia / f64ff4a mssql_mnesia_25 / odbc_mssql_mnesia / f64ff4a |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3978 +/- ##
==========================================
+ Coverage 83.55% 83.56% +0.01%
==========================================
Files 538 538
Lines 33974 33974
==========================================
+ Hits 28386 28392 +6
+ Misses 5588 5582 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -54,7 +54,7 @@ flush_reports(ReportUrl, Lines) when length(Lines) =< 20 -> | |||
| ContentType = "", | |||
| Body = string:join(Lines, "\n"), | |||
| Request = {ReportUrl, Headers, ContentType, Body}, | |||
| httpc:request(post, Request, [], []); | |||
| httpc:request(post, Request, [{ssl, [{verify, verify_none}]}], []); | |||
There was a problem hiding this comment.
Why exactly verify_none? Is it safe?
There was a problem hiding this comment.
Ok after meeting I understand it now. I'll merge it. If you think that verifying this cert is worth effort please create a ticket.
No description provided.