-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build docker image for arm64 #3979
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3979 +/- ##
==========================================
+ Coverage 83.55% 83.56% +0.01%
==========================================
Files 538 538
Lines 33975 33975
==========================================
+ Hits 28387 28391 +4
+ Misses 5588 5584 -4 see 11 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ebd1194
to
d92cf49
Compare
This comment was marked as outdated.
This comment was marked as outdated.
84e575d
to
3220cea
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
50dc7c9
to
6ccbd48
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
f90e68d
to
5948285
Compare
This comment was marked as outdated.
This comment was marked as outdated.
7c84101
to
1e0b2fa
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
5744688
to
46e6509
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
160d052
to
f7612bb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
4f65d55
to
6b0b763
Compare
This comment was marked as outdated.
This comment was marked as outdated.
- CircleCI does not support docker arm64 executors (yet), so an arm64 machine executor with Docker inside is used for now. - Tarballs have the new format mongooseim-$ARCH.tar.gz - To keep this changeset simple, no tests are done for arm64
small_tests_24 / small_tests / 5fe1413 small_tests_25 / small_tests / 5fe1413 ldap_mnesia_24 / ldap_mnesia / 5fe1413 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 5fe1413 pgsql_mnesia_24 / pgsql_mnesia / 5fe1413 ldap_mnesia_25 / ldap_mnesia / 5fe1413 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 5fe1413 riak_mnesia_24 / riak_mnesia / 5fe1413 dynamic_domains_mysql_redis_25 / mysql_redis / 5fe1413 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 5fe1413 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 5fe1413 internal_mnesia_25 / internal_mnesia / 5fe1413 mysql_redis_25 / mysql_redis / 5fe1413 pgsql_mnesia_25 / pgsql_mnesia / 5fe1413 mssql_mnesia_25 / odbc_mssql_mnesia / 5fe1413 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The goal is to build and push Docker images for both
amd64
andarm64
architectures.arm64
, and pack the results to a separate tarball.docker_build_and_ship
job usesdocker buildx
to build a multi-platform image, combining the tarballs for both architectures.Notes:
arm64
, because CircleCI has no Docker one (yet). Docker is used on that machine to make use of the OTP docker image, and to make build environments for both architectures more consistent.arm64
yet, because they would complicate this PR. There is a plan to add some tests soon. The resulting images start correctly on bothamd64
andarm64
machines.Related pull requests to other repositories: