-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky sm_SUITE:ping_timeout
test
#4270
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4270 +/- ##
==========================================
- Coverage 84.46% 84.41% -0.06%
==========================================
Files 553 553
Lines 33582 33582
==========================================
- Hits 28366 28348 -18
- Misses 5216 5234 +18 ☔ View full report in Codecov by Sentry. |
edf4e66
to
f0f1456
Compare
This comment was marked as outdated.
This comment was marked as outdated.
f0f1456
to
898a556
Compare
This comment was marked as outdated.
This comment was marked as outdated.
898a556
to
9c17be0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
9c17be0
to
0a4f1ff
Compare
This comment was marked as outdated.
This comment was marked as outdated.
023f7a8
to
b3f999c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
b3f999c
to
1c3d834
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1c3d834
to
ea3399a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ea3399a
to
dd557f9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
0894d78
to
1793c1c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1793c1c
to
d19484b
Compare
sm_SUITE
testsm_SUITE:ping_timeout
test
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / d19484b small_tests_25 / small_tests / d19484b small_tests_26 / small_tests / d19484b small_tests_26_arm64 / small_tests / d19484b ldap_mnesia_25 / ldap_mnesia / d19484b dynamic_domains_mysql_redis_26 / mysql_redis / d19484b dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d19484b ldap_mnesia_26 / ldap_mnesia / d19484b dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / d19484b dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / d19484b pgsql_cets_26 / pgsql_cets / d19484b internal_mnesia_26 / internal_mnesia / d19484b pgsql_mnesia_25 / pgsql_mnesia / d19484b mysql_redis_26 / mysql_redis / d19484b pgsql_mnesia_26 / pgsql_mnesia / d19484b mssql_mnesia_26 / odbc_mssql_mnesia / d19484b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This PR addresses the flaky
sm_SUITE:ping_timeout
test.The test was failing sporadically due to the client receiving ping stanzas at inappropriate moments, such as during stream resumption configuration or while attempting to close the connection. Additionally, the client's connection was sometimes closed earlier than expected while it was still receiving information from the server.
These issues were resolved by ignoring ping stanzas during critical moments and retrieving necessary information earlier in the test process.
The test was run 1000 times on CI to confirm that the issue has been resolved.