Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky sm_SUITE:ping_timeout test #4270

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Fix flaky sm_SUITE:ping_timeout test #4270

merged 1 commit into from
Apr 29, 2024

Conversation

jacekwegr
Copy link
Collaborator

@jacekwegr jacekwegr commented Apr 22, 2024

This PR addresses the flaky sm_SUITE:ping_timeout test.

The test was failing sporadically due to the client receiving ping stanzas at inappropriate moments, such as during stream resumption configuration or while attempting to close the connection. Additionally, the client's connection was sometimes closed earlier than expected while it was still receiving information from the server.

These issues were resolved by ignoring ping stanzas during critical moments and retrieving necessary information earlier in the test process.

The test was run 1000 times on CI to confirm that the issue has been resolved.

@mongoose-im

This comment was marked as outdated.

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.41%. Comparing base (56ff9c5) to head (d19484b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4270      +/-   ##
==========================================
- Coverage   84.46%   84.41%   -0.06%     
==========================================
  Files         553      553              
  Lines       33582    33582              
==========================================
- Hits        28366    28348      -18     
- Misses       5216     5234      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@jacekwegr jacekwegr force-pushed the fix-flaky-sm-test branch 2 times, most recently from 023f7a8 to b3f999c Compare April 25, 2024 11:57
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@jacekwegr jacekwegr force-pushed the fix-flaky-sm-test branch 2 times, most recently from 0894d78 to 1793c1c Compare April 26, 2024 12:35
@mongoose-im

This comment was marked as outdated.

@jacekwegr jacekwegr changed the title Fix flaky sm_SUITE test Fix flaky sm_SUITE:ping_timeout test Apr 26, 2024
@mongoose-im
Copy link
Collaborator

mongoose-im commented Apr 26, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / d19484b
Reports root/ big
OK: 437 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0


small_tests_25 / small_tests / d19484b
Reports root / small


small_tests_26 / small_tests / d19484b
Reports root / small


small_tests_26_arm64 / small_tests / d19484b
Reports root / small


ldap_mnesia_25 / ldap_mnesia / d19484b
Reports root/ big
OK: 2286 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / d19484b
Reports root/ big
OK: 4510 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d19484b
Reports root/ big
OK: 4543 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / d19484b
Reports root/ big
OK: 2286 / Failed: 0 / User-skipped: 897 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / d19484b
Reports root/ big
OK: 4543 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / d19484b
Reports root/ big
OK: 4540 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / d19484b
Reports root/ big
OK: 4458 / Failed: 0 / User-skipped: 178 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / d19484b
Reports root/ big
OK: 2426 / Failed: 0 / User-skipped: 757 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / d19484b
Reports root/ big
OK: 4932 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / d19484b
Reports root/ big
OK: 4911 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / d19484b
Reports root/ big
OK: 4932 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / d19484b
Reports root/ big
OK: 4929 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

@jacekwegr jacekwegr marked this pull request as ready for review April 26, 2024 13:54
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrzaszcz chrzaszcz merged commit 703cfbd into master Apr 29, 2024
4 checks passed
@chrzaszcz chrzaszcz deleted the fix-flaky-sm-test branch April 29, 2024 07:23
@jacekwegr jacekwegr added this to the 6.3.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants