-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing muc_prefs_cases in mam_SUITE #4315
Conversation
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 66224da small_tests_25 / small_tests / 66224da small_tests_26 / small_tests / 66224da small_tests_26_arm64 / small_tests / 66224da ldap_mnesia_25 / ldap_mnesia / 66224da ldap_mnesia_26 / ldap_mnesia / 66224da dynamic_domains_mysql_redis_26 / mysql_redis / 66224da dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 66224da dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 66224da pgsql_cets_26 / pgsql_cets / 66224da pgsql_mnesia_25 / pgsql_mnesia / 66224da internal_mnesia_26 / internal_mnesia / 66224da dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 66224da mysql_redis_26 / mysql_redis / 66224da carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_583@localhost">>},
{<<"to">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_583@localhost/res2">>},
{<<"xmlns">>,<<"jabber:client">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"sent">>,
[{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}],
[{xmlel,<<"forwarded">>,
[{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_583@localhost/res1">>},
{<<"type">>,<<"chat">>},
{<<"to">>,
<<"bob_dropped_client_doesnt_create_duplicate_carbons_583@localhost/res1">>},
{<<"xmlns">>,<<"jabber:client">>}],
[{xmlel,<<"body">>,[],
[{xmlcdata,
<<"And pious action">>}]}]}]}]}]}]},
[{carboncopy_SUITE,
'-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4,
[{file,
"/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
{line,189}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_serv... pgsql_mnesia_26 / pgsql_mnesia / 66224da mssql_mnesia_26 / odbc_mssql_mnesia / 66224da |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/instrument #4315 +/- ##
======================================================
+ Coverage 81.99% 84.64% +2.65%
======================================================
Files 553 553
Lines 33867 33867
======================================================
+ Hits 27769 28667 +898
+ Misses 6098 5200 -898 ☔ View full report in Codecov by Sentry. |
66224da
to
b35227e
Compare
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / b35227e small_tests_25 / small_tests / b35227e small_tests_26 / small_tests / b35227e small_tests_26_arm64 / small_tests / b35227e dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b35227e ldap_mnesia_25 / ldap_mnesia / b35227e dynamic_domains_mysql_redis_26 / mysql_redis / b35227e ldap_mnesia_26 / ldap_mnesia / b35227e dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / b35227e pgsql_cets_26 / pgsql_cets / b35227e dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / b35227e internal_mnesia_26 / internal_mnesia / b35227e pgsql_mnesia_25 / pgsql_mnesia / b35227e mysql_redis_26 / mysql_redis / b35227e mssql_mnesia_26 / odbc_mssql_mnesia / b35227e pgsql_mnesia_26 / pgsql_mnesia / b35227e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🆗, thanks for fixing this issue.
Fixing mam_SUITE flaky tests, by changing the muc_prefs_cases init actions.