Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing muc_prefs_cases in mam_SUITE #4315

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

JanuszJakubiec
Copy link
Contributor

Fixing mam_SUITE flaky tests, by changing the muc_prefs_cases init actions.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 4, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 66224da
Reports root/ big
OK: 455 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0


small_tests_25 / small_tests / 66224da
Reports root / small


small_tests_26 / small_tests / 66224da
Reports root / small


small_tests_26_arm64 / small_tests / 66224da
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 66224da
Reports root/ big
OK: 2286 / Failed: 0 / User-skipped: 910 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 66224da
Reports root/ big
OK: 2286 / Failed: 0 / User-skipped: 910 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 66224da
Reports root/ big
OK: 4579 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 66224da
Reports root/ big
OK: 4612 / Failed: 0 / User-skipped: 106 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 66224da
Reports root/ big
OK: 4612 / Failed: 0 / User-skipped: 106 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 66224da
Reports root/ big
OK: 4513 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 66224da
Reports root/ big
OK: 5004 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 66224da
Reports root/ big
OK: 2428 / Failed: 0 / User-skipped: 768 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 66224da
Reports root/ big
OK: 4609 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 66224da
Reports root/ big
OK: 4984 / Failed: 1 / User-skipped: 134 / Auto-skipped: 0

carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_dropped_client_doesnt_create_duplicate_carbons_583@localhost">>},
         {<<"to">>,
        <<"alice_dropped_client_doesnt_create_duplicate_carbons_583@localhost/res2">>},
         {<<"xmlns">>,<<"jabber:client">>},
         {<<"type">>,<<"chat">>}],
        [{xmlel,<<"sent">>,
           [{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}],
           [{xmlel,<<"forwarded">>,
            [{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
            [{xmlel,<<"message">>,
               [{<<"from">>,
                 <<"alice_dropped_client_doesnt_create_duplicate_carbons_583@localhost/res1">>},
                {<<"type">>,<<"chat">>},
                {<<"to">>,
                 <<"bob_dropped_client_doesnt_create_duplicate_carbons_583@localhost/res1">>},
                {<<"xmlns">>,<<"jabber:client">>}],
               [{xmlel,<<"body">>,[],
                  [{xmlcdata,
                     <<"And pious action">>}]}]}]}]}]}]},
   [{carboncopy_SUITE,
      '-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4,
      [{file,
         "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
       {line,189}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_serv...

Report log


pgsql_mnesia_26 / pgsql_mnesia / 66224da
Reports root/ big
OK: 5004 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 66224da
Reports root/ big
OK: 5001 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.64%. Comparing base (6730fe5) to head (b35227e).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/instrument    #4315      +/-   ##
======================================================
+ Coverage               81.99%   84.64%   +2.65%     
======================================================
  Files                     553      553              
  Lines                   33867    33867              
======================================================
+ Hits                    27769    28667     +898     
+ Misses                   6098     5200     -898     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JanuszJakubiec JanuszJakubiec force-pushed the fixing-mam-flaky-tests branch from 66224da to b35227e Compare July 4, 2024 12:54
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 4, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / b35227e
Reports root/ big
OK: 455 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0


small_tests_25 / small_tests / b35227e
Reports root / small


small_tests_26 / small_tests / b35227e
Reports root / small


small_tests_26_arm64 / small_tests / b35227e
Reports root / small


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b35227e
Reports root/ big
OK: 4612 / Failed: 0 / User-skipped: 106 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / b35227e
Reports root/ big
OK: 2286 / Failed: 0 / User-skipped: 910 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / b35227e
Reports root/ big
OK: 4579 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / b35227e
Reports root/ big
OK: 2286 / Failed: 0 / User-skipped: 910 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / b35227e
Reports root/ big
OK: 4612 / Failed: 0 / User-skipped: 106 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / b35227e
Reports root/ big
OK: 4513 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / b35227e
Reports root/ big
OK: 4609 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / b35227e
Reports root/ big
OK: 2428 / Failed: 0 / User-skipped: 768 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / b35227e
Reports root/ big
OK: 5004 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / b35227e
Reports root/ big
OK: 4985 / Failed: 0 / User-skipped: 134 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / b35227e
Reports root/ big
OK: 5001 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / b35227e
Reports root/ big
OK: 5004 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0

@JanuszJakubiec JanuszJakubiec marked this pull request as ready for review July 4, 2024 13:41
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🆗, thanks for fixing this issue.

@chrzaszcz chrzaszcz merged commit 68da361 into feature/instrument Jul 4, 2024
3 of 4 checks passed
@chrzaszcz chrzaszcz deleted the fixing-mam-flaky-tests branch July 4, 2024 13:52
@jacekwegr jacekwegr added this to the 6.3.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants