Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin mssql docker version #4329

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Pin mssql docker version #4329

merged 1 commit into from
Jul 24, 2024

Conversation

arcusfelis
Copy link
Contributor

This PR addresses latest version failure with:

DB=mssql ./tools/setup-db.sh
/tmp/docker-setup-mssql.sh: line 8: /opt/mssql-tools/bin/sqlcmd: No such file or directory

MSSQL container got updated, it broke CI.

Proposed changes include:

  • similar to MySQL we pin MSSQL version inside tools/db-versions.sh.

We can add compatibility with the latest MSSQL in a separate PR as a separate story.

Latest version fails with
/tmp/docker-setup-mssql.sh: line 8: /opt/mssql-tools/bin/sqlcmd: No such file or directory
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 24, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 6ffa354
Reports root/ big
OK: 439 / Failed: 0 / User-skipped: 47 / Auto-skipped: 0


small_tests_25 / small_tests / 6ffa354
Reports root / small


small_tests_26 / small_tests / 6ffa354
Reports root / small


small_tests_26_arm64 / small_tests / 6ffa354
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 6ffa354
Reports root/ big
OK: 2337 / Failed: 0 / User-skipped: 905 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 6ffa354
Reports root/ big
OK: 2337 / Failed: 0 / User-skipped: 905 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6ffa354
Reports root/ big
OK: 4621 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 6ffa354
Reports root/ big
OK: 4588 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 6ffa354
Reports root/ big
OK: 4621 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 6ffa354
Reports root/ big
OK: 4618 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 6ffa354
Reports root/ big
OK: 4532 / Failed: 0 / User-skipped: 178 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 6ffa354
Reports root/ big
OK: 2477 / Failed: 0 / User-skipped: 765 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 6ffa354
Reports root/ big
OK: 5012 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 6ffa354
Reports root/ big
OK: 4991 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 6ffa354
Reports root/ big
OK: 5012 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 6ffa354
Reports root/ big
OK: 5009 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.35%. Comparing base (65aadba) to head (6ffa354).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4329      +/-   ##
==========================================
+ Coverage   84.32%   84.35%   +0.02%     
==========================================
  Files         553      553              
  Lines       33730    33730              
==========================================
+ Hits        28444    28453       +9     
+ Misses       5286     5277       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arcusfelis arcusfelis marked this pull request as ready for review July 24, 2024 09:36
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix!

@chrzaszcz chrzaszcz merged commit ed459a8 into master Jul 24, 2024
4 checks passed
@chrzaszcz chrzaszcz deleted the pin-mssql-docker-image branch July 24, 2024 09:38
@jacekwegr jacekwegr added this to the 6.3.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants