Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Erlang27 patches #4334

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Some Erlang27 patches #4334

merged 4 commits into from
Jul 25, 2024

Conversation

arcusfelis
Copy link
Contributor

This PR addresses "Compilation errors on Erlang 27".

Proposed changes include:

  • Update port compiler version
  • use format_status/1
  • syntax fix
  • unused get_activity call in mod_muc

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 25, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / e4b3560
Reports root/ big
OK: 439 / Failed: 0 / User-skipped: 47 / Auto-skipped: 0


small_tests_25 / small_tests / e4b3560
Reports root / small


small_tests_26 / small_tests / e4b3560
Reports root / small


small_tests_26_arm64 / small_tests / e4b3560
Reports root / small


ldap_mnesia_26 / ldap_mnesia / e4b3560
Reports root/ big
OK: 2337 / Failed: 0 / User-skipped: 905 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / e4b3560
Reports root/ big
OK: 2337 / Failed: 0 / User-skipped: 905 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / e4b3560
Reports root/ big
OK: 4621 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / e4b3560
Reports root/ big
OK: 2477 / Failed: 0 / User-skipped: 765 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / e4b3560
Reports root/ big
OK: 4621 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / e4b3560
Reports root/ big
OK: 4588 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / e4b3560
Reports root/ big
OK: 4532 / Failed: 0 / User-skipped: 178 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / e4b3560
Reports root/ big
OK: 5012 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / e4b3560
Reports root/ big
OK: 4618 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / e4b3560
Reports root/ big
OK: 5012 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / e4b3560
Reports root/ big
OK: 4991 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / e4b3560
Reports root/ big
OK: 5009 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


small_tests_26 / small_tests / e4b3560
Reports root / small


small_tests_26 / small_tests / e4b3560
Reports root / small

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.33%. Comparing base (7dbbbdb) to head (8872f4a).
Report is 5 commits behind head on master.

Files Patch % Lines
src/async_pools/mongoose_aggregator_worker.erl 0.00% 1 Missing ⚠️
src/async_pools/mongoose_batch_worker.erl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4334      +/-   ##
==========================================
- Coverage   84.34%   84.33%   -0.01%     
==========================================
  Files         553      553              
  Lines       33730    33729       -1     
==========================================
- Hits        28449    28445       -4     
- Misses       5281     5284       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arcusfelis arcusfelis marked this pull request as ready for review July 25, 2024 13:40
@arcusfelis arcusfelis changed the title Erlang27 patches Some Erlang27 patches Jul 25, 2024
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 25, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 8872f4a
Reports root/ big
OK: 439 / Failed: 0 / User-skipped: 47 / Auto-skipped: 0


small_tests_25 / small_tests / 8872f4a
Reports root / small


small_tests_26 / small_tests / 8872f4a
Reports root / small


small_tests_26_arm64 / small_tests / 8872f4a
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 8872f4a
Reports root/ big
OK: 2337 / Failed: 0 / User-skipped: 905 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 8872f4a
Reports root/ big
OK: 2337 / Failed: 0 / User-skipped: 905 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 8872f4a
Reports root/ big
OK: 4588 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8872f4a
Reports root/ big
OK: 4621 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 8872f4a
Reports root/ big
OK: 2477 / Failed: 0 / User-skipped: 765 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 8872f4a
Reports root/ big
OK: 4532 / Failed: 0 / User-skipped: 178 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 8872f4a
Reports root/ big
OK: 4618 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 8872f4a
Reports root/ big
OK: 5012 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 8872f4a
Reports root/ big
OK: 5012 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 8872f4a
Reports root/ big
OK: 4991 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 8872f4a
Reports root/ big
OK: 5003 / Failed: 1 / User-skipped: 121 / Auto-skipped: 5

bosh_SUITE:essential:accept_higher_hold_value
{error,
  {{assertEqual,
     [{module,bosh_SUITE},
      {line,261},
      {expression,"get_bosh_sessions ( )"},
      {expected,[]},
      {value,
        [{bosh_session,<<"486026eaabc4a1e5b29572cc149c5591e1dcf128">>,
           <10243.10208.0>}]}]},
   [{bosh_SUITE,accept_higher_hold_value,1,
      [{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
       {line,261}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1302}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1234}]}]}}

Report log


mssql_mnesia_26 / odbc_mssql_mnesia / 8872f4a
Reports root/ big
OK: 5009 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

Copy link
Contributor

@gustawlippa gustawlippa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, looks good! 👍

@gustawlippa gustawlippa merged commit 343838d into master Jul 25, 2024
3 of 4 checks passed
@gustawlippa gustawlippa deleted the erlang27-patches branch July 25, 2024 15:24
@jacekwegr jacekwegr added this to the 6.3.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants