-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument async_pools
#4337
Instrument async_pools
#4337
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/instrument #4337 +/- ##
======================================================
+ Coverage 84.10% 84.46% +0.36%
======================================================
Files 551 551
Lines 33853 33840 -13
======================================================
+ Hits 28471 28582 +111
+ Misses 5382 5258 -124 ☔ View full report in Codecov by Sentry. |
30bdbcd
to
60e1b6f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
0f544a8
to
3c21c8c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This comment was marked as outdated.
This comment was marked as outdated.
925915a
to
72c3de4
Compare
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 72c3de4 small_tests_25 / small_tests / 72c3de4 small_tests_26 / small_tests / 72c3de4 small_tests_26_arm64 / small_tests / 72c3de4 ldap_mnesia_25 / ldap_mnesia / 72c3de4 dynamic_domains_mysql_redis_26 / mysql_redis / 72c3de4 ldap_mnesia_26 / ldap_mnesia / 72c3de4 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 72c3de4 internal_mnesia_26 / internal_mnesia / 72c3de4 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 72c3de4 pgsql_cets_26 / pgsql_cets / 72c3de4 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 72c3de4 mysql_redis_26 / mysql_redis / 72c3de4 pgsql_mnesia_25 / pgsql_mnesia / 72c3de4 pgsql_mnesia_26 / pgsql_mnesia / 72c3de4 mssql_mnesia_26 / odbc_mssql_mnesia / 72c3de4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now 👍
This PR updates the metrics in
async_pools
to usemongoose_instrument
. Events are tested in separate suites due to the need for specific types of pools for testing. That's why one type of event is tested inmod_inbox
and the other one inmod_mam
.Some of the tests do not check the exact number of events because the number of events can depend on how long a given operation takes. For example,
async_pool_flush.timed
can be executed a different number of times depending on how many messages are flushed in a given time interval.