Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument async_pools #4337

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Instrument async_pools #4337

merged 8 commits into from
Jul 31, 2024

Conversation

jacekwegr
Copy link
Collaborator

@jacekwegr jacekwegr commented Jul 25, 2024

This PR updates the metrics in async_pools to use mongoose_instrument. Events are tested in separate suites due to the need for specific types of pools for testing. That's why one type of event is tested in mod_inbox and the other one in mod_mam.

Some of the tests do not check the exact number of events because the number of events can depend on how long a given operation takes. For example, async_pool_flush.timed can be executed a different number of times depending on how many messages are flushed in a given time interval.

@mongoose-im

This comment was marked as outdated.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.46%. Comparing base (b07999b) to head (72c3de4).
Report is 5 commits behind head on feature/instrument.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/instrument    #4337      +/-   ##
======================================================
+ Coverage               84.10%   84.46%   +0.36%     
======================================================
  Files                     551      551              
  Lines                   33853    33840      -13     
======================================================
+ Hits                    28471    28582     +111     
+ Misses                   5382     5258     -124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacekwegr jacekwegr force-pushed the instrument/async-pools branch from 30bdbcd to 60e1b6f Compare July 25, 2024 14:24
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@jacekwegr jacekwegr force-pushed the instrument/async-pools branch from 0f544a8 to 3c21c8c Compare July 26, 2024 13:01
@mongoose-im

This comment was marked as outdated.

@jacekwegr jacekwegr marked this pull request as ready for review July 26, 2024 13:59
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

test/batches_SUITE.erl Outdated Show resolved Hide resolved
@mongoose-im

This comment was marked as outdated.

@jacekwegr jacekwegr force-pushed the instrument/async-pools branch from 925915a to 72c3de4 Compare July 30, 2024 11:20
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 30, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 72c3de4
Reports root/ big
OK: 457 / Failed: 0 / User-skipped: 49 / Auto-skipped: 0


small_tests_25 / small_tests / 72c3de4
Reports root / small


small_tests_26 / small_tests / 72c3de4
Reports root / small


small_tests_26_arm64 / small_tests / 72c3de4
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 72c3de4
Reports root/ big
OK: 2341 / Failed: 0 / User-skipped: 910 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 72c3de4
Reports root/ big
OK: 4658 / Failed: 0 / User-skipped: 151 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 72c3de4
Reports root/ big
OK: 2341 / Failed: 0 / User-skipped: 910 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 72c3de4
Reports root/ big
OK: 4691 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 72c3de4
Reports root/ big
OK: 2483 / Failed: 0 / User-skipped: 768 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 72c3de4
Reports root/ big
OK: 4691 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 72c3de4
Reports root/ big
OK: 4584 / Failed: 0 / User-skipped: 185 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 72c3de4
Reports root/ big
OK: 4688 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 72c3de4
Reports root/ big
OK: 5063 / Failed: 0 / User-skipped: 146 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 72c3de4
Reports root/ big
OK: 5082 / Failed: 0 / User-skipped: 127 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 72c3de4
Reports root/ big
OK: 5082 / Failed: 0 / User-skipped: 127 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 72c3de4
Reports root/ big
OK: 5079 / Failed: 0 / User-skipped: 130 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now 👍

test/batches_SUITE.erl Outdated Show resolved Hide resolved
@chrzaszcz chrzaszcz merged commit 2d51539 into feature/instrument Jul 31, 2024
4 checks passed
@chrzaszcz chrzaszcz deleted the instrument/async-pools branch July 31, 2024 07:05
@jacekwegr jacekwegr added this to the 6.3.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants