Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix list rendering in MUC docs #4388

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fix list rendering in MUC docs #4388

merged 1 commit into from
Oct 29, 2024

Conversation

gustawlippa
Copy link
Contributor

Before the changes, the list was not rendered properly:

image

With this PR's change, it is fixed:

image

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 29, 2024 •
edited
Loading

elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 8d80b6d
Reports root/ big
OK: 473 / Failed: 0 / User-skipped: 49 / Auto-skipped: 0

small_tests_27 / small_tests / 8d80b6d
Reports root / small

small_tests_26 / small_tests / 8d80b6d
Reports root / small

small_tests_27_arm64 / small_tests / 8d80b6d
Reports root / small

ldap_mnesia_27 / ldap_mnesia / 8d80b6d
Reports root/ big
OK: 2346 / Failed: 0 / User-skipped: 910 / Auto-skipped: 0

ldap_mnesia_26 / ldap_mnesia / 8d80b6d
Reports root/ big
OK: 2346 / Failed: 0 / User-skipped: 910 / Auto-skipped: 0

dynamic_domains_mysql_redis_27 / mysql_redis / 8d80b6d
Reports root/ big
OK: 4717 / Failed: 1 / User-skipped: 152 / Auto-skipped: 0

carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons 
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_dropped_client_doesnt_create_duplicate_carbons_571@domain.example.com">>},
         {<<"to">>,
        <<"alice_dropped_client_doesnt_create_duplicate_carbons_571@domain.example.com/res2">>},
         {<<"xmlns">>,<<"jabber:client">>},
         {<<"type">>,<<"chat">>}],
        [{xmlel,<<"sent">>,
           [{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}],
           [{xmlel,<<"forwarded">>,
            [{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
            [{xmlel,<<"message">>,
               [{<<"from">>,
                 <<"alice_dropped_client_doesnt_create_duplicate_carbons_571@domain.example.com/res1">>},
                {<<"type">>,<<"chat">>},
                {<<"to">>,
                 <<"bob_dropped_client_doesnt_create_duplicate_carbons_571@domain.example.com/res1">>},
                {<<"xmlns">>,<<"jabber:client">>}],
               [{xmlel,<<"body">>,[],
                  [{xmlcdata,
                     <<"And pious action">>}]}]}]}]}]}]},
   [{carboncopy_SUITE,
      '-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4,
      [{file,
         "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
       {line,189}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
    {test_server,run_test_c...

Report log

dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 8d80b6d
Reports root/ big
OK: 4751 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0

internal_mnesia_27 / internal_mnesia / 8d80b6d
Reports root/ big
OK: 2488 / Failed: 0 / User-skipped: 768 / Auto-skipped: 0

pgsql_cets_27 / pgsql_cets / 8d80b6d
Reports root/ big
OK: 4628 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 8d80b6d
Reports root/ big
OK: 4751 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0

cockroachdb_cets_27 / cockroachdb_cets / 8d80b6d
Reports root/ big
OK: 4622 / Failed: 3 / User-skipped: 186 / Auto-skipped: 3

pubsub_SUITE:dag+basic:discover_nodes_test 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alice_discover_nodes_test_2876@localhost/res1">>,
          escalus_tcp,<0.74413.0>,
          [{event_manager,<0.74337.0>},
           {server,<<"localhost">>},
           {username,<<"alicE_discover_nodes_test_2876">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.74337.0>},
            {server,<<"localhost">>},
            {username,<<"alicE_discover_nodes_test_2876">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alice_discover_nodes_test_2876">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_discover_nodes_test_2876">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"09ab8b8f7e1f0c88">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,433}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,424}]},
     {pubsub_SUITE,'-discover_nodes_test/1-fun-0-',2,
   ...

Report log

pubsub_SUITE:dag+node_config:set_configuration_test 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alice_set_configuration_test_2888@localhost/res1">>,
          escalus_tcp,<0.74617.0>,
          [{event_manager,<0.74570.0>},
           {server,<<"localhost">>},
           {username,<<"alicE_set_configuration_test_2888">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.74570.0>},
            {server,<<"localhost">>},
            {username,<<"alicE_set_configuration_test_2888">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alice_set_configuration_test_2888">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_set_configuration_test_2888">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"aec90065d336a1be">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,433}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,424}]},
     {pubsub_SUITE,'-set_configuration_tes...

Report log

pubsub_SUITE:tree+hometree_specific:can_create_node_with_existing_parent_path 
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,444}]},
     {pubsub_tools,receive_response,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,434}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,424}]},
     {pubsub_SUITE,'-can_create_node_with_existing_parent_path/1-fun-0-',
             1,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
            {line,1820}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log

dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 8d80b6d
Reports root/ big
OK: 4748 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0

pgsql_mnesia_26 / pgsql_mnesia / 8d80b6d
Reports root/ big
OK: 5142 / Failed: 0 / User-skipped: 128 / Auto-skipped: 0

mysql_redis_27 / mysql_redis / 8d80b6d
Reports root/ big
OK: 5123 / Failed: 0 / User-skipped: 147 / Auto-skipped: 0

pgsql_mnesia_27 / pgsql_mnesia / 8d80b6d
Reports root/ big
OK: 5142 / Failed: 0 / User-skipped: 128 / Auto-skipped: 0

mssql_mnesia_27 / odbc_mssql_mnesia / 8d80b6d
Reports root/ big
OK: 5139 / Failed: 0 / User-skipped: 131 / Auto-skipped: 0

dynamic_domains_mysql_redis_27 / mysql_redis / 8d80b6d
Reports root/ big
OK: 4718 / Failed: 0 / User-skipped: 152 / Auto-skipped: 0

cockroachdb_cets_27 / cockroachdb_cets / 8d80b6d
Reports root/ big
OK: 4626 / Failed: 2 / User-skipped: 186 / Auto-skipped: 0

pubsub_SUITE:dag+node_config:set_configuration_errors_test 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_set_configuration_errors_test_2833@localhost/res1">>,
          escalus_tcp,<0.74494.0>,
          [{event_manager,<0.74452.0>},
           {server,<<"localhost">>},
           {username,<<"alicE_set_configuration_errors_test_2833">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.74452.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_set_configuration_errors_test_2833">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alice_set_configuration_errors_test_2833">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_set_configuration_errors_test_2833">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"8a3719258a34d429">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,433}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
   ...

Report log

pubsub_SUITE:dag+manage_subscriptions:modify_node_subscriptions_test 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_modify_node_subscriptions_test_2846@localhost/res1">>,
          escalus_tcp,<0.74665.0>,
          [{event_manager,<0.74646.0>},
           {server,<<"localhost">>},
           {username,<<"alicE_modify_node_subscriptions_test_2846">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.74646.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_modify_node_subscriptions_test_2846">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alice_modify_node_subscriptions_test_2846">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_modify_node_subscriptions_test_2846">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"4eb9f77a6bd0e38b">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,433}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"}...

Report log

cockroachdb_cets_27 / cockroachdb_cets / 8d80b6d
Reports root/ big
OK: 4627 / Failed: 1 / User-skipped: 186 / Auto-skipped: 0

pubsub_SUITE:dag+node_config:disable_notifications_test 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_disable_notifications_test_2862@localhost/res1">>,
          escalus_tcp,<0.74651.0>,
          [{event_manager,<0.74592.0>},
           {server,<<"localhost">>},
           {username,<<"alicE_disable_notifications_test_2862">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.74592.0>},
            {server,<<"localhost">>},
            {username,<<"alicE_disable_notifications_test_2862">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alice_disable_notifications_test_2862">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_disable_notifications_test_2862">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"64a29017701ec1ff">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,433}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,424}]},
     {escal...

Report log

cockroachdb_cets_27 / cockroachdb_cets / 8d80b6d
Reports root/ big
OK: 4628 / Failed: 0 / User-skipped: 186 / Auto-skipped: 0

@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.29%. Comparing base (d5584c9) to head (8d80b6d).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4388      +/-   ##
==========================================
+ Coverage   85.25%   85.29%   +0.03%     
==========================================
  Files         550      550              
  Lines       33845    33845              
==========================================
+ Hits        28855    28867      +12     
+ Misses       4990     4978      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chrzaszcz
chrzaszcz approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@chrzaszcz chrzaszcz merged commit 8980ead into master Oct 29, 2024
4 checks passed
@chrzaszcz chrzaszcz deleted the muc-docs-fix branch October 29, 2024 13:35
@jacekwegr jacekwegr added this to the 6.3.1 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrzaszcz chrzaszcz chrzaszcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@gustawlippa @mongoose-im @chrzaszcz @jacekwegr