Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --rerun-big-tests not working with cth_validate_nodes #4431

Merged
merged 2 commits into from
Dec 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/common/distributed_helper.erl
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ get_node_keys() ->
[NodeKey || {NodeKey, _Opts} <- ct:get_config(hosts)];
EnvValue -> %% EnvValue examples are "mim" or "mim mim2"
BinHosts = binary:split(iolist_to_binary(EnvValue), <<" ">>, [global]),
[binary_to_atom(Node, utf8) || Node <- BinHosts]
[binary_to_atom(Node, utf8) || Node <- BinHosts, Node =/= <<>>]
end.

validate_node(NodeKey) ->
Expand Down
6 changes: 3 additions & 3 deletions tools/test-runner.sh
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,12 @@ Script examples:
Sets dev-nodes and test-hosts to empty lists
Reruns mam_SUITE

./tools/test-runner.sh --skip-small-tests --skip-start-nodes --skip-validate-nodes -- connect
Continues test execution even if MongooseIM is not running on all nodes

./tools/test-runner.sh --rerun-big-tests -- mam
The same command as above

./tools/test-runner.sh --skip-small-tests --skip-start-nodes --skip-validate-nodes -- connect
Continues test execution even if MongooseIM is not running on all nodes

./tools/test-runner.sh --help --examples --colors | more
Display help using "more" command
END
Expand Down