Codify ejabberd_loglevel behaviour in tests and allow for changing logging path #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit d091cc919f0f505a6fa8e9273b9a2f4134e3cd63)
There are two sources of logs in a running MongooseIM system: - `bin/mongooseim` - the script - logs it generates go to `erlang.log` and `run_erl.log` files, - MongooseIM itself, logging internal messages through lager - the files in this case are `ejabberd.log` and `crash.log`. Since these two sources are configured in different places, the only way to keep the config in sync is to either update both at the same time or make them templates.
|
travis is using test branch |
|
Ready to merge!!111 |
ppikula
added a commit
that referenced
this pull request
Aug 19, 2015
Codify ejabberd_loglevel behaviour in tests and allow for changing logging path
|
Great code, man! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
ejabberd_loglevel_SUITEwhich testsejabberd_loglevelexternal API,ejabberd_app:get_log_pathandejabberd_loglevel:log_path,app.configthe definitive place for configuring MongooseIM logging - you can use any backends available and use multiple backends of the same type - the hardcoded assumptions about backend types are lifted,etc/app.configandbin/mongooseimtemplates so that the log path can be set uniformly for logs from within the server as well as logs created by the runner script (i.e.bin/mongooseim).Solves #352 and partially addresses #432.