Fix create MUC room function #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about this comment? |
|
I've just checked both use cases of this function: vCard search and room configuration. Both works without this case clause. Psi's xml console prints the correct form type. |
michalwski
added a commit
that referenced
this pull request
Oct 30, 2015
Fix create MUC room function
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #376
The problem was the initial_state function, which wasn't handling the case in which the create-room presence had more than one
<x>subelements. To be more specific, it was crashing when the first<x>subelement wasn't exactly<x xmlns="http://jabber.org/protocol/muc"/>or the presence had no children.