Self imports are not working

[piranna]

When doing a self-import (at least for scoped packages) I get a n/no-missing-import error. I'm doing it for my project tests files, and when debugging it, I've traced it down to

eslint-plugin-n/lib/converted-esm/import-meta-resolve.js

Lines 41 to 62 in 2ce285d

	// node_modules/import-meta-resolve/lib/package-json-reader.js
	var import_fs = __toESM(require("fs"), 1);
	var import_path = __toESM(require("path"), 1);
	var reader = { read };
	var package_json_reader_default = reader;
	function read(jsonPath) {
	return find(import_path.default.dirname(jsonPath));
	}
	function find(dir) {
	try {
	const string = import_fs.default.readFileSync(import_path.default.toNamespacedPath(import_path.default.join(dir, "package.json")), "utf8");
	return { string };
	} catch (error) {
	if (error.code === "ENOENT") {
	const parent = import_path.default.dirname(dir);
	if (dir !== parent)
	return find(parent);
	return { string: void 0 };
	}
	throw error;
	}
	}

, where for an input file it's looking it's package.json file and returning its contend when called from

eslint-plugin-n/lib/converted-esm/import-meta-resolve.js

Line 303 in 2ce285d

const source = package_json_reader_default.read(path4).string;

. Problem is that at

eslint-plugin-n/lib/converted-esm/import-meta-resolve.js

Lines 683 to 688 in 2ce285d

	const packageConfig2 = getPackageConfig(packageJsonPath, specifier, base);
	if (packageConfig2.exports !== void 0 && packageConfig2.exports !== null)
	return packageExportsResolve(packageJsonUrl, packageSubpath, packageConfig2, base, conditions).resolved;
	if (packageSubpath === ".")
	return legacyMainResolve(packageJsonUrl, packageConfig2, base);
	return new import_url2.URL(packageSubpath, packageJsonUrl);

is being used with the original requested path instead of the package root one, so file resolution fails.

On the other hand, I've found that in fact this file is a transpiled one, probably generated with webpack or something like that, so it's ugly to work with it. Original import-meta-resolve exists, and it's updated from two months ago, so why don't use it instead using a big blob?

[piranna]

Ok, just by commenting this three lines

      // const parent = import_path.default.dirname(dir);
      // if (dir !== parent)
      //   return find(parent);

that in fact doesn't exists in upstream it gets fixed. Not sure if create a PR removing them, or fully replacing the import-meta-resolve package...

[piranna]

Properly fixed at #87

[aladdin-add]

it should be has been fixed in v16.0.0. just leave it open as it still needs some tests.

[piranna]

So far version 16.0.2 seems to be working on my side.

[piranna]

I think we can close this now.

[voxpelli]

Closed before reading that @aladdin-add wanted to keep it open to add some tests, sorry @aladdin-add 🙏

[scagood]

I want to be very careful to not break this in #139

Can you provide a simple example of this? (I want to add a test!)

I assume its something like:

// package.json
{ "name": "@org/pkg", "main": "./index.js" }

// index.js
export function something() {
  // magic
}

// some.test.js
import { something } from '@org/pkg';

[piranna]

Yes, self-imports works like that.