Update: curly multi-or-nest flagging semis on next line (fixes #12370)

[cherryblossom000]

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

Fixes #12370.

What changes did you make? (Give an overview)

I made the isOneLiner function use the last token excluding the semicolon instead of just the last token, like the isCollapsedOneLiner function, which stopped multi-or-nest flagging code like the following as one line.

console.log('foo')
;

Is there anything you'd like reviewers to focus on?

No.

[mdjermanovic]

Thanks for the PR! Marking as accepted, as the issue is accepted.

Can this change also produce more warnings? For example, in some rare situations like this:

/* eslint curly: ["error", "multi-or-nest"] */

if (foo) {
  bar()
;
}

[cherryblossom000]

Yes, this change does produce those warnings. I added more tests for that.

[mdjermanovic]

Thanks for the detailed tests!

Could you please also change the commit message and PR title to start with "Update:" instead of "Fix:"? It's because the change can generate more warning and thus requires a semver-minor release.

[mdjermanovic]

One small detail I missed before, sorry - 'curly' is the rule's name and should start with a lowercase in commit message and PR title.

Other than that, everything else LGTM!

[mdjermanovic]

One small detail I missed before, sorry - 'curly' is the rule's name and should start with a lowercase in commit message and PR title.

Other than that, everything else LGTM!

Actually, please disregard the 'commit message' part.

It's okay to change just the PR title because this PR has more than 1 commit, so the PR title will be used as the merge commit message.

[mdjermanovic]

LGTM, thanks!

[kaicataldo]

LGTM. Thanks for contributing!

[cherryblossom000]

@kaicataldo Sorry, ignore the review request. That was accidental.

[kaicataldo]

Thanks for contributing to ESLint!