feat: Avoid dirname for built-in configs.

[daidodo]

Load eslint:recommended and eslint:all configs via import instead file paths.

Fixes: eslint/eslint#15575

[mdjermanovic]

I think we should set filePath: "" for clarity in logs. Otherwise, it would be filePath of the config where the extends was.

[mdjermanovic]

LGTM, thanks!

I've verified that this works well both with eslint/eslint current main branch (which is important for backward compatibility), and with changes from eslint/eslint#15616.

[nzakas]

Can we add in a check here to make sure getEslintRecommendedConfig is a function, and throw an error if not? I can picture this being difficult to debug if someone passes a nonfunction accidentally.

[daidodo]

Done.

[nzakas]

Same for getEslintAllConfig

[daidodo]

Done.

[nzakas]

LGTM. Thanks!

[daidodo]

Thanks for the approvals!

May I have write access to the repository to merge the changes?

[daidodo]

Thanks for the approvals!

May I have write access to the repository to merge the changes?

@nzakas @mdjermanovic

[mdjermanovic]

@daidodo thanks for addressing all reviews, we'll merge the changes.

@nzakas what do you think about these steps:

1. Make 2 PRs in eslint/eslint: one with, one without changes from eslint/eslint#15616. Both use @eslint/eslintrc from this branch. If the checks are passing, it confirms that these changes support both the new functions and the old string paths (the latter is important for backwards compatibility). These are "do not merge" PRs, just to run checks in order to see if we can proceed with the next step.
2. Merge this PR.
3. On the release day, release @eslint/eslintrc.
4. Update package.json in eslint/eslint to use the new @eslint/eslintrc, and merge that change.
5. Close-reopen eslint/eslint#15616 to run checks with the new @eslint/eslintrc. Merge if the checks are passing.
6. Release eslint.

[nzakas]

That sounds like a solid plan to me. 👍

[mdjermanovic]

All checks on eslint/eslint#15641 and eslint/eslint#15643 are passing (Step 1), so I'm merging this now (Step 2).

Steps 3-6 will be later today.

[mdjermanovic]

All steps are done. These changes are released in ESLint v8.10.0 & @eslint/eslintrc v1.2.0