Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Configuring core options in Config Files #22

Merged
merged 18 commits into from
Aug 6, 2019

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented May 12, 2019

Rendered RFC

Summary

This RFC adds several properties into config files to configure core options. People can use config files (including shareable configs!) instead of CLI options in order to configure some linter behavior.

Related Issues

@mysticatea mysticatea added feature Initial Commenting This RFC is in the initial feedback stage labels May 12, 2019
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this RFC! I left a few thoughts.

designs/2019-linter-options/README.md Outdated Show resolved Hide resolved
designs/2019-linter-options/README.md Outdated Show resolved Hide resolved
designs/2019-linter-options/README.md Outdated Show resolved Hide resolved
designs/2019-linter-options/README.md Outdated Show resolved Hide resolved
designs/2019-linter-options/README.md Outdated Show resolved Hide resolved
@mysticatea mysticatea changed the title New: The linterOptions property in Config Files New: The coreOptions property in Config Files May 12, 2019
@mysticatea
Copy link
Member Author

@not-an-aardvark Thank you for your feedback. I updated this RFC. I think it has addressed your concerns.

@aladdin-add
Copy link
Member

aladdin-add commented Jun 7, 2019

image

the rendered link seems broken.

@mysticatea
Copy link
Member Author

Oh, thank you. I have fixed the link.

@mysticatea mysticatea changed the title New: The coreOptions property in Config Files New: Configuring core options in Config Files Jun 17, 2019
@mysticatea
Copy link
Member Author

I have updated this RFC for some feedback.

  • Move coreOptions.* properties to top-level.
  • Disallow ignorePatterns in overrides entries to avoid confusion with excludedFiles property.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns from me at this point.

@mysticatea
Copy link
Member Author

@kaicataldo @not-an-aardvark Does the latest update solve your concerns? If so, I will move this RFC to the final commenting.

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about renaming property names, but otherwise this LGTM. Thanks for working on this!

designs/2019-core-options/README.md Outdated Show resolved Hide resolved
designs/2019-core-options/README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Final Commenting This RFC is in the final week of commenting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants