Accessing cwd from formatters
#57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 5, 2020
nzakas
approved these changes
Jun 8, 2020
nzakas
changed the title
cwd from formatterscwd from formatters
|
@mysticatea it has been 21 days and this already has two approvals. You can choose to move this into final commenting if you want. |
mysticatea
added
Final Commenting
|
Thank you. I moved this to final commenting. |
btmills
approved these changes
Jul 16, 2020
|
@mdjermanovic just wanted to double check that you don't have any comments on this? We're ready to merge if you're all set. |
|
Looks like we have consensus, so merging. |
btmills
pushed a commit
to eslint/eslint
that referenced
this pull request
Nov 21, 2021
btmills
pushed a commit
to eslint/eslint
that referenced
this pull request
Nov 27, 2021
mdjermanovic
added a commit
to eslint/eslint
that referenced
this pull request
Nov 30, 2021
* chore: Make fixture test assertions more explicit I need to add another formatter to this directory that will shift all of these results, so I'm making these assertions more explicit so it's obvious why a seemingly-unrelated change will cause these to fail. * Update: pass cwd to formatters (refs eslint/rfcs#57) * chore: Update tests using formatter fixture dir * update docs * Fix link to ESLint API docs Co-authored-by: Milos Djermanovic <[email protected]> * Remove unused docs.category rule meta field Co-authored-by: Milos Djermanovic <[email protected]> * Fix typo in docs note Co-authored-by: Milos Djermanovic <[email protected]> Co-authored-by: Brandon Mills <[email protected]> Co-authored-by: Brandon Mills <[email protected]> Co-authored-by: Milos Djermanovic <[email protected]>
This was referenced Dec 6, 2021
This was referenced Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This RFC lets formatters can access
cwdin order to make relative paths or do something like.Related Issues