Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to github actions and cleanup #93

Merged
merged 8 commits into from
Feb 24, 2021
Merged

Migration to github actions and cleanup #93

merged 8 commits into from
Feb 24, 2021

Conversation

TheMcMurder
Copy link
Contributor

  • Change default branch to main
  • Update branch protection settings
  • Replace yarn with pnpm
  • Remove travis.yml
  • Remove travis from readme
  • Copy GitHub folder, including workflows and funding
  • Upgrade husky to v5
  • Remove esm-bundle-scripts in favor of independent installations

@TheMcMurder
Copy link
Contributor Author

TheMcMurder commented Feb 24, 2021

So I went down a rabbit hole on this one.

  • Turns out there was a breaking change in @rollup/[email protected] that made it so this wouldn't work anymore. For more details on this change check out this PR
  • esm-bundle-scripts gave us @rollup/[email protected] so it worked in yarn/npm through dependency flattenting but in pnpm it failed unless I pinned to that version of @rollup/pulgin-commonjs.
  • I didn't want to be stuck on an old version of @rollup/plugin-commonjs so I created a src/... file to re-export the modules.
  • I didn't want to have to test every single export manually so I wrote some tests that iterate over CJS methods and will fail if something is missing in ESM bundle. This should catch any future API changes automatically.

Copy link
Contributor

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TheMcMurder TheMcMurder merged commit 5190dee into main Feb 24, 2021
@kodiakhq kodiakhq bot deleted the migration branch February 24, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants