Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency styled-components to v5.2.0 #4

Merged
merged 7 commits into from
Sep 9, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 4, 2020

This PR contains the following updates:

Package Type Update Change
styled-components (source) devDependencies minor 5.1.1 -> 5.2.0

Release Notes

styled-components/styled-components

v5.2.0

Compare Source

  • Make sure StyleSheetManager renders all styles in iframe / child windows (see #​3159) thanks @​eramdam!

  • Rework how components self-reference in extension scenarios (see #​3236); should fix a bunch of subtle bugs around patterns like & + &

  • Fix keyframes not receiving a modified stylis instance when using something like stylis-plugin-rtl (see #​3239)

  • Big performance gain for components using style objects (see #​3239)

  • We no longer emit dynamic classNames for empty rulesets, so some className churn may occur in snapshots

  • Preallocate global style placement to ensure cGS is consistently inserted at the top of the stylesheet; note that this is done in runtime order so, if you have multiple cGS that have overlapping styles, ensure they're defined in code in the sequence you would want them injected (see #​3239)

  • Add "engines" to package.json (currently set to Node 10, the oldest supported LTS distribution) (see #​3201) thanks @​MichaelDeBoey!

Finally, special thanks to @​willheslam for testing and some last minute fixes on this release!


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@joeldenning
Copy link
Contributor

@filoxo looks like the 5.2.0 release references window directly whereas previous versions did not?

@filoxo
Copy link
Contributor

filoxo commented Sep 7, 2020

Weird. I'm fairly certain that previous versions relied on window but I think that the detection logic for determining the platform may have changed. I see in their changes that they have a serverConfig that is explicitly setting window: undefined.

@kodiakhq kodiakhq bot merged commit 5fe35eb into master Sep 9, 2020
@kodiakhq kodiakhq bot deleted the renovate/styled-components-5.x branch September 9, 2020 05:35
@filoxo
Copy link
Contributor

filoxo commented Sep 9, 2020

I think that the issue was that the previous version of styled-component's esm browser bundle had checks in place for window references. This new version had more aggressive optimizations for the browser and removed the window checks, and so loading it into a node environment caused it to fail. I created a separate builds for browser esm and node esm following styled-components' convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants