-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump protobuf requirement to >=4 #1007
Conversation
Most downstream is using protobuf 5 and protobuf only supports one version behind.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1007 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 2681 2681
=========================================
Hits 2681 2681 ☔ View full report in Codecov by Sentry. |
WalkthroughThe pull request includes an update to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant System
User->>System: Request to install dependencies
System->>System: Read requirements.txt
System->>System: Install protobuf >=4
System->>User: Dependencies installed
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
CodSpeed Performance ReportMerging #1007 will not alter performanceComparing Summary
|
Most downstream is using protobuf 5 and protobuf only supports one version behind.
As a result we see broken cases like home-assistant/core#129052 home-assistant/core#130169