Dont call subscription callback when we want single state only

[jesserockz]

Forgot this should be an else.

Didnt realise until I decided to add some logging to ha core that it was calling both still.

[coderabbitai]

Walkthrough

The changes involve a modification in the control flow of the on_subscribe_home_assistant_state_response function in the aioesphomeapi/client_callbacks.py file, introducing an else clause to control when on_state_sub is called. Additionally, the tests/test_client.py file has been updated to enhance the test_subscribe_home_assistant_states function by adding a new callback for capturing requests.

Changes

Files	Change Summary
aioesphomeapi/client_callbacks.py	Modified control flow in on_subscribe_home_assistant_state_response to include an else clause for calling on_state_sub based on updated conditions.
tests/test_client.py	Enhanced test_subscribe_home_assistant_states by adding on_request_home_assistant_state callback to capture requests and updated the subscription mechanism and assertions accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant HomeAssistant

    Client->>HomeAssistant: Subscribe to state
    HomeAssistant-->>Client: State response received
    alt on_state_request is true
        Client->>Client: Handle state request
    else on_state_request is false and msg.once is true
        Client->>Client: Call on_state_sub(msg.entity_id, msg.attribute)
    end

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1995147 and 99c5044.

Files selected for processing (1)

• tests/test_client.py (4 hunks)

Additional context used

Path-based instructions (1)

tests/test_client.py (1)

Pattern **: - Do not generate or add any sequence diagrams

Additional comments not posted (5)

tests/test_client.py (5)

1863-1863: LGTM!

The addition of the requests list to capture home assistant state requests is a good enhancement to the test.

The code changes are approved.

---

1870-1872: LGTM!

The new callback function on_request_home_assistant_state is correctly implemented.

The code changes are approved.

---

1873-1876: LGTM!

The subscription mechanism is correctly updated to accommodate the new callback.

The code changes are approved.

---

1885-1889: LGTM!

The assertions at the end of the test are correctly updated to reflect the new logic.

The code changes are approved.

---

1900-1901: LGTM!

The final assertions ensure that both the states and requests lists contain the expected values after processing multiple responses.

The code changes are approved.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (538445a) to head (1995147).
Report is 12 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##              main     #930      +/-   ##
===========================================
- Coverage   100.00%   99.96%   -0.04%     
===========================================
  Files           17       17              
  Lines         2563     2575      +12     
===========================================
+ Hits          2563     2574      +11     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.