Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix replacing of headers with overlapping names in HTTPClient. Fixes issue #3483 #3487

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Fix replacing of headers with overlapping names in HTTPClient. Fixes issue #3483 #3487

merged 2 commits into from
Jan 20, 2020

Conversation

Jeroen88
Copy link
Contributor

@Jeroen88 Jeroen88 commented Nov 17, 2019 •
edited
Loading

If two headers with overlapping names are added while replace == true, like in:

http.addHeader("api_token",  "pMXFOLpinQqajaRQJYMeWObg2XYmcX1");
http.addHeader("token", "1234");

then replacing went wrong. This is fixed with this PR.

@Jeroen88 Jeroen88 mentioned this pull request Nov 17, 2019
Closed
@Jeroen88 Jeroen88 changed the title Fix replacing of headers with overlapping names. Fixes issue #3483 Fix replacing of headers with overlapping names inHTTPClient. Fixes issue #3483 Nov 17, 2019
@Jeroen88 Jeroen88 changed the title Fix replacing of headers with overlapping names inHTTPClient. Fixes issue #3483 Fix replacing of headers with overlapping names in HTTPClient. Fixes issue #3483 Nov 17, 2019
@me-no-dev me-no-dev merged commit 7de1717 into espressif:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeroen88 @me-no-dev