Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #3833, data parsing of Eddystone TLM data frame #3836

Merged
merged 2 commits into from
Sep 30, 2020

Conversation

beegee-tokyo
Copy link
Contributor

@beegee-tokyo beegee-tokyo commented Mar 20, 2020

Fix issue #3833, data parsing of Eddystone TLM data frame
Add Beacon scanner example to show usage of BLEEddystoneTLM class and BLEEddystoneURL class
Add EddystoneTLM beacon example
Add EddystoneURL beacon example

Add Beacon scanner example to show usage of BLEEddystoneTLM class and  BLEEddystoneURL class     
Add EddystoneTLM beacon example    
Add EddystoneURL beacon example
@chegewara
Copy link
Contributor

chegewara commented Mar 23, 2020

Everything seems to looks good with one exception:

Found an EddystoneTLM beacon!
Reported battery voltage: 3567mV
Reported temperature from TLM class: 19.54C
Reported temperature from data: 19.54C
Reported advertise count: 4560754     <---- GOOD
Reported time since last reboot: 61874925s <--- GOOD


Version 0
Battery Voltage 3567 mV
Temperature 19.54 C
Adv. Count 45607    <--- BAD
Time in seconds 61874 <--- BAD
Time 0716.03:28:45

@beegee-tokyo
Copy link
Contributor Author

Stupid me! I missed that the original code has a buffer defined that is too short.

If you define a buffer with a size of 6 and you want to snprintf 8 or more digits to it it will fail of course.

Will correct and refresh the pull request.

@beegee-tokyo
Copy link
Contributor Author

@chegewara Thank you for double checking. Hope it will be merged soon.

@me-no-dev me-no-dev merged commit ef2b545 into espressif:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants