improve & fix BLEScan when wantDuplicates #3995
Conversation
saknarak
commented
May 13, 2020
saknarak
commented
- when wantDuplicates, no need to check duplicate and no more insert into vector
- delete advertisedDevice when not insert into vector, fix memory leak
- add showParse when you just want raw advertised data
- when wantDuplicates, no need to check duplicate and no more insert into vector - delete advertisedDevice when not insert into vector, fix memory leak - add showParse when you just want raw advertised data
libraries/BLE/src/BLEScan.cpp
Outdated
| advertisedDevice->setScan(this); | ||
| advertisedDevice->setAddressType(param->scan_rst.ble_addr_type); | ||
|
|
||
| if (!found) { // If we have previously seen this device, don't record it again. | ||
| if (!m_wantDuplicates && !found) { // If we have previously seen this device, don't record it again. |
There was a problem hiding this comment.
What will happen if you want duplicates?
m_wantDuplicates = true
In that case this will always return false and device will never be inserted to a vector:
if (!m_wantDuplicates && !found)
There was a problem hiding this comment.
when start continuous scan with callback. vector add allocate without de-allocatted that cause ESP restart.
when not to keep in vector
- callback was defined.
or 2. wantDuplicates = true
or 3. already in vector (found = true)
then no need to keep it in vector if has callback define and not want duplicate and not already in vector then record it
|
on #4627 I explain why this commit is an issue for me: in a croweded BLE environment (100s devices), a 5sec scan would crash the ESP even in the first scan. So I needed to limit the number of detected devices and I did it with a counter in the callback. But with this commit, when a callback is defined there is no record to vector no matter what, and the scan returns no result. Easiest is to re-allow to call the callback and populate the vector. Not sure why this case was removed. @saknarak @me-no-dev can this be reverted or changed? |
|
I agree, we need this to be fixed or reverted. |
Proposed fix to espressif#4627 as a remediation to PR espressif#3995 espressif#3995 introduced that a device detected on BLE would not be entered in vector if a callback has been defined. By doing so, it was not possible anymore to have a counter in a call back (AND device in vector) to limit the number of detected device in a single scan, which could crash ESP32 as a result.
|
I have created a PR for this : #5241 |
Proposed fix to #4627 as a remediation to PR #3995 #3995 introduced that a device detected on BLE would not be entered in vector if a callback has been defined. By doing so, it was not possible anymore to have a counter in a call back (AND device in vector) to limit the number of detected device in a single scan, which could crash ESP32 as a result.
