Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add I2C_RX_FIFO_OVF_INT_ST handling to i2c_isr_handler_default #4342

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

lienbacher
Copy link
Contributor

I have run into a Problem where my ESP32 would crash with this error message: [E][esp32-hal-i2c.c:1013] i2c_isr_handler_default(): unknown int=4
It turns out i2c_isr_handler_default()does not handle I2C_RXFIFO_OVF_INT_ST at all which ultimately leads to a crash. Handling it the same way as a I2C_RXFIFO_FULL_INT_ST fixes the crashing and only leads to gracefully handled errors in the I2C transaction.

Fixes crash on ESP32 when I2C FiFo overflows and interrupt function is unable to handle crash and throws this error:
[E][esp32-hal-i2c.c:1013] i2c_isr_handler_default(): unknown int=4
@lienbacher
Copy link
Contributor Author

I have run into a Problem where my ESP32 would crash with this error message: [E][esp32-hal-i2c.c:1013] i2c_isr_handler_default(): unknown int=4
It turns out i2c_isr_handler_default()does not handle I2C_RXFIFO_OVF_INT_ST at all which ultimately leads to a crash. Handling it the same way as a I2C_RXFIFO_FULL_INT_ST fixes the crashing and only leads to gracefully handled errors in the I2C transaction.
I have been kindly made aware of this fix by u/azureice on reddit.

@me-no-dev me-no-dev merged commit 2243081 into espressif:master Oct 1, 2020
Girgitt added a commit to Girgitt/arduino-esp32 that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants