etboard pinmap upload #4748
Merged
etboard pinmap upload #4748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You will need to add it to boards.txt as well. |
added 2 commits
February 3, 2021 12:17
me-no-dev
reviewed
Feb 16, 2021
variants/ET_Board/pins_arduino.h
Outdated
| @@ -0,0 +1,20 @@ | |||
| // #include "pinmap.h" | |||
|
|
|||
There was a problem hiding this comment.
please check variants/esp32/pins_arduino.h for proper pin header. You need to have a few defines plus proper declaration of I2C, SPI and ADC pins. You can leave the Dx pins as defines.
me-no-dev
reviewed
Feb 22, 2021
variants/ET_Board/pins_arduino.h
Outdated
| static const uint8_t MISO = 31; | ||
| static const uint8_t SCK = 30; | ||
|
|
||
| static const uint8_t A0 36 // BUILTIN_Potentiometer |
There was a problem hiding this comment.
you have forgotten the equal sign and period at the end. This will not compile :)
static const uint8_t A0 = 36;
There was a problem hiding this comment.
thank you for your advice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to add a device.
Device name is ET_Board.