Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Py: system.part.pairs() is wrong #4622

Closed
RudolfWeeber opened this issue Dec 6, 2022 · 2 comments · Fixed by #4628
Closed

Py: system.part.pairs() is wrong #4622

RudolfWeeber opened this issue Dec 6, 2022 · 2 comments · Fixed by #4628
Labels
Bug CodingDay Python
Milestone
Espresso 4.2.1

Comments

@RudolfWeeber
Copy link
Contributor

if the particle numbering is not consecuitve (contains holes), this misses pairs.
@Koppeprojects
Copy link

I'll fix that.

@Koppeprojects Koppeprojects mentioned this issue Dec 12, 2022
Merged
@jngrad jngrad added this to the Espresso 4.2.1 milestone Dec 12, 2022
@jngrad
Copy link
Member

jngrad commented Dec 12, 2022

This bug was introduced in the 4.2.0 release.

@kodiakhq kodiakhq bot closed this as completed in #4628 Dec 12, 2022
kodiakhq bot added a commit that referenced this issue Dec 12, 2022
@kodiakhq
fixed system.part.pairs() (#4628)
466d54b 
Fixes #4622

Description of changes:
- the `System.part.pairs()` method now returns the correct particle pairs when particle ids aren't both contiguous and starting from 0
jngrad pushed a commit to jngrad/espresso that referenced this issue Dec 23, 2022
@kodiakhq @jngrad
fixed system.part.pairs() (espressomd#4628)
8e171fb 
Fixes espressomd#4622

Description of changes:
- the `System.part.pairs()` method now returns the correct particle pairs when particle ids aren't both contiguous and starting from 0
jngrad pushed a commit to jngrad/espresso that referenced this issue Dec 23, 2022
@kodiakhq @jngrad
fixed system.part.pairs() (espressomd#4628)
2807fd7 
Fixes espressomd#4622

Description of changes:
- the `System.part.pairs()` method now returns the correct particle pairs when particle ids aren't both contiguous and starting from 0
jngrad pushed a commit to jngrad/espresso that referenced this issue Dec 23, 2022
@kodiakhq @jngrad
fixed system.part.pairs() (espressomd#4628)
19c7a54 
Fixes espressomd#4622

Description of changes:
- the `System.part.pairs()` method now returns the correct particle pairs when particle ids aren't both contiguous and starting from 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug CodingDay Python
Projects
None yet
Milestone
Espresso 4.2.1
Development

Successfully merging a pull request may close this issue.

fixed system.part.pairs() Koppeprojects/espresso
3 participants
@RudolfWeeber @jngrad @Koppeprojects